Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
Am Montag, 3. November 2008 schrieb Ehrhardt Christian: +#ifdef __s390__ +#ifndef CONFIG_S390 +#define CONFIG_S390 1 +#endif +#endif + +#endif It seems that currently no header needs this, but better save than sorry. __s390__ is defined by gcc for s390 and s390x, CONFIG_S390 is set on s390 and s390x in the kernel config. This looks right. Acked-by: Christian Borntraeger [EMAIL PROTECTED] -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
Ehrhardt Christian wrote: This adds powerpc to the unifdef header avi introduced. I think s390 should work the same way and is needed as they have libkvm already. Christian/Carsten could you ack that after a quick test if it is working? I don't think it's really needed since we don't depend on these symbols in arch-independent headers. It can't hurt, though, so I don't mind applying it after s390 acks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] kvm-userspace: add ibm archs to unifdef header
Christian Borntraeger wrote: Am Montag, 3. November 2008 schrieb Ehrhardt Christian: +#ifdef __s390__ +#ifndef CONFIG_S390 +#define CONFIG_S390 1 +#endif +#endif + +#endif It seems that currently no header needs this, but better save than sorry. __s390__ is defined by gcc for s390 and s390x, CONFIG_S390 is set on s390 and s390x in the kernel config. This looks right. Okay, applied. Thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html