Re: [PATCH RFC 3/5] KVM: Use rapper functions to create and destroy dirty bitmaps

2010-04-12 Thread Avi Kivity

On 04/12/2010 05:07 AM, Takuya Yoshikawa wrote:

(2010/04/12 2:13), Avi Kivity wrote:

On 04/09/2010 12:34 PM, Takuya Yoshikawa wrote:

For x86, we will change the allocation and free parts to do_mmap() and
do_munmap(). This patch makes it cleaner.



Should be done for all architectures. I don't want different ways of
creating dirty bitmaps for different architectures.



OK. So the only difference for other(generic) implementation would be
if we pin bitmaps or not.


Well, ppc shouldn't need to pin the bitmap either, I'd think.

--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH RFC 3/5] KVM: Use rapper functions to create and destroy dirty bitmaps

2010-04-11 Thread Avi Kivity

On 04/09/2010 12:34 PM, Takuya Yoshikawa wrote:

For x86, we will change the allocation and free parts to do_mmap() and
do_munmap(). This patch makes it cleaner.

   


Should be done for all architectures.  I don't want different ways of 
creating dirty bitmaps for different architectures.


--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [PATCH RFC 3/5] KVM: Use rapper functions to create and destroy dirty bitmaps

2010-04-11 Thread Takuya Yoshikawa

(2010/04/12 2:13), Avi Kivity wrote:

On 04/09/2010 12:34 PM, Takuya Yoshikawa wrote:

For x86, we will change the allocation and free parts to do_mmap() and
do_munmap(). This patch makes it cleaner.



Should be done for all architectures. I don't want different ways of
creating dirty bitmaps for different architectures.



OK. So the only difference for other(generic) implementation would be
if we pin bitmaps or not.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html