Re: [PATCH V2 4/6] kvm tools: Add PPC64 XICS interrupt controller support
On Tue, Dec 20, 2011 at 12:16:40PM +1100, Matt Evans wrote: Hi David, On 14/12/11 13:35, David Gibson wrote: On Tue, Dec 13, 2011 at 06:10:48PM +1100, Matt Evans wrote: This patch adds XICS emulation code (heavily borrowed from QEMU), and wires this into kvm_cpu__irq() to fire a CPU IRQ via KVM. A device tree entry is also added. IPIs work, xics_alloc_irqnum() is added to allocate an external IRQ (which will later be used by the PHB PCI code) and finally, kvm__irq_line() can be called to raise an IRQ on XICS.\ Hrm, looks like you took a somewhat old version of xics.c from qemu. It dangerously uses the same variable names for global irq numbers and numbers local to one ics unit. It used to have at least one bug caused by confusing the two, which I'm not sure if you've also copied. Just had a look at the diffs between this and hw/xics.c from the master branch in your qemu-impreza.git (which I based the kvmtool stuff on) and I can't see anything standing out. Is there a particular commit/patch/variable name you have in mind that I can search for? Sorry, my mistake, I was looking in the wrong place. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 4/6] kvm tools: Add PPC64 XICS interrupt controller support
On Tue, Dec 20, 2011 at 12:16:40PM +1100, Matt Evans wrote: Hi David, On 14/12/11 13:35, David Gibson wrote: On Tue, Dec 13, 2011 at 06:10:48PM +1100, Matt Evans wrote: This patch adds XICS emulation code (heavily borrowed from QEMU), and wires this into kvm_cpu__irq() to fire a CPU IRQ via KVM. A device tree entry is also added. IPIs work, xics_alloc_irqnum() is added to allocate an external IRQ (which will later be used by the PHB PCI code) and finally, kvm__irq_line() can be called to raise an IRQ on XICS.\ Hrm, looks like you took a somewhat old version of xics.c from qemu. It dangerously uses the same variable names for global irq numbers and numbers local to one ics unit. It used to have at least one bug caused by confusing the two, which I'm not sure if you've also copied. Just had a look at the diffs between this and hw/xics.c from the master branch in your qemu-impreza.git (which I based the kvmtool stuff on) and I can't see anything standing out. Is there a particular commit/patch/variable name you have in mind that I can search for? Sorry, my mistake, I was looking in the wrong place. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 4/6] kvm tools: Add PPC64 XICS interrupt controller support
Hi David, On 14/12/11 13:35, David Gibson wrote: On Tue, Dec 13, 2011 at 06:10:48PM +1100, Matt Evans wrote: This patch adds XICS emulation code (heavily borrowed from QEMU), and wires this into kvm_cpu__irq() to fire a CPU IRQ via KVM. A device tree entry is also added. IPIs work, xics_alloc_irqnum() is added to allocate an external IRQ (which will later be used by the PHB PCI code) and finally, kvm__irq_line() can be called to raise an IRQ on XICS.\ Hrm, looks like you took a somewhat old version of xics.c from qemu. It dangerously uses the same variable names for global irq numbers and numbers local to one ics unit. It used to have at least one bug caused by confusing the two, which I'm not sure if you've also copied. Just had a look at the diffs between this and hw/xics.c from the master branch in your qemu-impreza.git (which I based the kvmtool stuff on) and I can't see anything standing out. Is there a particular commit/patch/variable name you have in mind that I can search for? Thanks! Matt -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 4/6] kvm tools: Add PPC64 XICS interrupt controller support
On Tue, Dec 13, 2011 at 06:10:48PM +1100, Matt Evans wrote: This patch adds XICS emulation code (heavily borrowed from QEMU), and wires this into kvm_cpu__irq() to fire a CPU IRQ via KVM. A device tree entry is also added. IPIs work, xics_alloc_irqnum() is added to allocate an external IRQ (which will later be used by the PHB PCI code) and finally, kvm__irq_line() can be called to raise an IRQ on XICS.\ Hrm, looks like you took a somewhat old version of xics.c from qemu. It dangerously uses the same variable names for global irq numbers and numbers local to one ics unit. It used to have at least one bug caused by confusing the two, which I'm not sure if you've also copied. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH V2 4/6] kvm tools: Add PPC64 XICS interrupt controller support
On Tue, Dec 13, 2011 at 06:10:48PM +1100, Matt Evans wrote: This patch adds XICS emulation code (heavily borrowed from QEMU), and wires this into kvm_cpu__irq() to fire a CPU IRQ via KVM. A device tree entry is also added. IPIs work, xics_alloc_irqnum() is added to allocate an external IRQ (which will later be used by the PHB PCI code) and finally, kvm__irq_line() can be called to raise an IRQ on XICS.\ Hrm, looks like you took a somewhat old version of xics.c from qemu. It dangerously uses the same variable names for global irq numbers and numbers local to one ics unit. It used to have at least one bug caused by confusing the two, which I'm not sure if you've also copied. -- David Gibson| I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
