Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
On 09/10/2012 12:26 PM, Jan Kiszka wrote: >> >> Is patch 4 the only one that is at v3, and the rest are to be taken from >> the original posting? > > That is correct. Thanks, applied to uq/master, will push shortly. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
On 2012-09-09 16:13, Avi Kivity wrote: > On 09/06/2012 11:44 AM, Jan Kiszka wrote: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KVM >>> interfaces. This version is 100% identical to what is being maintained >>> in qemu-kvm for several years and is supported by libvirt as well. It is >>> expected to remain relevant for another couple of years until kernels >>> without full-features and performance-wise equivalent VFIO support are >>> obsolete. >>> >>> A refactoring to-do that should be done in-tree is to model MSI and >>> MSI-X support via the generic PCI layer, similar to what VFIO is already >>> doing for MSI-X. This should improve the correctness and clean up the >>> code from duplicate logic. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v3: >>> - addressed comment by Peter (changed device name to kvm-pci-assign + >>>alias) >>> - addressed (most) comments by Michael >>> - fixed INT pin regression >> >> Does someone _disagree_ that there are no open (and reasonably solvable) >> issues and that this can now be merged through uq/master? > > Is patch 4 the only one that is at v3, and the rest are to be taken from > the original posting? That is correct. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
On 09/06/2012 11:44 AM, Jan Kiszka wrote: > On 2012-08-30 20:30, Jan Kiszka wrote: >> This adds PCI device assignment for i386 targets using the classic KVM >> interfaces. This version is 100% identical to what is being maintained >> in qemu-kvm for several years and is supported by libvirt as well. It is >> expected to remain relevant for another couple of years until kernels >> without full-features and performance-wise equivalent VFIO support are >> obsolete. >> >> A refactoring to-do that should be done in-tree is to model MSI and >> MSI-X support via the generic PCI layer, similar to what VFIO is already >> doing for MSI-X. This should improve the correctness and clean up the >> code from duplicate logic. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Changes in v3: >> - addressed comment by Peter (changed device name to kvm-pci-assign + >>alias) >> - addressed (most) comments by Michael >> - fixed INT pin regression > > Does someone _disagree_ that there are no open (and reasonably solvable) > issues and that this can now be merged through uq/master? Is patch 4 the only one that is at v3, and the rest are to be taken from the original posting? -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
On Thu, Sep 6, 2012 at 4:06 PM, Andreas Färber wrote: > Am 06.09.2012 10:44, schrieb Jan Kiszka: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KVM >>> interfaces. This version is 100% identical to what is being maintained >>> in qemu-kvm for several years and is supported by libvirt as well. It is >>> expected to remain relevant for another couple of years until kernels >>> without full-features and performance-wise equivalent VFIO support are >>> obsolete. >>> >>> A refactoring to-do that should be done in-tree is to model MSI and >>> MSI-X support via the generic PCI layer, similar to what VFIO is already >>> doing for MSI-X. This should improve the correctness and clean up the >>> code from duplicate logic. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v3: >>> - addressed comment by Peter (changed device name to kvm-pci-assign + >>>alias) >>> - addressed (most) comments by Michael >>> - fixed INT pin regression >> >> Does someone _disagree_ that there are no open (and reasonably solvable) >> issues and that this can now be merged through uq/master? > > My implicit suggestion was to add a notice that new patch contributions > to the file from date -mm-dd on would be declared GPLv2+, as Paolo > has done elsewhere. That would limit the amount of people to ask for a > potential relicensing attempt. +1 > > For the record, Anthony explained on IRC that the code originated from > Xen originally and thus qemu-kvm.git does not contain the full history > anyway and that pulling in the Mercurial file history and replaying the > KVM history on top was too difficult, therefore this patch with a single > SoB by Jan. > > Andreas > > -- > SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany > GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
On 2012-09-06 18:06, Andreas Färber wrote: > Am 06.09.2012 10:44, schrieb Jan Kiszka: >> On 2012-08-30 20:30, Jan Kiszka wrote: >>> This adds PCI device assignment for i386 targets using the classic KVM >>> interfaces. This version is 100% identical to what is being maintained >>> in qemu-kvm for several years and is supported by libvirt as well. It is >>> expected to remain relevant for another couple of years until kernels >>> without full-features and performance-wise equivalent VFIO support are >>> obsolete. >>> >>> A refactoring to-do that should be done in-tree is to model MSI and >>> MSI-X support via the generic PCI layer, similar to what VFIO is already >>> doing for MSI-X. This should improve the correctness and clean up the >>> code from duplicate logic. >>> >>> Signed-off-by: Jan Kiszka >>> --- >>> >>> Changes in v3: >>> - addressed comment by Peter (changed device name to kvm-pci-assign + >>>alias) >>> - addressed (most) comments by Michael >>> - fixed INT pin regression >> >> Does someone _disagree_ that there are no open (and reasonably solvable) >> issues and that this can now be merged through uq/master? > > My implicit suggestion was to add a notice that new patch contributions > to the file from date -mm-dd on would be declared GPLv2+, as Paolo > has done elsewhere. That would limit the amount of people to ask for a > potential relicensing attempt. Sorry, someone else will have to add this. Personally I think it is pointless to worry about it here anyway as hunting down all contributors and getting them to agree on a GPLv2+ will take longer than the expected lifetime of this component. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
Am 06.09.2012 10:44, schrieb Jan Kiszka: > On 2012-08-30 20:30, Jan Kiszka wrote: >> This adds PCI device assignment for i386 targets using the classic KVM >> interfaces. This version is 100% identical to what is being maintained >> in qemu-kvm for several years and is supported by libvirt as well. It is >> expected to remain relevant for another couple of years until kernels >> without full-features and performance-wise equivalent VFIO support are >> obsolete. >> >> A refactoring to-do that should be done in-tree is to model MSI and >> MSI-X support via the generic PCI layer, similar to what VFIO is already >> doing for MSI-X. This should improve the correctness and clean up the >> code from duplicate logic. >> >> Signed-off-by: Jan Kiszka >> --- >> >> Changes in v3: >> - addressed comment by Peter (changed device name to kvm-pci-assign + >>alias) >> - addressed (most) comments by Michael >> - fixed INT pin regression > > Does someone _disagree_ that there are no open (and reasonably solvable) > issues and that this can now be merged through uq/master? My implicit suggestion was to add a notice that new patch contributions to the file from date -mm-dd on would be declared GPLv2+, as Paolo has done elsewhere. That would limit the amount of people to ask for a potential relicensing attempt. For the record, Anthony explained on IRC that the code originated from Xen originally and thus qemu-kvm.git does not contain the full history anyway and that pulling in the Mercurial file history and replaying the KVM history on top was too difficult, therefore this patch with a single SoB by Jan. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
On Thu, Sep 06, 2012 at 10:44:15AM +0200, Jan Kiszka wrote: > On 2012-08-30 20:30, Jan Kiszka wrote: > > This adds PCI device assignment for i386 targets using the classic KVM > > interfaces. This version is 100% identical to what is being maintained > > in qemu-kvm for several years and is supported by libvirt as well. It is > > expected to remain relevant for another couple of years until kernels > > without full-features and performance-wise equivalent VFIO support are > > obsolete. > > > > A refactoring to-do that should be done in-tree is to model MSI and > > MSI-X support via the generic PCI layer, similar to what VFIO is already > > doing for MSI-X. This should improve the correctness and clean up the > > code from duplicate logic. > > > > Signed-off-by: Jan Kiszka > > --- > > > > Changes in v3: > > - addressed comment by Peter (changed device name to kvm-pci-assign + > >alias) > > - addressed (most) comments by Michael > > - fixed INT pin regression > > Does someone _disagree_ that there are no open (and reasonably solvable) > issues and that this can now be merged through uq/master? > > Jan Ugh this thread was shamelessly highjacked by coding style bike-shedding. I am guilty to. In hopes of making amends: Acked-by: Michael S. Tsirkin > -- > Siemens AG, Corporate Technology, CT RTC ITP SDP-DE > Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v3 4/4] kvm: i386: Add classic PCI device assignment
On 2012-08-30 20:30, Jan Kiszka wrote: > This adds PCI device assignment for i386 targets using the classic KVM > interfaces. This version is 100% identical to what is being maintained > in qemu-kvm for several years and is supported by libvirt as well. It is > expected to remain relevant for another couple of years until kernels > without full-features and performance-wise equivalent VFIO support are > obsolete. > > A refactoring to-do that should be done in-tree is to model MSI and > MSI-X support via the generic PCI layer, similar to what VFIO is already > doing for MSI-X. This should improve the correctness and clean up the > code from duplicate logic. > > Signed-off-by: Jan Kiszka > --- > > Changes in v3: > - addressed comment by Peter (changed device name to kvm-pci-assign + >alias) > - addressed (most) comments by Michael > - fixed INT pin regression Does someone _disagree_ that there are no open (and reasonably solvable) issues and that this can now be merged through uq/master? Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
