Re: [PATCH v4 2/4] kvmtool: ARM64: Add target type potenza for aarch64
On 29 September 2014 22:30, Andre Przywara andre.przyw...@arm.com wrote: On 19/09/14 00:57, Anup Patel wrote: The VCPU target type KVM_ARM_TARGET_XGENE_POTENZA is available in latest Linux-3.16-rcX or higher hence register aarch64 target type for it. This patch enables us to run KVMTOOL on X-Gene Potenza host. I still don't like the addition of another CPU, but for the sake of running older kernels (which seems to have a use-case in your case) I am OK with this. Maybe it's worth adding a comment which states that this list is closed and just provided to support older kernels? So that other SoCs don't get funny ideas... ;-) Sure, I will add a comment for this. Regards, Anup Cheers, Andre. Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org Signed-off-by: Anup Patel anup.pa...@linaro.org --- tools/kvm/arm/aarch64/arm-cpu.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/kvm/arm/aarch64/arm-cpu.c b/tools/kvm/arm/aarch64/arm-cpu.c index 9ee3da3..51a1e2f 100644 --- a/tools/kvm/arm/aarch64/arm-cpu.c +++ b/tools/kvm/arm/aarch64/arm-cpu.c @@ -46,11 +46,18 @@ static struct kvm_arm_target target_cortex_a57 = { .init = arm_cpu__vcpu_init, }; +static struct kvm_arm_target target_potenza = { + .id = KVM_ARM_TARGET_XGENE_POTENZA, + .compatible = arm,arm-v8, + .init = arm_cpu__vcpu_init, +}; + static int arm_cpu__core_init(struct kvm *kvm) { return (kvm_cpu__register_kvm_arm_target(target_generic_v8) || kvm_cpu__register_kvm_arm_target(target_aem_v8) || kvm_cpu__register_kvm_arm_target(target_foundation_v8) || - kvm_cpu__register_kvm_arm_target(target_cortex_a57)); + kvm_cpu__register_kvm_arm_target(target_cortex_a57) || + kvm_cpu__register_kvm_arm_target(target_potenza)); } core_init(arm_cpu__core_init); -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England Wales, Company No: 2548782 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 2/4] kvmtool: ARM64: Add target type potenza for aarch64
On 19/09/14 00:57, Anup Patel wrote: The VCPU target type KVM_ARM_TARGET_XGENE_POTENZA is available in latest Linux-3.16-rcX or higher hence register aarch64 target type for it. This patch enables us to run KVMTOOL on X-Gene Potenza host. I still don't like the addition of another CPU, but for the sake of running older kernels (which seems to have a use-case in your case) I am OK with this. Maybe it's worth adding a comment which states that this list is closed and just provided to support older kernels? So that other SoCs don't get funny ideas... ;-) Cheers, Andre. Signed-off-by: Pranavkumar Sawargaonkar pranavku...@linaro.org Signed-off-by: Anup Patel anup.pa...@linaro.org --- tools/kvm/arm/aarch64/arm-cpu.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/kvm/arm/aarch64/arm-cpu.c b/tools/kvm/arm/aarch64/arm-cpu.c index 9ee3da3..51a1e2f 100644 --- a/tools/kvm/arm/aarch64/arm-cpu.c +++ b/tools/kvm/arm/aarch64/arm-cpu.c @@ -46,11 +46,18 @@ static struct kvm_arm_target target_cortex_a57 = { .init = arm_cpu__vcpu_init, }; +static struct kvm_arm_target target_potenza = { + .id = KVM_ARM_TARGET_XGENE_POTENZA, + .compatible = arm,arm-v8, + .init = arm_cpu__vcpu_init, +}; + static int arm_cpu__core_init(struct kvm *kvm) { return (kvm_cpu__register_kvm_arm_target(target_generic_v8) || kvm_cpu__register_kvm_arm_target(target_aem_v8) || kvm_cpu__register_kvm_arm_target(target_foundation_v8) || - kvm_cpu__register_kvm_arm_target(target_cortex_a57)); + kvm_cpu__register_kvm_arm_target(target_cortex_a57) || + kvm_cpu__register_kvm_arm_target(target_potenza)); } core_init(arm_cpu__core_init); -- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you. ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England Wales, Company No: 2557590 ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England Wales, Company No: 2548782 -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html