Re: [PULL 5/8] KVM: async_pf: Provide additional direct page notification

2014-01-31 Thread Paolo Bonzini 

Il 30/01/2014 13:53, Christian Borntraeger ha scritto:

+static inline void kvm_async_page_present_async(struct kvm_vcpu *vcpu,
+   struct kvm_async_pf *work)
+{
+#ifndef CONFIG_KVM_ASYNC_PF_SYNC
+   kvm_arch_async_page_present(vcpu, work);
+#endif
+}
+


This is not used, should it be used in kvm_check_async_pf_completion?

Paolo
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PULL 5/8] KVM: async_pf: Provide additional direct page notification

2014-01-31 Thread Christian Borntraeger 
On 31/01/14 12:38, Paolo Bonzini wrote:
 Il 30/01/2014 13:53, Christian Borntraeger ha scritto:
 +static inline void kvm_async_page_present_async(struct kvm_vcpu *vcpu,
 +struct kvm_async_pf *work)
 +{
 +#ifndef CONFIG_KVM_ASYNC_PF_SYNC
 +kvm_arch_async_page_present(vcpu, work);
 +#endif
 +}
 +
 
 This is not used, should it be used in kvm_check_async_pf_completion?

Yes. Looks like this got mixed up when updating the branch from before
commit f2e106692d5189303997ad7b96de8d8123aa5613 (KVM: Drop FOLL_GET in 
GUP when doing async page fault) on top of this commit. Do you want a
respin of the series or an on top patch?

Christian

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PULL 5/8] KVM: async_pf: Provide additional direct page notification

2014-01-31 Thread Paolo Bonzini 

Il 31/01/2014 13:24, Christian Borntraeger ha scritto:

On 31/01/14 12:38, Paolo Bonzini wrote:

Il 30/01/2014 13:53, Christian Borntraeger ha scritto:

+static inline void kvm_async_page_present_async(struct kvm_vcpu *vcpu,
+struct kvm_async_pf *work)
+{
+#ifndef CONFIG_KVM_ASYNC_PF_SYNC
+kvm_arch_async_page_present(vcpu, work);
+#endif
+}
+


This is not used, should it be used in kvm_check_async_pf_completion?


Yes. Looks like this got mixed up when updating the branch from before
commit f2e106692d5189303997ad7b96de8d8123aa5613 (KVM: Drop FOLL_GET in
GUP when doing async page fault) on top of this commit. Do you want a
respin of the series or an on top patch?


It should only break s390, so your call.  I think a respin would be 
preferrable for you. :)


Paolo

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html