Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs
On 05.07.2012, at 14:54, Caraman Mihai Claudiu-B02008 wrote: >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Thursday, July 05, 2012 3:13 PM >> To: Caraman Mihai Claudiu-B02008 >> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- >> d...@lists.ozlabs.org; qemu-...@nongnu.org >> Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR >> support in sregs >> >> On 07/05/2012 01:49 PM, Caraman Mihai Claudiu-B02008 wrote: >>>> -Original Message- >>>> From: Alexander Graf [mailto:ag...@suse.de] >>>> Sent: Wednesday, July 04, 2012 4:34 PM >>>> To: Caraman Mihai Claudiu-B02008 >>>> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- >>>> d...@lists.ozlabs.org; qemu-...@nongnu.org >>>> Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR >>>> support in sregs >>>> >>>> >>>> On 25.06.2012, at 14:26, Mihai Caraman wrote: >>>> >>>>> Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs >>>>> for 64-bit hosts. >>>> Please also implement a ONE_REG interface while at it. Over time, I'd >>>> like to move towards ONE_REG instead of the messy regs/sregs API. >>> ONE_REG doesn't seem to be implemented at all for book3e, I looked at >>> kvm_vcpu_ioctl_set_one_reg/kvm_vcpu_ioctl_get_one_reg in booke.c file. >>> >>> I can take care of it soon but in a different patch set. It's ok like >> this? >> >> Do it in a different patch, but as part of this patch set. > > Hmm ... then if you don't disagree I will do it as a prerequisite patch since > I want > to keep this patchset strictly for 64-bit support. I don't understand? You just make the same functionality available through 2 interfaces to user space. > I am not familiar with ONE_REG, is qemu tailored to use it? I need a way to > test it. ONE_REG is just a more extensible ioctl. Just read up on it in the documentation and you'll see what I mean :) Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, July 05, 2012 3:13 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org; qemu-...@nongnu.org > Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > support in sregs > > On 07/05/2012 01:49 PM, Caraman Mihai Claudiu-B02008 wrote: > >> -Original Message- > >> From: Alexander Graf [mailto:ag...@suse.de] > >> Sent: Wednesday, July 04, 2012 4:34 PM > >> To: Caraman Mihai Claudiu-B02008 > >> Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > >> d...@lists.ozlabs.org; qemu-...@nongnu.org > >> Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > >> support in sregs > >> > >> > >> On 25.06.2012, at 14:26, Mihai Caraman wrote: > >> > >>> Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs > >>> for 64-bit hosts. > >> Please also implement a ONE_REG interface while at it. Over time, I'd > >> like to move towards ONE_REG instead of the messy regs/sregs API. > > ONE_REG doesn't seem to be implemented at all for book3e, I looked at > > kvm_vcpu_ioctl_set_one_reg/kvm_vcpu_ioctl_get_one_reg in booke.c file. > > > > I can take care of it soon but in a different patch set. It's ok like > this? > > Do it in a different patch, but as part of this patch set. Hmm ... then if you don't disagree I will do it as a prerequisite patch since I want to keep this patchset strictly for 64-bit support. I am not familiar with ONE_REG, is qemu tailored to use it? I need a way to test it. -Mike -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs
On 07/05/2012 01:49 PM, Caraman Mihai Claudiu-B02008 wrote: -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Wednesday, July 04, 2012 4:34 PM To: Caraman Mihai Claudiu-B02008 Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- d...@lists.ozlabs.org; qemu-...@nongnu.org Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs On 25.06.2012, at 14:26, Mihai Caraman wrote: Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs for 64-bit hosts. Please also implement a ONE_REG interface while at it. Over time, I'd like to move towards ONE_REG instead of the messy regs/sregs API. ONE_REG doesn't seem to be implemented at all for book3e, I looked at kvm_vcpu_ioctl_set_one_reg/kvm_vcpu_ioctl_get_one_reg in booke.c file. I can take care of it soon but in a different patch set. It's ok like this? Do it in a different patch, but as part of this patch set. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
RE: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Wednesday, July 04, 2012 4:34 PM > To: Caraman Mihai Claudiu-B02008 > Cc: kvm-...@vger.kernel.org; kvm@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org; qemu-...@nongnu.org > Subject: Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR > support in sregs > > > On 25.06.2012, at 14:26, Mihai Caraman wrote: > > > Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs > > for 64-bit hosts. > > Please also implement a ONE_REG interface while at it. Over time, I'd > like to move towards ONE_REG instead of the messy regs/sregs API. ONE_REG doesn't seem to be implemented at all for book3e, I looked at kvm_vcpu_ioctl_set_one_reg/kvm_vcpu_ioctl_get_one_reg in booke.c file. I can take care of it soon but in a different patch set. It's ok like this? -Mike -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [Qemu-ppc] [RFC PATCH 03/17] KVM: PPC64: booke: Add EPCR support in sregs
On 25.06.2012, at 14:26, Mihai Caraman wrote: > Add KVM_SREGS_E_64 feature and EPCR spr support in get/set sregs > for 64-bit hosts. Please also implement a ONE_REG interface while at it. Over time, I'd like to move towards ONE_REG instead of the messy regs/sregs API. Alex -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
