Re: [RFC PATCH 1/7] [hyper-v] Add hyper-v parameters block.
On 10/11/2011 09:35 AM, Paolo Bonzini wrote: I think these could be sub-options of -machine. Oops, I obviously meant -cpu like Jan said. Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/7] [hyper-v] Add hyper-v parameters block.
On 10/09/2011 08:52 PM, Vadim Rozenfeld wrote:
---
qemu-options.hx | 23 +++
vl.c|2 ++
2 files changed, 25 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 3a13533..9f60059 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2483,6 +2483,29 @@ DEF("kvm-shadow-memory", HAS_ARG,
QEMU_OPTION_kvm_shadow_memory,
"allocate MEGABYTES for kvm mmu shadowing\n",
QEMU_ARCH_I386)
+DEF("hyperv", HAS_ARG, QEMU_OPTION_hyperv,
+"-hyperv [vapic=on|off][,spinlock=retries][,wd=on|off]\n"
+"enable Hyper-V Enlightenment\n",
+QEMU_ARCH_ALL)
+STEXI
+@item -hyperv
+@findex -hyperv
+@item vapic=@var{vapic}
+@var{vapic} is "on" or "off" and allows for using virtual APIC.
+Default is "off".
+@findex vapic
+@item spinlock=@var{spinlock}
+@var{spinlock} is a recommended number of attempts to retry
+a spinlock failure befor notifying the hypervisor.
+Default is 0x (never to retry).
+@findex spinlock
+:@item wd=@var{wd}
+@var{wd} is "on" or "off" and recommends using relaxed timing.
+Default is "off"
+@findex wd
+Simulate Hyper-V Enlightenment. Disable by default.
+ETEXI
+
HXCOMM This is the last statement. Insert new options before this line!
STEXI
@end table
diff --git a/vl.c b/vl.c
index b0358e9..a6d1fc0 100644
--- a/vl.c
+++ b/vl.c
@@ -3185,6 +3185,8 @@ int main(int argc, char **argv, char **envp)
fclose(fp);
break;
}
+case QEMU_OPTION_hyperv:
+break;
default:
os_parse_cmd_args(popt->index, optarg);
}
I think these could be sub-options of -machine.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/7] [hyper-v] Add hyper-v parameters block.
On 2011-10-10 11:40, Vadim Rozenfeld wrote:
> On Mon, 2011-10-10 at 08:54 +0200, Jan Kiszka wrote:
>> On 2011-10-09 20:52, Vadim Rozenfeld wrote:
>>> ---
>>> qemu-options.hx | 23 +++
>>> vl.c|2 ++
>>> 2 files changed, 25 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/qemu-options.hx b/qemu-options.hx
>>> index 3a13533..9f60059 100644
>>> --- a/qemu-options.hx
>>> +++ b/qemu-options.hx
>>> @@ -2483,6 +2483,29 @@ DEF("kvm-shadow-memory", HAS_ARG,
>>> QEMU_OPTION_kvm_shadow_memory,
>>> "allocate MEGABYTES for kvm mmu shadowing\n",
>>> QEMU_ARCH_I386)
>>>
>>> +DEF("hyperv", HAS_ARG, QEMU_OPTION_hyperv,
>>> +"-hyperv [vapic=on|off][,spinlock=retries][,wd=on|off]\n"
>>> +"enable Hyper-V Enlightenment\n",
>>> +QEMU_ARCH_ALL)
>>
>> These are CPU feature, so -cpu +/-hv_vapic,+/-hv_spinlock etc. looks
>> more appropriate than a new command line parameter.
>>
> I would like to keep hyper-v settings apart from cpu features for a very
> simple reason: if hyper-v VMBus support will be added one day, it won't
> be a CPU only feature anymore.
Then that feature would be controlled by adding the corresponding
device. There is no need for -hyperv.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/7] [hyper-v] Add hyper-v parameters block.
On Mon, 2011-10-10 at 08:54 +0200, Jan Kiszka wrote:
> On 2011-10-09 20:52, Vadim Rozenfeld wrote:
> > ---
> > qemu-options.hx | 23 +++
> > vl.c|2 ++
> > 2 files changed, 25 insertions(+), 0 deletions(-)
> >
> > diff --git a/qemu-options.hx b/qemu-options.hx
> > index 3a13533..9f60059 100644
> > --- a/qemu-options.hx
> > +++ b/qemu-options.hx
> > @@ -2483,6 +2483,29 @@ DEF("kvm-shadow-memory", HAS_ARG,
> > QEMU_OPTION_kvm_shadow_memory,
> > "allocate MEGABYTES for kvm mmu shadowing\n",
> > QEMU_ARCH_I386)
> >
> > +DEF("hyperv", HAS_ARG, QEMU_OPTION_hyperv,
> > +"-hyperv [vapic=on|off][,spinlock=retries][,wd=on|off]\n"
> > +"enable Hyper-V Enlightenment\n",
> > +QEMU_ARCH_ALL)
>
> These are CPU feature, so -cpu +/-hv_vapic,+/-hv_spinlock etc. looks
> more appropriate than a new command line parameter.
>
I would like to keep hyper-v settings apart from cpu features for a very
simple reason: if hyper-v VMBus support will be added one day, it won't
be a CPU only feature anymore.
> BTW, documentation and maybe also option processing should make clear
> that this is limited to KVM mode for now.
>
Will add it.
Vadim
> Jan
>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [RFC PATCH 1/7] [hyper-v] Add hyper-v parameters block.
On 2011-10-09 20:52, Vadim Rozenfeld wrote:
> ---
> qemu-options.hx | 23 +++
> vl.c|2 ++
> 2 files changed, 25 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 3a13533..9f60059 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2483,6 +2483,29 @@ DEF("kvm-shadow-memory", HAS_ARG,
> QEMU_OPTION_kvm_shadow_memory,
> "allocate MEGABYTES for kvm mmu shadowing\n",
> QEMU_ARCH_I386)
>
> +DEF("hyperv", HAS_ARG, QEMU_OPTION_hyperv,
> +"-hyperv [vapic=on|off][,spinlock=retries][,wd=on|off]\n"
> +"enable Hyper-V Enlightenment\n",
> +QEMU_ARCH_ALL)
These are CPU feature, so -cpu +/-hv_vapic,+/-hv_spinlock etc. looks
more appropriate than a new command line parameter.
BTW, documentation and maybe also option processing should make clear
that this is limited to KVM mode for now.
Jan
signature.asc
Description: OpenPGP digital signature
