Re: [RFC v3 0/6] networking: address root block upon initialization

2014-03-03 Thread Luis R. Rodriguez
On Mon, Mar 3, 2014 at 2:46 PM, Luis R. Rodriguez
mcg...@do-not-panic.com wrote:
 From: Luis R. Rodriguez mcg...@suse.com

-- snip --

 As I tested using the root block preference I noticed that if a net_device
 slave under the bridge gets the designated root port prior to setting in
 userspace the root_block feature enabling the feature won't kick the
 bridge to remove that net_device from the designated port. I addressed
 that issue and also upkeeping the initial random MAC address given to
 the bridge as if othwerwise we'd end up with a zero MAC address bridge
 if we root block all ports. I have only done local tests I'd appreciate a
 bit more wide test coverage and review.


Stephen,

I should note that even if we discard patches 4-6 patches for an
alternative implementation patches 1-3 should still be applicable for
review. Let me know what you think of those.

  Luis
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [RFC v3 0/6] networking: address root block upon initialization

2014-03-03 Thread Stephen Hemminger
On Mon, 3 Mar 2014 17:05:18 -0800
Luis R. Rodriguez mcg...@suse.com wrote:

 On Mon, Mar 3, 2014 at 2:46 PM, Luis R. Rodriguez
 mcg...@do-not-panic.com wrote:
  From: Luis R. Rodriguez mcg...@suse.com
 
 -- snip --
 
  As I tested using the root block preference I noticed that if a net_device
  slave under the bridge gets the designated root port prior to setting in
  userspace the root_block feature enabling the feature won't kick the
  bridge to remove that net_device from the designated port. I addressed
  that issue and also upkeeping the initial random MAC address given to
  the bridge as if othwerwise we'd end up with a zero MAC address bridge
  if we root block all ports. I have only done local tests I'd appreciate a
  bit more wide test coverage and review.
 
 
 Stephen,
 
 I should note that even if we discard patches 4-6 patches for an
 alternative implementation patches 1-3 should still be applicable for
 review. Let me know what you think of those.
 
   Luis
 --
 To unsubscribe from this list: send the line unsubscribe netdev in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

I agree with 0-3 as normal improvements.
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html