Re: Request VFIO inclusion in linux-next
On 27/06/12 22:37, Dan Carpenter wrote: On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: Hi, VFIO has been kicking around for well over a year now and has been posted numerous times for review. The pre-requirements are finally available in linux-next (or will be in the 20120626 build) so I'd like to request a new branch be included in linux-next with a goal of being accepted into v3.6. Could you run Sparse over the driver? http://lwn.net/Articles/205624/ It reports a bunch of endian problems. Some are definitely bugs like: *prev |= cpu_to_le32((u32)epos 20); What is wrong here? -- Alexey -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Request VFIO inclusion in linux-next
On Mon, 2012-07-02 at 13:41 +1000, Alexey Kardashevskiy wrote: On 27/06/12 22:37, Dan Carpenter wrote: On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: Hi, VFIO has been kicking around for well over a year now and has been posted numerous times for review. The pre-requirements are finally available in linux-next (or will be in the 20120626 build) so I'd like to request a new branch be included in linux-next with a goal of being accepted into v3.6. Could you run Sparse over the driver? http://lwn.net/Articles/205624/ It reports a bunch of endian problems. Some are definitely bugs like: *prev |= cpu_to_le32((u32)epos 20); What is wrong here? I believe the only thing wrong here was that prev was a u32* instead of a __le32*. The new version in my tree has much better endian annotation after going through all the sparse errors. The only bug I found in the cleanup was the handling of rbar. It was missing the le32_to_cpu as we copied it out of vconfig. This is later used with pci_user_write_config_dword, so it needs to be in native endian. Thanks, Alex -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Request VFIO inclusion in linux-next
On Wed, Jun 27, 2012 at 01:23:23PM -0600, Alex Williamson wrote: On Wed, 2012-06-27 at 15:37 +0300, Dan Carpenter wrote: On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: Hi, VFIO has been kicking around for well over a year now and has been posted numerous times for review. The pre-requirements are finally available in linux-next (or will be in the 20120626 build) so I'd like to request a new branch be included in linux-next with a goal of being accepted into v3.6. Could you run Sparse over the driver? http://lwn.net/Articles/205624/ It reports a bunch of endian problems. Some are definitely bugs like: *prev |= cpu_to_le32((u32)epos 20); Done. Mostly just adding annotation, but it did find a bug or two. Should be cleaned up in tomorrow's next. Thanks for the report, Cool. I have some Smatch fixes as well. I've updated them to apply on top of today's linux-next. regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Request VFIO inclusion in linux-next
On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: Hi, VFIO has been kicking around for well over a year now and has been posted numerous times for review. The pre-requirements are finally available in linux-next (or will be in the 20120626 build) so I'd like to request a new branch be included in linux-next with a goal of being accepted into v3.6. Could you run Sparse over the driver? http://lwn.net/Articles/205624/ It reports a bunch of endian problems. Some are definitely bugs like: *prev |= cpu_to_le32((u32)epos 20); regards, dan carpenter -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Request VFIO inclusion in linux-next
On Wed, 2012-06-27 at 15:37 +0300, Dan Carpenter wrote: On Mon, Jun 25, 2012 at 10:55:52PM -0600, Alex Williamson wrote: Hi, VFIO has been kicking around for well over a year now and has been posted numerous times for review. The pre-requirements are finally available in linux-next (or will be in the 20120626 build) so I'd like to request a new branch be included in linux-next with a goal of being accepted into v3.6. Could you run Sparse over the driver? http://lwn.net/Articles/205624/ It reports a bunch of endian problems. Some are definitely bugs like: *prev |= cpu_to_le32((u32)epos 20); Done. Mostly just adding annotation, but it did find a bug or two. Should be cleaned up in tomorrow's next. Thanks for the report, Alex -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Request VFIO inclusion in linux-next
On Mon, 2012-06-25 at 22:55 -0600, Alex Williamson wrote: Hi, VFIO has been kicking around for well over a year now and has been posted numerous times for review. The pre-requirements are finally available in linux-next (or will be in the 20120626 build) so I'd like to request a new branch be included in linux-next with a goal of being accepted into v3.6. Ack. Let's get that in, it's been simmering for too long and we'll need that to do PCI pass-through on KVM powerpc. Cheers, Ben. VFIO is a userspace driver interface designed to support assignment of devices into virtual machines using IOMMU level access control. This IOMMU requirement, secure resource access, and flexible interrupt support make VFIO unique from existing drivers, like UIO. VFIO supports modular backends for both IOMMU and device access. Initial backends are included for PCI device assignment using the IOMMU API in a manner compatible with x86 device assignment. POWER support is also under development, making use of the same PCI device backend, but adding new IOMMU support for their platforms. As with previous versions of VFIO, Qemu is targeted as a primary user and a working development tree including vfio-pci support can be found here: git://github.com/awilliam/qemu-vfio.git iommu-group-vfio Eventually we hope VFIO can deprecate the x86, PCI-specific device assignment currently used by KVM. The info for linux-next: Tree: git://github.com/awilliam/linux-vfio.git Branch: next Contact: Alex Williamson alex.william...@redhat.com This branch should be applied after both Bjorn's PCI next branch and Joerg's IOMMU next branch and contains the following changes: Documentation/ioctl/ioctl-number.txt |1 Documentation/vfio.txt | 315 +++ MAINTAINERS |8 drivers/Kconfig |2 drivers/Makefile |1 drivers/vfio/Kconfig | 16 drivers/vfio/Makefile|3 drivers/vfio/pci/Kconfig |8 drivers/vfio/pci/Makefile|4 drivers/vfio/pci/vfio_pci.c | 565 drivers/vfio/pci/vfio_pci_config.c | 1528 +++ drivers/vfio/pci/vfio_pci_intrs.c| 727 drivers/vfio/pci/vfio_pci_private.h | 91 ++ drivers/vfio/pci/vfio_pci_rdwr.c | 269 ++ drivers/vfio/vfio.c | 1420 drivers/vfio/vfio_iommu_type1.c | 754 + include/linux/vfio.h | 445 ++ 17 files changed, 6157 insertions(+) If there are any objections to including this, please speak now. If anything looks amiss in the branch, let me know. I've never hosted a next branch. Review comments welcome and I'll be glad to post the series in email again if requested. Thanks, Alex -- To unsubscribe from this list: send the line unsubscribe linux-pci in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: Request VFIO inclusion in linux-next
Hi Alex, On Mon, 25 Jun 2012 22:55:52 -0600 Alex Williamson alex.william...@redhat.com wrote: VFIO has been kicking around for well over a year now and has been posted numerous times for review. The pre-requirements are finally available in linux-next (or will be in the 20120626 build) so I'd like to request a new branch be included in linux-next with a goal of being accepted into v3.6. The info for linux-next: Tree: git://github.com/awilliam/linux-vfio.git Branch: next Contact: Alex Williamson alex.william...@redhat.com This branch should be applied after both Bjorn's PCI next branch and Joerg's IOMMU next branch I have added this from today. Since this tree merges (parts of) the pci and iommu trees, I am hoping that those are to remain stable - if not, then you need to stay alert if they are rebased. Thanks for adding your subsystem tree as a participant of linux-next. As you may know, this is not a judgment of your code. The purpose of linux-next is for integration testing and to lower the impact of conflicts between subsystems in the next merge window. You will need to ensure that the patches/commits in your tree/series have been: * submitted under GPL v2 (or later) and include the Contributor's Signed-off-by, * posted to the relevant mailing list, * reviewed by you (or another maintainer of your subsystem tree), * successfully unit tested, and * destined for the current or next Linux merge window. Basically, this should be just what you would send to Linus (or ask him to fetch). It is allowed to be rebased if you deem it necessary. -- Cheers, Stephen Rothwell s...@canb.auug.org.au Legal Stuff: By participating in linux-next, your subsystem tree contributions are public and will be included in the linux-next trees. You may be sent e-mail messages indicating errors or other issues when the patches/commits from your subsystem tree are merged and tested in linux-next. These messages may also be cross-posted to the linux-next mailing list, the linux-kernel mailing list, etc. The linux-next tree project and IBM (my employer) make no warranties regarding the linux-next project, the testing procedures, the results, the e-mails, etc. If you don't agree to these ground rules, let me know and I'll remove your tree from participation in linux-next. pgpBcKIHoRdyA.pgp Description: PGP signature
Request VFIO inclusion in linux-next
Hi, VFIO has been kicking around for well over a year now and has been posted numerous times for review. The pre-requirements are finally available in linux-next (or will be in the 20120626 build) so I'd like to request a new branch be included in linux-next with a goal of being accepted into v3.6. VFIO is a userspace driver interface designed to support assignment of devices into virtual machines using IOMMU level access control. This IOMMU requirement, secure resource access, and flexible interrupt support make VFIO unique from existing drivers, like UIO. VFIO supports modular backends for both IOMMU and device access. Initial backends are included for PCI device assignment using the IOMMU API in a manner compatible with x86 device assignment. POWER support is also under development, making use of the same PCI device backend, but adding new IOMMU support for their platforms. As with previous versions of VFIO, Qemu is targeted as a primary user and a working development tree including vfio-pci support can be found here: git://github.com/awilliam/qemu-vfio.git iommu-group-vfio Eventually we hope VFIO can deprecate the x86, PCI-specific device assignment currently used by KVM. The info for linux-next: Tree: git://github.com/awilliam/linux-vfio.git Branch: next Contact: Alex Williamson alex.william...@redhat.com This branch should be applied after both Bjorn's PCI next branch and Joerg's IOMMU next branch and contains the following changes: Documentation/ioctl/ioctl-number.txt |1 Documentation/vfio.txt | 315 +++ MAINTAINERS |8 drivers/Kconfig |2 drivers/Makefile |1 drivers/vfio/Kconfig | 16 drivers/vfio/Makefile|3 drivers/vfio/pci/Kconfig |8 drivers/vfio/pci/Makefile|4 drivers/vfio/pci/vfio_pci.c | 565 drivers/vfio/pci/vfio_pci_config.c | 1528 +++ drivers/vfio/pci/vfio_pci_intrs.c| 727 drivers/vfio/pci/vfio_pci_private.h | 91 ++ drivers/vfio/pci/vfio_pci_rdwr.c | 269 ++ drivers/vfio/vfio.c | 1420 drivers/vfio/vfio_iommu_type1.c | 754 + include/linux/vfio.h | 445 ++ 17 files changed, 6157 insertions(+) If there are any objections to including this, please speak now. If anything looks amiss in the branch, let me know. I've never hosted a next branch. Review comments welcome and I'll be glad to post the series in email again if requested. Thanks, Alex -- To unsubscribe from this list: send the line unsubscribe kvm in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
