Re: SR-IOV: patches are available for Linux kernel [4/4]

2008-08-14 Thread Greg KH 
On Thu, Aug 14, 2008 at 03:50:26PM +0800, Zhao, Yu wrote:
> On Thursday, August 14, 2008 7:46 AM, Greg KH  
> wrote:
> > On Wed, Aug 13, 2008 at 01:09:16PM -0700, Randy Dunlap wrote:
> >> On Tue, 12 Aug 2008 16:46:39 +0800 Zhao, Yu wrote:
> >> 
> >>> [PATCH 4/4] PCI: document SR-IOV
> >>> 
> >>> SR-IOV Documentation.
> >>> 
> >>> Signed-off-by: Yu Zhao <[EMAIL PROTECTED]>
> >>> Signed-off-by:  Eddie Dong <[EMAIL PROTECTED]>
> >>> 
> >>> ---
> >>>  Documentation/ABI/testing/sysfs-bus-pci |   13 ++
> >>>  Documentation/PCI/00-INDEX  |2
> >>>  Documentation/PCI/pci-iov-howto.txt |  170
> > +++
> >>>  3 files changed, 185 insertions(+), 0 deletions(-)
> >>> 
> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-pci
> > b/Documentation/ABI/testing/sysfs-bus-pci
> >>> index ceddcff..9ada27b 100644
> >>> --- a/Documentation/ABI/testing/sysfs-bus-pci
> >>> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> >>> @@ -9,3 +9,16 @@ Description:
> >>>   that some devices may have malformatted data.  If the
> >>>   underlying VPD has a writable section then the
> >>>   corresponding section of this file will be writable. +
> >>> +What:/sys/bus/pci/devices/.../iov
> >>> +Date:August 2008
> >>> +Contact: Yu Zhao <[EMAIL PROTECTED]>
> >>> +Description:
> >>> + This file will appear when SR-IOV capability is enabled
> >>> + by the device driver if supported. It holds number of
> >>> + available Virtual Functions and Bus, Device, Function
> >>> + number and status of these Virtual Functions that belong
> >>> + to this device (Physical Function). This file can be
> >> 
> >> This one file contains available VFs, Bus:dev:Func number, and
> >> status? Sounds like a misuse (abuse) of sysfs "one value per file"
> >> mantra, but I'll read below to see how it's done.
> >> 
> >> [added GregKH to cc: list]
> > 
> > I agree, why not just display the device tree of available devices
> > like all other busses do? 
> > 
> 
> Thanks for the comments. 
> 
> Will separate this file to
> /sys/bus/pci/devices/.../iov/{NumVFs,VF1,VF2,...}. The NumVFs file
> contains number of available VFs, and each VF file contains
> "bus:dev.func=status". Sounds better?

That sounds better yes.

Please use a 'struct device' for this as well, not a "raw" kobject.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: SR-IOV: patches are available for Linux kernel [4/4]

2008-08-14 Thread Zhao, Yu 
On Thursday, August 14, 2008 7:46 AM, Greg KH  wrote:
> On Wed, Aug 13, 2008 at 01:09:16PM -0700, Randy Dunlap wrote:
>> On Tue, 12 Aug 2008 16:46:39 +0800 Zhao, Yu wrote:
>> 
>>> [PATCH 4/4] PCI: document SR-IOV
>>> 
>>> SR-IOV Documentation.
>>> 
>>> Signed-off-by: Yu Zhao <[EMAIL PROTECTED]>
>>> Signed-off-by:  Eddie Dong <[EMAIL PROTECTED]>
>>> 
>>> ---
>>>  Documentation/ABI/testing/sysfs-bus-pci |   13 ++
>>>  Documentation/PCI/00-INDEX  |2
>>>  Documentation/PCI/pci-iov-howto.txt |  170
> +++
>>>  3 files changed, 185 insertions(+), 0 deletions(-)
>>> 
>>> diff --git a/Documentation/ABI/testing/sysfs-bus-pci
> b/Documentation/ABI/testing/sysfs-bus-pci
>>> index ceddcff..9ada27b 100644
>>> --- a/Documentation/ABI/testing/sysfs-bus-pci
>>> +++ b/Documentation/ABI/testing/sysfs-bus-pci
>>> @@ -9,3 +9,16 @@ Description:
>>> that some devices may have malformatted data.  If the
>>> underlying VPD has a writable section then the
>>> corresponding section of this file will be writable. +
>>> +What:  /sys/bus/pci/devices/.../iov
>>> +Date:  August 2008
>>> +Contact:   Yu Zhao <[EMAIL PROTECTED]>
>>> +Description:
>>> +   This file will appear when SR-IOV capability is enabled
>>> +   by the device driver if supported. It holds number of
>>> +   available Virtual Functions and Bus, Device, Function
>>> +   number and status of these Virtual Functions that belong
>>> +   to this device (Physical Function). This file can be
>> 
>> This one file contains available VFs, Bus:dev:Func number, and
>> status? Sounds like a misuse (abuse) of sysfs "one value per file"
>> mantra, but I'll read below to see how it's done.
>> 
>> [added GregKH to cc: list]
> 
> I agree, why not just display the device tree of available devices
> like all other busses do? 
> 

Thanks for the comments. 

Will separate this file to /sys/bus/pci/devices/.../iov/{NumVFs,VF1,VF2,...}. 
The NumVFs file contains number of available VFs, and each VF file contains 
"bus:dev.func=status". Sounds better?

> thanks,
> 
> greg k-h

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: SR-IOV: patches are available for Linux kernel [4/4]

2008-08-13 Thread Greg KH 
On Wed, Aug 13, 2008 at 01:09:16PM -0700, Randy Dunlap wrote:
> On Tue, 12 Aug 2008 16:46:39 +0800 Zhao, Yu wrote:
> 
> > [PATCH 4/4] PCI: document SR-IOV
> > 
> > SR-IOV Documentation.
> > 
> > Signed-off-by: Yu Zhao <[EMAIL PROTECTED]>
> > Signed-off-by:  Eddie Dong <[EMAIL PROTECTED]>
> > 
> > ---
> >  Documentation/ABI/testing/sysfs-bus-pci |   13 ++
> >  Documentation/PCI/00-INDEX  |2 
> >  Documentation/PCI/pci-iov-howto.txt |  170 
> > +++
> >  3 files changed, 185 insertions(+), 0 deletions(-)
> > 
> > diff --git a/Documentation/ABI/testing/sysfs-bus-pci 
> > b/Documentation/ABI/testing/sysfs-bus-pci
> > index ceddcff..9ada27b 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-pci
> > +++ b/Documentation/ABI/testing/sysfs-bus-pci
> > @@ -9,3 +9,16 @@ Description:
> > that some devices may have malformatted data.  If the
> > underlying VPD has a writable section then the
> > corresponding section of this file will be writable.
> > +
> > +What:  /sys/bus/pci/devices/.../iov
> > +Date:  August 2008
> > +Contact:   Yu Zhao <[EMAIL PROTECTED]>
> > +Description:
> > +   This file will appear when SR-IOV capability is enabled
> > +   by the device driver if supported. It holds number of
> > +   available Virtual Functions and Bus, Device, Function
> > +   number and status of these Virtual Functions that belong
> > +   to this device (Physical Function). This file can be
> 
> This one file contains available VFs, Bus:dev:Func number, and status?
> Sounds like a misuse (abuse) of sysfs "one value per file" mantra, but I'll
> read below to see how it's done.
> 
> [added GregKH to cc: list]

I agree, why not just display the device tree of available devices like
all other busses do?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: SR-IOV: patches are available for Linux kernel [4/4]

2008-08-13 Thread Randy Dunlap 
On Tue, 12 Aug 2008 16:46:39 +0800 Zhao, Yu wrote:

> [PATCH 4/4] PCI: document SR-IOV
> 
> SR-IOV Documentation.
> 
> Signed-off-by: Yu Zhao <[EMAIL PROTECTED]>
> Signed-off-by:  Eddie Dong <[EMAIL PROTECTED]>
> 
> ---
>  Documentation/ABI/testing/sysfs-bus-pci |   13 ++
>  Documentation/PCI/00-INDEX  |2 
>  Documentation/PCI/pci-iov-howto.txt |  170 
> +++
>  3 files changed, 185 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-pci 
> b/Documentation/ABI/testing/sysfs-bus-pci
> index ceddcff..9ada27b 100644
> --- a/Documentation/ABI/testing/sysfs-bus-pci
> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> @@ -9,3 +9,16 @@ Description:
>   that some devices may have malformatted data.  If the
>   underlying VPD has a writable section then the
>   corresponding section of this file will be writable.
> +
> +What:/sys/bus/pci/devices/.../iov
> +Date:August 2008
> +Contact: Yu Zhao <[EMAIL PROTECTED]>
> +Description:
> + This file will appear when SR-IOV capability is enabled
> + by the device driver if supported. It holds number of
> + available Virtual Functions and Bus, Device, Function
> + number and status of these Virtual Functions that belong
> + to this device (Physical Function). This file can be

This one file contains available VFs, Bus:dev:Func number, and status?
Sounds like a misuse (abuse) of sysfs "one value per file" mantra, but I'll
read below to see how it's done.

[added GregKH to cc: list]


> + written using same format as what can be read out, to
> + change the number of available Virtual Functions and to
> + enable or disable a Virtual Functions.

> diff --git a/Documentation/PCI/pci-iov-howto.txt 
> b/Documentation/PCI/pci-iov-howto.txt
> new file mode 100644
> index 000..2d7ae64
> --- /dev/null
> +++ b/Documentation/PCI/pci-iov-howto.txt
> @@ -0,0 +1,170 @@
> + PCI Express Single Root I/O Virtualization HOWTO
> + Copyright (C) 2008 Intel Corporation
> + Yu Zhao <[EMAIL PROTECTED]>
> +
> +
> +1. Overview
> +
> +1.1 What is SR-IOV
> +
> +SR-IOV is PCI Express Extended Capability, which makes one physical device

   SR-IOV is a PCI Express Extended Capability which makes one physical device

> +becomes multiple virtual devices. The physical device is referred as Physical

   become | appear as | function as multiple virtual devices.
 The physical device is referred to as the 
Physical

> +Function while the virtual devices are refereed as Virtual Functions.

  referred to as Virtual Functions.

> +Allocation of Virtual Functions can be dynamically controlled by Physical
> +Function via registers encapsulated in the capability. By default, this
> +feature is not enabled and the Physical Function behaves as traditional PCIe
> +device. Once it's turned on, each Virtual Function's PCI configuration space
> +can be accessed by its own Bus, Device and Function Number (Routing ID). And
> +each Virtual Function also has PCI Memory Space, which is used to map its
> +register set. Virtual Function device driver operates on the register set so
> +it can be functional and appear as a real existing PCI device.
> +
> +1.2 What is ARI
> +
> +Alternative Routing-ID Interpretation allows a PCI Express Endpoint to use
> +its device number field as part of function number. Traditionally, an
> +Endpoint can only have 8 functions, and the device number of all Endpoints
> +is zero. With ARI enabled, an Endpoint can have up to 256 functions. ARI is
> +managed via a ARI Forwarding bit in the Device Capabilities 2 register of

   managed via the ARI Forwarding bit

> +the PCI Express Capability on the Root Port or the Downstream Port and a new
> +ARI Capability on the Endpoint.
> +
> +
> +2. User Guide
> +
> +2.1 How can I manage SR-IOV
> +
> +SR-IOV can be managed by reading or writing /sys/bus/pci/devices/.../iov.
> +Legal operations on this file include:
> + - Read: will get number of available VFs and a list of them.
> + - Write: bb:dd.f={1|0} will enable or disable a VF.
> + - Write: NumVFs=N will change number of available VFs.
> +
> +2.2 How can I use Virtual Functions
> +
> +Virtual Functions can be treated as hot-plugged PCI devices in the kernel,
> +so they should be able to work in the same way as real PCI devices.
> +NOTE: Virtual Function device driver must be loaded to make it work.
> +
> +
> +3. Developer Guide
> +
> +3.1 SR-IOV APIs
> +
> +To enable SR-IOV, Physical Function device driver needs to call:
> + int pci_iov_enable(struct pci_dev *dev, int nvfs,
> + int (*cb)(struct pci_dev *, int, int))
> +NOTE: this function sleeps 2 seconds waiting on hardware transaction
> +co

SR-IOV: patches are available for Linux kernel [4/4]

2008-08-12 Thread Zhao, Yu 
[PATCH 4/4] PCI: document SR-IOV

SR-IOV Documentation.

Signed-off-by: Yu Zhao <[EMAIL PROTECTED]>
Signed-off-by:  Eddie Dong <[EMAIL PROTECTED]>

---
 Documentation/ABI/testing/sysfs-bus-pci |   13 ++
 Documentation/PCI/00-INDEX  |2 
 Documentation/PCI/pci-iov-howto.txt |  170 +++
 3 files changed, 185 insertions(+), 0 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-bus-pci 
b/Documentation/ABI/testing/sysfs-bus-pci
index ceddcff..9ada27b 100644
--- a/Documentation/ABI/testing/sysfs-bus-pci
+++ b/Documentation/ABI/testing/sysfs-bus-pci
@@ -9,3 +9,16 @@ Description:
that some devices may have malformatted data.  If the
underlying VPD has a writable section then the
corresponding section of this file will be writable.
+
+What:  /sys/bus/pci/devices/.../iov
+Date:  August 2008
+Contact:   Yu Zhao <[EMAIL PROTECTED]>
+Description:
+   This file will appear when SR-IOV capability is enabled
+   by the device driver if supported. It holds number of
+   available Virtual Functions and Bus, Device, Function
+   number and status of these Virtual Functions that belong
+   to this device (Physical Function). This file can be
+   written using same format as what can be read out, to
+   change the number of available Virtual Functions and to
+   enable or disable a Virtual Functions.
diff --git a/Documentation/PCI/00-INDEX b/Documentation/PCI/00-INDEX
index 49f4394..8f8ee17 100644
--- a/Documentation/PCI/00-INDEX
+++ b/Documentation/PCI/00-INDEX
@@ -10,3 +10,5 @@ pci.txt
- info on the PCI subsystem for device driver authors
 pcieaer-howto.txt
- the PCI Express Advanced Error Reporting Driver Guide HOWTO
+pci-iov-howto.txt
+   - PCI Express Single Root I/O Virtualization HOWTO
diff --git a/Documentation/PCI/pci-iov-howto.txt 
b/Documentation/PCI/pci-iov-howto.txt
new file mode 100644
index 000..2d7ae64
--- /dev/null
+++ b/Documentation/PCI/pci-iov-howto.txt
@@ -0,0 +1,170 @@
+   PCI Express Single Root I/O Virtualization HOWTO
+   Copyright (C) 2008 Intel Corporation
+   Yu Zhao <[EMAIL PROTECTED]>
+
+
+1. Overview
+
+1.1 What is SR-IOV
+
+SR-IOV is PCI Express Extended Capability, which makes one physical device
+becomes multiple virtual devices. The physical device is referred as Physical
+Function while the virtual devices are refereed as Virtual Functions.
+Allocation of Virtual Functions can be dynamically controlled by Physical
+Function via registers encapsulated in the capability. By default, this
+feature is not enabled and the Physical Function behaves as traditional PCIe
+device. Once it's turned on, each Virtual Function's PCI configuration space
+can be accessed by its own Bus, Device and Function Number (Routing ID). And
+each Virtual Function also has PCI Memory Space, which is used to map its
+register set. Virtual Function device driver operates on the register set so
+it can be functional and appear as a real existing PCI device.
+
+1.2 What is ARI
+
+Alternative Routing-ID Interpretation allows a PCI Express Endpoint to use
+its device number field as part of function number. Traditionally, an
+Endpoint can only have 8 functions, and the device number of all Endpoints
+is zero. With ARI enabled, an Endpoint can have up to 256 functions. ARI is
+managed via a ARI Forwarding bit in the Device Capabilities 2 register of
+the PCI Express Capability on the Root Port or the Downstream Port and a new
+ARI Capability on the Endpoint.
+
+
+2. User Guide
+
+2.1 How can I manage SR-IOV
+
+SR-IOV can be managed by reading or writing /sys/bus/pci/devices/.../iov.
+Legal operations on this file include:
+   - Read: will get number of available VFs and a list of them.
+   - Write: bb:dd.f={1|0} will enable or disable a VF.
+   - Write: NumVFs=N will change number of available VFs.
+
+2.2 How can I use Virtual Functions
+
+Virtual Functions can be treated as hot-plugged PCI devices in the kernel,
+so they should be able to work in the same way as real PCI devices.
+NOTE: Virtual Function device driver must be loaded to make it work.
+
+
+3. Developer Guide
+
+3.1 SR-IOV APIs
+
+To enable SR-IOV, Physical Function device driver needs to call:
+   int pci_iov_enable(struct pci_dev *dev, int nvfs,
+   int (*cb)(struct pci_dev *, int, int))
+NOTE: this function sleeps 2 seconds waiting on hardware transaction
+completion according to SR-IOV specification.
+
+To disable SR-IOV, Physical Function device driver needs to call:
+   void pci_iov_disable(struct pci_dev *dev)
+NOTE: this function sleeps 1 second waiting on hardware transaction
+completion according to SR-IOV specification.
+
+Following function can be used to query maximum number of Virtual Functions
+that a Physi