Re: inconsistent use of $TMP vs. $TMPDIR

2010-09-26 Thread Avi Kivity

 On 09/24/2010 11:06 PM, Eric Blake wrote:
I noticed today that various kvm source files are inconsistent on the 
use of $TMP vs. $TMPDIR:


$ git grep -l '\$TMP\b' | cat
scripts/Kbuild.include
tools/perf/feature-tests.mak
$ git grep -l '\$TMPDIR\b' | cat
Documentation/lguest/extract

According to POSIX, you should probably be using $TMPDIR instead of 
$TMP when referring to the preferred temporary directory location.


http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03 





These are not kvm specific issues.  Please use MAINTAINERS to report to 
the maintainer of the affected subsystems (lguest, kbuild).


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


inconsistent use of $TMP vs. $TMPDIR

2010-09-24 Thread Eric Blake
I noticed today that various kvm source files are inconsistent on the 
use of $TMP vs. $TMPDIR:


$ git grep -l '\$TMP\b' | cat
scripts/Kbuild.include
tools/perf/feature-tests.mak
$ git grep -l '\$TMPDIR\b' | cat
Documentation/lguest/extract

According to POSIX, you should probably be using $TMPDIR instead of $TMP 
when referring to the preferred temporary directory location.


http://www.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap08.html#tag_08_03 



--
Eric Blake   ebl...@redhat.com+1-801-349-2682
Libvirt virtualization library http://libvirt.org
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html