preempt.c not in hack-files

2008-11-06 Thread Alexander Graf

Hi,

is there any particular reason x86/preempt.c is not in the hack-files?  
When I accidently tried to compile KVM on a kernel that does not have  
PREEMPT_NOTIFIERS, I got an error claiming that on_each_cpu is wrong.


So basically we should use kvm_on_each_cpu here, right? This  
transition is done in the hack awk script, but preempt.c does not seem  
like it's included there.


Alex
--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: preempt.c not in hack-files

2008-11-06 Thread Avi Kivity

Alexander Graf wrote:

Hi,

is there any particular reason x86/preempt.c is not in the hack-files? 


Mainly because it doesn't come from kvm.git.

When I accidently tried to compile KVM on a kernel that does not have 
PREEMPT_NOTIFIERS, I got an error claiming that on_each_cpu is wrong.


So basically we should use kvm_on_each_cpu here, right?


Yes, that's probably the best thing to do.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line unsubscribe kvm in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html