Re: [kvm-devel] [PATCH] - drivers/kvm/* - remove ptr comparisons to 0

[Avi Kivity]

Joe Perches wrote:
 fix sparse warnings Using plain integer as NULL pointer

   

Applied, thanks.

-- 
error compiling committee.c: too many arguments to function


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

[kvm-devel] [PATCH] - drivers/kvm/* - remove ptr comparisons to 0

[Joe Perches]

fix sparse warnings Using plain integer as NULL pointer

Signed-off-by: Joe Perches [EMAIL PROTECTED]

---

 drivers/kvm/kvm.h  |2 +-
 drivers/kvm/kvm_main.c |3 ++-
 drivers/kvm/lapic.c|2 +-
 drivers/kvm/svm.c  |2 +-
 4 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
index 3b0bc4b..f572a81 100644
--- a/drivers/kvm/kvm.h
+++ b/drivers/kvm/kvm.h
@@ -433,7 +433,7 @@ static inline struct kvm_ioapic *ioapic_irqchip(struct kvm 
*kvm)
 
 static inline int irqchip_in_kernel(struct kvm *kvm)
 {
-   return pic_irqchip(kvm) != 0;
+   return pic_irqchip(kvm) != NULL;
 }
 
 struct descriptor_table {
diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
index 07ae280..e06beaf 100644
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -3535,7 +3535,8 @@ int kvm_init_x86(struct kvm_x86_ops *ops, unsigned int 
vcpu_size,
 
/* A kmem cache lets us meet the alignment requirements of fx_save. */
kvm_vcpu_cache = kmem_cache_create(kvm_vcpu, vcpu_size,
-  __alignof__(struct kvm_vcpu), 0, 0);
+  __alignof__(struct kvm_vcpu),
+  0, NULL);
if (!kvm_vcpu_cache) {
r = -ENOMEM;
goto out_free_4;
diff --git a/drivers/kvm/lapic.c b/drivers/kvm/lapic.c
index 238fcad..274b07e 100644
--- a/drivers/kvm/lapic.c
+++ b/drivers/kvm/lapic.c
@@ -771,7 +771,7 @@ void kvm_free_apic(struct kvm_lapic *apic)
 
if (apic-regs_page) {
__free_page(apic-regs_page);
-   apic-regs_page = 0;
+   apic-regs_page = NULL;
}
 
kfree(apic);
diff --git a/drivers/kvm/svm.c b/drivers/kvm/svm.c
index 729f1cd..6c7c797 100644
--- a/drivers/kvm/svm.c
+++ b/drivers/kvm/svm.c
@@ -1282,7 +1282,7 @@ static int handle_exit(struct kvm_run *kvm_run, struct 
kvm_vcpu *vcpu)
   exit_code);
 
if (exit_code = ARRAY_SIZE(svm_exit_handlers)
-   || svm_exit_handlers[exit_code] == 0) {
+   || !svm_exit_handlers[exit_code]) {
kvm_run-exit_reason = KVM_EXIT_UNKNOWN;
kvm_run-hw.hardware_exit_reason = exit_code;
return 0;



-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now  http://get.splunk.com/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel