[kvm-devel] [PATCH] Add -Werror to libkvm compile

2008-03-24 Thread Jerone Young
# HG changeset patch
# User Jerone Young [EMAIL PROTECTED]
# Date 1206384205 18000
# Branch merge
# Node ID e23a26d1da04a6dbb831da7d03922abf95de7b30
# Parent  972f62b6acae693c388d7b05d3a9ba7ef26ab4a0
Add -Werror to libkvm compile

This patch adds -Werror to CFLAGS for compilation of libkvm. This should stop 
complaints about Warnings.

Often I miss these warnings as they scroll right by with everything else during 
a big compile. This will help catch them.

For qemu this using -Werror is not possible as a lot of qemu throw a gcc 
warning of some sort.

Signed-off-by: Jerone Young [EMAIL PROTECTED]

diff --git a/libkvm/Makefile b/libkvm/Makefile
--- a/libkvm/Makefile
+++ b/libkvm/Makefile
@@ -11,6 +11,7 @@ CFLAGS += $(call cc-option, -fno-stack-p
 CFLAGS += $(call cc-option, -fno-stack-protector, )
 CFLAGS += $(call cc-option, -fno-stack-protector-all, )
 CFLAGS += -I $(KERNELDIR)/include
+CFLAGS += -Werror
 
 LDFLAGS += $(CFLAGS)
 

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [PATCH] Add -Werror to libkvm compile

2008-03-24 Thread Anthony Liguori
Jerone Young wrote:
 # HG changeset patch
 # User Jerone Young [EMAIL PROTECTED]
 # Date 1206384205 18000
 # Branch merge
 # Node ID e23a26d1da04a6dbb831da7d03922abf95de7b30
 # Parent  972f62b6acae693c388d7b05d3a9ba7ef26ab4a0
 Add -Werror to libkvm compile

 This patch adds -Werror to CFLAGS for compilation of libkvm. This should stop 
 complaints about Warnings.
   

What's unfortunate about -Werror is that GCC is notorious about 
introducing warnings that aren't valid for particular versions of GCC.  
While libkvm may compile with -Werror for you and may, there may be 
existing (or future) versions of GCC that it won't build with whereas 
the error being reported is not valid.

This is okay for developers, but not for users.  In general, most 
projects reserve -Werror for a developer or maintainer mode.

Regards,

Anthony Liguori

 Often I miss these warnings as they scroll right by with everything else 
 during a big compile. This will help catch them.

 For qemu this using -Werror is not possible as a lot of qemu throw a gcc 
 warning of some sort.

 Signed-off-by: Jerone Young [EMAIL PROTECTED]

 diff --git a/libkvm/Makefile b/libkvm/Makefile
 --- a/libkvm/Makefile
 +++ b/libkvm/Makefile
 @@ -11,6 +11,7 @@ CFLAGS += $(call cc-option, -fno-stack-p
  CFLAGS += $(call cc-option, -fno-stack-protector, )
  CFLAGS += $(call cc-option, -fno-stack-protector-all, )
  CFLAGS += -I $(KERNELDIR)/include
 +CFLAGS += -Werror
  
  LDFLAGS += $(CFLAGS)
  

 -
 This SF.net email is sponsored by: Microsoft
 Defy all challenges. Microsoft(R) Visual Studio 2008.
 http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
 ___
 kvm-devel mailing list
 kvm-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/kvm-devel
   


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel