Re: [kvm-devel] [PATCH] Remove unnecessary linux/kvm.h include (v2)

2008-01-30 Thread Avi Kivity
Anthony Liguori wrote:
 This removes an unnecessary include of linux/kvm.h which happens to silence
 a warning introduced by my previous patch :-)  We have to move the ABI check
 too until we've included libkvm.h.

   

Doesn't apply, please check.

-- 
error compiling committee.c: too many arguments to function


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


[kvm-devel] [PATCH] Remove unnecessary linux/kvm.h include

2008-01-29 Thread Anthony Liguori
This removes an unnecessary include of linux/kvm.h which happens to silence
a warning introduced by my previous patch :-)

Signed-off-by: Anthony Liguori [EMAIL PROTECTED]

diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
index d798841..048054b 100644
--- a/libkvm/libkvm.c
+++ b/libkvm/libkvm.c
@@ -18,12 +18,6 @@
 #define __user /* temporary, until installed via make headers_install */
 #endif
 
-#if defined(__i386__) || defined(__x86_64__)
-#define CONFIG_X86
-#endif
-
-#include linux/kvm.h
-
 #define EXPECTED_KVM_API_VERSION 12
 
 #if EXPECTED_KVM_API_VERSION != KVM_API_VERSION

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] [PATCH] Remove unnecessary linux/kvm.h include

2008-01-29 Thread Anthony Liguori
This patch sucks.  Let me finish up playing around with this stuff and 
I'll send out a better one.

Regards,

Anthony Liguori

Anthony Liguori wrote:
 This removes an unnecessary include of linux/kvm.h which happens to silence
 a warning introduced by my previous patch :-)

 Signed-off-by: Anthony Liguori [EMAIL PROTECTED]

 diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
 index d798841..048054b 100644
 --- a/libkvm/libkvm.c
 +++ b/libkvm/libkvm.c
 @@ -18,12 +18,6 @@
  #define __user /* temporary, until installed via make headers_install */
  #endif

 -#if defined(__i386__) || defined(__x86_64__)
 -#define CONFIG_X86
 -#endif
 -
 -#include linux/kvm.h
 -
  #define EXPECTED_KVM_API_VERSION 12

  #if EXPECTED_KVM_API_VERSION != KVM_API_VERSION
   


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


[kvm-devel] [PATCH] Remove unnecessary linux/kvm.h include (v2)

2008-01-29 Thread Anthony Liguori
This removes an unnecessary include of linux/kvm.h which happens to silence
a warning introduced by my previous patch :-)  We have to move the ABI check
too until we've included libkvm.h.

Signed-off-by: Anthony Liguori [EMAIL PROTECTED]

diff --git a/libkvm/libkvm.c b/libkvm/libkvm.c
index d798841..28df774 100644
--- a/libkvm/libkvm.c
+++ b/libkvm/libkvm.c
@@ -18,18 +18,6 @@
 #define __user /* temporary, until installed via make headers_install */
 #endif
 
-#if defined(__i386__) || defined(__x86_64__)
-#define CONFIG_X86
-#endif
-
-#include linux/kvm.h
-
-#define EXPECTED_KVM_API_VERSION 12
-
-#if EXPECTED_KVM_API_VERSION != KVM_API_VERSION
-#error libkvm: userspace and kernel version mismatch
-#endif
-
 #include unistd.h
 #include fcntl.h
 #include stdio.h
@@ -40,6 +28,12 @@
 #include sys/ioctl.h
 #include libkvm.h
 
+#define EXPECTED_KVM_API_VERSION 12
+
+#if EXPECTED_KVM_API_VERSION != KVM_API_VERSION
+#error libkvm: userspace and kernel version mismatch
+#endif
+
 #if defined(__x86_64__) || defined(__i386__)
 #include kvm-x86.h
 #endif

-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel