Re: [kvm-devel] [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
On Mon, 10 Mar 2008 14:11:04 +0100 Christian Borntraeger [EMAIL PROTECTED] wrote: [PATCH v2] kvm: provide kvm.h for all architecture: fixes headers_install Currently include/linux/kvm.h is not considered by make headers_install, because Kbuild cannot handle unifdef-$(CONFIG_FOO) += foo.h. This problem was introduced by 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e, which makes this an 2.6.25 regression. One way of solving the issue is to enhance Kbuild, but Avi Kivity and David Woodhouse conviced me, that changing headers_install is not the way to go. This patch changes the definition for linux/kvm.h to unifdef-y. If unifdef-y is used for linux/kvm.h make headers_check will fail on all architectures without asm/kvm.h. Therefore, this patch also provides asm/kvm.h on all architectures. Changes since v1: o use asm-generic/Kbuild.asm (Arnd Bergmann) o fix comment in asm-frv (David Howells) err, this doesn't work. alpha and m68k (at least) fail make headers_check /usr/src/devel/usr/include/linux/kvm.h requires asm/kvm.h, which does not exist in exported headers - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
On Mon, 2008-03-10 at 23:20 -0700, Andrew Morton wrote: Changes since v1: o use asm-generic/Kbuild.asm (Arnd Bergmann) I don't see that in the diffstat of the patch you dropped (looking at the immediately subsequent mail in my inbox). Which might explain... /usr/src/devel/usr/include/linux/kvm.h requires asm/kvm.h, which does not exist in exported headers -- dwmw2 - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
Am Dienstag, 11. März 2008 schrieb David Woodhouse: On Mon, 2008-03-10 at 23:20 -0700, Andrew Morton wrote: Changes since v1: o use asm-generic/Kbuild.asm (Arnd Bergmann) I don't see that in the diffstat of the patch you dropped (looking at the immediately subsequent mail in my inbox). Which might explain... I cross tested my patch on all architectures and, yes, that part did not make it into mm. Maybe it was caused by my last patch being word wrapped. Here is a resend: [PATCH v2] kvm: provide kvm.h for all architecture: fixes headers_install Currently include/linux/kvm.h is not considered by make headers_install, because Kbuild cannot handle unifdef-$(CONFIG_FOO) += foo.h. This problem was introduced by 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e, which makes this an 2.6.25 regression. One way of solving the issue is to enhance Kbuild, but Avi and David conviced me, that changing headers_install is not the way to go. This patch changes the definition for linux/kvm.h to unifdef-y. If unifdef-y is used for linux/kvm.h make headers_check will fail on all architectures without asm/kvm.h. Therefore, this patch also provides asm/kvm.h on all architectures. Changes since v1: o use asm-generic/Kbuild.asm (Arnd Bergmann) o fix comment in asm-frv (David Howells) Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] Acked-by: Avi Kivity [EMAIL PROTECTED] CCed: Sam Ravnborg [EMAIL PROTECTED] CCed: David Woodhouse [EMAIL PROTECTED] --- include/asm-alpha/kvm.h|6 ++ include/asm-arm/kvm.h |6 ++ include/asm-avr32/kvm.h|6 ++ include/asm-blackfin/kvm.h |6 ++ include/asm-cris/kvm.h |6 ++ include/asm-frv/kvm.h |6 ++ include/asm-generic/Kbuild.asm |2 ++ include/asm-h8300/kvm.h|6 ++ include/asm-ia64/kvm.h |6 ++ include/asm-m32r/kvm.h |6 ++ include/asm-m68k/kvm.h |6 ++ include/asm-m68knommu/kvm.h|6 ++ include/asm-mips/kvm.h |6 ++ include/asm-mn10300/kvm.h |6 ++ include/asm-parisc/kvm.h |6 ++ include/asm-powerpc/kvm.h |6 ++ include/asm-s390/kvm.h |6 ++ include/asm-sh/kvm.h |6 ++ include/asm-sparc/kvm.h|6 ++ include/asm-sparc64/kvm.h |6 ++ include/asm-um/kvm.h |6 ++ include/asm-v850/kvm.h |6 ++ include/asm-xtensa/kvm.h |6 ++ include/linux/Kbuild |2 +- 24 files changed, 135 insertions(+), 1 deletion(-) Index: linux-2.6.git/include/asm-alpha/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-alpha/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_ALPHA_H +#define __LINUX_KVM_ALPHA_H + +/* alpha does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-arm/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-arm/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_ARM_H +#define __LINUX_KVM_ARM_H + +/* arm does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-avr32/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-avr32/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_AVR32_H +#define __LINUX_KVM_AVR32_H + +/* avr32 does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-blackfin/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-blackfin/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_BLACKFIN_H +#define __LINUX_KVM_BLACKFIN_H + +/* blackfin does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-cris/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-cris/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_CRIS_H +#define __LINUX_KVM_CRIS_H + +/* cris does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-frv/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-frv/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_FRV_H +#define __LINUX_KVM_FRV_H + +/* frv does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-generic/Kbuild.asm === --- linux-2.6.git.orig/include/asm-generic/Kbuild.asm +++ linux-2.6.git/include/asm-generic/Kbuild.asm @@ -1,3 +1,5 @@ +header-y += kvm.h + ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h) unifdef-y += a.out.h endif Index: linux-2.6.git/include/asm-h8300/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-h8300/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_H8300_H +#define __LINUX_KVM_H8300_H + +/* h8300 does not support
Re: [kvm-devel] [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
Christian Borntraeger [EMAIL PROTECTED] writes: include/asm-alpha/kvm.h|6 ++ Can't you put it in asm-generic? Andreas. -- Andreas Schwab, SuSE Labs, [EMAIL PROTECTED] SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany PGP key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 And now for something completely different. - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
Re: [kvm-devel] [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
Am Dienstag, 11. März 2008 schrieb Andreas Schwab: Christian Borntraeger [EMAIL PROTECTED] writes: include/asm-alpha/kvm.h|6 ++ Can't you put it in asm-generic? I dont think so. The generic part is in include/linux/kvm.h. asm/kvm.h is populated by each architecture which gets kvm support with arch specfic definitions. x86 has support and s390, powerpc and ia64 are currently know to work on ports. Christian - This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/ ___ kvm-devel mailing list kvm-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/kvm-devel
[kvm-devel] [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
Andrew, Avi is away, can you apply this patch for 2.6.25? [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install Currently include/linux/kvm.h is not considered by make headers_install, because Kbuild cannot handle unifdef-$(CONFIG_FOO) += foo.h. This problem was introduced by 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e, which makes this an 2.6.25 regression. One way of solving the issue is to enhance Kbuild, but Avi and David conviced me, that changing headers_install is not the way to go. This patch changes the definition for linux/kvm.h to unifdef-y. If unifdef-y is used for linux/kvm.h make headers_check will fail on all architectures without asm/kvm.h. Therefore, this patch also provides asm/kvm.h on all architectures. Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] Acked-by: Avi Kivity [EMAIL PROTECTED] CCed: Sam Ravnborg [EMAIL PROTECTED] CCed: David Woodhouse [EMAIL PROTECTED] --- include/asm-alpha/Kbuild |1 + include/asm-alpha/kvm.h |6 ++ include/asm-arm/Kbuild |2 ++ include/asm-arm/kvm.h|6 ++ include/asm-avr32/Kbuild |1 + include/asm-avr32/kvm.h |6 ++ include/asm-blackfin/Kbuild |1 + include/asm-blackfin/kvm.h |6 ++ include/asm-cris/Kbuild |1 + include/asm-cris/kvm.h |6 ++ include/asm-frv/Kbuild |1 + include/asm-frv/kvm.h|6 ++ include/asm-h8300/Kbuild |2 ++ include/asm-h8300/kvm.h |6 ++ include/asm-ia64/Kbuild |1 + include/asm-ia64/kvm.h |6 ++ include/asm-m32r/Kbuild |2 ++ include/asm-m32r/kvm.h |6 ++ include/asm-m68k/Kbuild |1 + include/asm-m68k/kvm.h |6 ++ include/asm-m68knommu/Kbuild |2 ++ include/asm-m68knommu/kvm.h |7 +++ include/asm-mips/Kbuild |2 +- include/asm-mips/kvm.h |6 ++ include/asm-mn10300/Kbuild |2 ++ include/asm-mn10300/kvm.h|6 ++ include/asm-parisc/Kbuild|2 ++ include/asm-parisc/kvm.h |6 ++ include/asm-powerpc/Kbuild |1 + include/asm-powerpc/kvm.h|6 ++ include/asm-s390/Kbuild |1 + include/asm-s390/kvm.h |6 ++ include/asm-sh/Kbuild|1 + include/asm-sh/kvm.h |6 ++ include/asm-sparc/Kbuild |1 + include/asm-sparc/kvm.h |6 ++ include/asm-sparc64/Kbuild |1 + include/asm-sparc64/kvm.h|6 ++ include/asm-v850/Kbuild |2 ++ include/asm-v850/kvm.h |6 ++ include/asm-xtensa/Kbuild|2 ++ include/asm-xtensa/kvm.h |6 ++ include/linux/Kbuild |2 +- 43 files changed, 157 insertions(+), 2 deletions(-) Index: linux-2.6/include/asm-alpha/Kbuild === --- linux-2.6.orig/include/asm-alpha/Kbuild +++ linux-2.6/include/asm-alpha/Kbuild @@ -1,6 +1,7 @@ include include/asm-generic/Kbuild.asm header-y += gentrap.h +header-y += kvm.h header-y += regdef.h header-y += pal.h header-y += reg.h Index: linux-2.6/include/asm-alpha/kvm.h === --- /dev/null +++ linux-2.6/include/asm-alpha/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_ALPHA_H +#define __LINUX_KVM_ALPHA_H + +/* alpha does not support KVM */ + +#endif Index: linux-2.6/include/asm-arm/Kbuild === --- linux-2.6.orig/include/asm-arm/Kbuild +++ linux-2.6/include/asm-arm/Kbuild @@ -1,3 +1,5 @@ include include/asm-generic/Kbuild.asm +header-y += kvm.h + unifdef-y += hwcap.h Index: linux-2.6/include/asm-arm/kvm.h === --- /dev/null +++ linux-2.6/include/asm-arm/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_ARM_H +#define __LINUX_KVM_ARM_H + +/* arm does not support KVM */ + +#endif Index: linux-2.6/include/asm-avr32/Kbuild === --- linux-2.6.orig/include/asm-avr32/Kbuild +++ linux-2.6/include/asm-avr32/Kbuild @@ -1,3 +1,4 @@ include include/asm-generic/Kbuild.asm header-y += cachectl.h +header-y += kvm.h Index: linux-2.6/include/asm-avr32/kvm.h === --- /dev/null +++ linux-2.6/include/asm-avr32/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_AVR32_H +#define __LINUX_KVM_AVR32_H + +/* avr32 does not support KVM */ + +#endif Index: linux-2.6/include/asm-blackfin/Kbuild === --- linux-2.6.orig/include/asm-blackfin/Kbuild +++ linux-2.6/include/asm-blackfin/Kbuild @@ -1,3 +1,4 @@ include include/asm-generic/Kbuild.asm header-y += fixed_code.h +header-y += kvm.h Index: linux-2.6/include/asm-blackfin/kvm.h === --- /dev/null
[kvm-devel] [PATCH] kvm: provide kvm.h for all architecture: fixes headers_install
Ok, here goes the second version. Andrew, if there are no further complaints, please replace the old patch, with this version. Thank you. - [PATCH v2] kvm: provide kvm.h for all architecture: fixes headers_install Currently include/linux/kvm.h is not considered by make headers_install, because Kbuild cannot handle unifdef-$(CONFIG_FOO) += foo.h. This problem was introduced by 040922c04cf2c8ac70be2e88a8a9614ecdb41d2e, which makes this an 2.6.25 regression. One way of solving the issue is to enhance Kbuild, but Avi Kivity and David Woodhouse conviced me, that changing headers_install is not the way to go. This patch changes the definition for linux/kvm.h to unifdef-y. If unifdef-y is used for linux/kvm.h make headers_check will fail on all architectures without asm/kvm.h. Therefore, this patch also provides asm/kvm.h on all architectures. Changes since v1: o use asm-generic/Kbuild.asm (Arnd Bergmann) o fix comment in asm-frv (David Howells) Signed-off-by: Christian Borntraeger [EMAIL PROTECTED] Acked-by: Avi Kivity [EMAIL PROTECTED] --- include/asm-alpha/kvm.h|6 ++ include/asm-arm/kvm.h |6 ++ include/asm-avr32/kvm.h|6 ++ include/asm-blackfin/kvm.h |6 ++ include/asm-cris/kvm.h |6 ++ include/asm-frv/kvm.h |6 ++ include/asm-generic/Kbuild.asm |2 ++ include/asm-h8300/kvm.h|6 ++ include/asm-ia64/kvm.h |6 ++ include/asm-m32r/kvm.h |6 ++ include/asm-m68k/kvm.h |6 ++ include/asm-m68knommu/kvm.h|6 ++ include/asm-mips/kvm.h |6 ++ include/asm-mn10300/kvm.h |6 ++ include/asm-parisc/kvm.h |6 ++ include/asm-powerpc/kvm.h |6 ++ include/asm-s390/kvm.h |6 ++ include/asm-sh/kvm.h |6 ++ include/asm-sparc/kvm.h|6 ++ include/asm-sparc64/kvm.h |6 ++ include/asm-um/kvm.h |6 ++ include/asm-v850/kvm.h |6 ++ include/asm-xtensa/kvm.h |6 ++ include/linux/Kbuild |2 +- 24 files changed, 135 insertions(+), 1 deletion(-) Index: linux-2.6.git/include/asm-alpha/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-alpha/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_ALPHA_H +#define __LINUX_KVM_ALPHA_H + +/* alpha does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-arm/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-arm/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_ARM_H +#define __LINUX_KVM_ARM_H + +/* arm does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-avr32/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-avr32/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_AVR32_H +#define __LINUX_KVM_AVR32_H + +/* avr32 does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-blackfin/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-blackfin/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_BLACKFIN_H +#define __LINUX_KVM_BLACKFIN_H + +/* blackfin does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-cris/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-cris/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_CRIS_H +#define __LINUX_KVM_CRIS_H + +/* cris does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-frv/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-frv/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_FRV_H +#define __LINUX_KVM_FRV_H + +/* frv does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-generic/Kbuild.asm === --- linux-2.6.git.orig/include/asm-generic/Kbuild.asm +++ linux-2.6.git/include/asm-generic/Kbuild.asm @@ -1,3 +1,5 @@ +header-y += kvm.h + ifeq ($(wildcard include/asm-$(SRCARCH)/a.out.h),include/asm-$(SRCARCH)/a.out.h) unifdef-y += a.out.h endif Index: linux-2.6.git/include/asm-h8300/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-h8300/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_H8300_H +#define __LINUX_KVM_H8300_H + +/* h8300 does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-ia64/kvm.h === --- /dev/null +++ linux-2.6.git/include/asm-ia64/kvm.h @@ -0,0 +1,6 @@ +#ifndef __LINUX_KVM_IA64_H +#define __LINUX_KVM_IA64_H + +/* ia64 does not support KVM */ + +#endif Index: linux-2.6.git/include/asm-m32r/kvm.h ===
