[kvm-devel] [PATCH 3/8] SVM: add module parameter to disable Nested Paging

2008-02-07 Thread Joerg Roedel 
To disable the use of the Nested Paging feature even if it is available in
hardware this patch adds a module parameter. Nested Paging can be disabled by
passing npt=0 to the kvm_amd module.

Signed-off-by: Joerg Roedel [EMAIL PROTECTED]
---
 arch/x86/kvm/svm.c |8 
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index b037b27..8173ba6 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -48,6 +48,9 @@ MODULE_LICENSE(GPL);
 #define SVM_DEATURE_SVML (1  2)
 
 static bool npt_enabled = false;
+static int npt = 1;
+
+module_param(npt, int, S_IRUGO);
 
 static void kvm_reput_irq(struct vcpu_svm *svm);
 
@@ -415,6 +418,11 @@ static __init int svm_hardware_setup(void)
if (!svm_has(SVM_FEATURE_NPT))
npt_enabled = false;
 
+   if (npt_enabled  !npt) {
+   printk(KERN_INFO kvm: Nested Paging disabled\n);
+   npt_enabled = false;
+   }
+
if (npt_enabled)
printk(KERN_INFO kvm: Nested Paging enabled\n);
 
-- 
1.5.3.7




-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable Nested Paging

2008-01-26 Thread Avi Kivity 
Joerg Roedel wrote:
 +static char *npt = on;
 +
 +module_param(npt, charp, S_IRUGO);
  
   
 This would probably be better as an integer.  Then we don't have to do nasty 
 things like 
 implicitly cast a literal to a char *.
 

 Hmm, I used int for that first but typing npt=off seemed more
 userfriendly to me than npt=0. So I used char* for it.
   

I expect this to be rarely used by users, so the simpler int is 
preferable (and also consistent with vmx's bypass_guest_pf and enable_vpid).

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

[kvm-devel] [PATCH 3/8] SVM: add module parameter to disable Nested Paging

2008-01-25 Thread Joerg Roedel 
To disable the use of the Nested Paging feature even if it is available in
hardware this patch adds a module parameter. Nested Paging can be disabled by
passing npt=off to the kvm_amd module.

Signed-off-by: Joerg Roedel [EMAIL PROTECTED]
---
 arch/x86/kvm/svm.c |8 
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 49bb57a..2e718ff 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -48,6 +48,9 @@ MODULE_LICENSE(GPL);
 #define SVM_DEATURE_SVML (1  2)
 
 static bool npt_enabled = false;
+static char *npt = on;
+
+module_param(npt, charp, S_IRUGO);
 
 static void kvm_reput_irq(struct vcpu_svm *svm);
 
@@ -415,6 +418,11 @@ static __init int svm_hardware_setup(void)
if (!svm_has(SVM_FEATURE_NPT))
npt_enabled = false;
 
+   if (npt_enabled  strncmp(npt, off, 3) == 0) {
+   printk(KERN_INFO kvm: Nested Paging disabled\n);
+   npt_enabled = false;
+   }
+
if (npt_enabled)
printk(KERN_INFO kvm: Nested Paging enabled\n);
 
-- 
1.5.3.7




-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable Nested Paging

2008-01-25 Thread Anthony Liguori 
Joerg Roedel wrote:
 To disable the use of the Nested Paging feature even if it is available in
 hardware this patch adds a module parameter. Nested Paging can be disabled by
 passing npt=off to the kvm_amd module.

 Signed-off-by: Joerg Roedel [EMAIL PROTECTED]
 ---
  arch/x86/kvm/svm.c |8 
  1 files changed, 8 insertions(+), 0 deletions(-)

 diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
 index 49bb57a..2e718ff 100644
 --- a/arch/x86/kvm/svm.c
 +++ b/arch/x86/kvm/svm.c
 @@ -48,6 +48,9 @@ MODULE_LICENSE(GPL);
  #define SVM_DEATURE_SVML (1  2)
  
  static bool npt_enabled = false;
 +static char *npt = on;
 +
 +module_param(npt, charp, S_IRUGO);
   

This would probably be better as an integer.  Then we don't have to do 
nasty things like implicitly cast a literal to a char *.

Regards,

Anthony Liguori

  static void kvm_reput_irq(struct vcpu_svm *svm);
  
 @@ -415,6 +418,11 @@ static __init int svm_hardware_setup(void)
   if (!svm_has(SVM_FEATURE_NPT))
   npt_enabled = false;
  
 + if (npt_enabled  strncmp(npt, off, 3) == 0) {
 + printk(KERN_INFO kvm: Nested Paging disabled\n);
 + npt_enabled = false;
 + }
 +
   if (npt_enabled)
   printk(KERN_INFO kvm: Nested Paging enabled\n);
  
   


-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [kvm-devel] [PATCH 3/8] SVM: add module parameter to disable Nested Paging

2008-01-25 Thread Joerg Roedel 
On Fri, Jan 25, 2008 at 03:35:23PM -0600, Anthony Liguori wrote:
 Joerg Roedel wrote:
 To disable the use of the Nested Paging feature even if it is available in
 hardware this patch adds a module parameter. Nested Paging can be disabled by
 passing npt=off to the kvm_amd module.
 
 Signed-off-by: Joerg Roedel [EMAIL PROTECTED]
 ---
  arch/x86/kvm/svm.c |8 
  1 files changed, 8 insertions(+), 0 deletions(-)
 
 diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
 index 49bb57a..2e718ff 100644
 --- a/arch/x86/kvm/svm.c
 +++ b/arch/x86/kvm/svm.c
 @@ -48,6 +48,9 @@ MODULE_LICENSE(GPL);
  #define SVM_DEATURE_SVML (1  2)
   static bool npt_enabled = false;
 +static char *npt = on;
 +
 +module_param(npt, charp, S_IRUGO);
   
 
 This would probably be better as an integer.  Then we don't have to do nasty 
 things like 
 implicitly cast a literal to a char *.

Hmm, I used int for that first but typing npt=off seemed more
userfriendly to me than npt=0. So I used char* for it.

Joerg

-- 
   |   AMD Saxony Limited Liability Company  Co. KG
 Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System|  Register Court Dresden: HRA 4896
 Research  |  General Partner authorized to represent:
 Center| AMD Saxony LLC (Wilmington, Delaware, US)
   | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy



-
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse012070mrt/direct/01/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel