Re: [kvm-devel] vga color

2007-10-08 Thread Avi Kivity
Zhao, Yunfeng wrote:
> Against latest commits I found that the colors on the windows guest
> become weird.
> For example, blue color has changed to red.
> Is there any change on vga of qemu?
>
>   

Yes, I merged qemu-cvs and got some surprises.

This doesn't appear on all machines.  Can you post the output of 
'xdpyinfo' on the affected machine?

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] vga color

2007-10-08 Thread Zhao, Yunfeng
All our machines for KVM testing have the problem.
I attached the output of "xdpyinfo" on one of them.

Thanks
Yunfeng

>-Original Message-
>From: Avi Kivity [mailto:[EMAIL PROTECTED]
>Sent: 2007年10月8日 16:15
>To: Zhao, Yunfeng
>Cc: kvm-devel@lists.sourceforge.net
>Subject: Re: [kvm-devel] vga color
>
>Zhao, Yunfeng wrote:
>> Against latest commits I found that the colors on the windows guest
>> become weird.
>> For example, blue color has changed to red.
>> Is there any change on vga of qemu?
>>
>>
>
>Yes, I merged qemu-cvs and got some surprises.
>
>This doesn't appear on all machines.  Can you post the output of
>'xdpyinfo' on the affected machine?
>
>--
>Any sufficiently difficult bug is indistinguishable from a feature.
From: root [EMAIL PROTECTED]
Sent: 2007Äê10ÔÂ8ÈÕÐÇÆÚÒ» 16:27

name of display:localhost:1.0
version number:11.0
vendor string:The X.Org Foundation
vendor release number:70101000
X.Org version: 7.1.1
maximum request size:  16777212 bytes
motion buffer size:  256
bitmap unit, bit order, padding:32, LSBFirst, 32
image byte order:LSBFirst
number of supported pixmap formats:2
supported pixmap formats:
depth 1, bits_per_pixel 1, scanline_pad 32
depth 16, bits_per_pixel 16, scanline_pad 32
keycode range:minimum 8, maximum 255
focus:  window 0x321, revert to Parent
number of extensions:21
BIG-REQUESTS
DAMAGE
DEC-XTRAP
DOUBLE-BUFFER
Extended-Visual-Information
MIT-SCREEN-SAVER
MIT-SHM
MIT-SUNDRY-NONSTANDARD
RECORD
SECURITY
SHAPE
SYNC
TOG-CUP
VNC-EXTENSION
X-Resource
XC-APPGROUP
XC-MISC
XFIXES
XFree86-Bigfont
XTEST
XVideo
default screen number:0
number of screens:1

screen #0:
  dimensions:1024x768 pixels (260x195 millimeters)
  resolution:100x100 dots per inch
  depths (2):1, 16
  root window id:0x25
  depth of root window:16 planes
  number of colormaps:minimum 1, maximum 1
  default colormap:0x20
  default number of colormap cells:64
  preallocated pixels:black 0, white 65535
  options:backing-store YES, save-unders YES
  largest cursor:1024x768
  current input event mask:0xfa2033
KeyPressMask KeyReleaseMask   EnterWindowMask  
LeaveWindowMask  ButtonMotionMask StructureNotifyMask  
SubstructureNotifyMask   SubstructureRedirectMask FocusChangeMask  
PropertyChangeMask   ColormapChangeMask   
  number of visuals:2
  default visual id:  0x21
  visual:
visual id:0x21
class:TrueColor
depth:16 planes
available colormap entries:64 per subfield
red, green, blue masks:0xf800, 0x7e0, 0x1f
significant bits in color specification:8 bits
  visual:
visual id:0x22
class:DirectColor
depth:16 planes
available colormap entries:64 per subfield
red, green, blue masks:0x3f, 0x7c0, 0xf800
significant bits in color specification:8 bits
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] vga color

2007-10-08 Thread Avi Kivity
Zhao, Yunfeng wrote:
> All our machines for KVM testing have the problem.
> I attached the output of "xdpyinfo" on one of them.
>
>   

Please try the attached patch.


-- 
Any sufficiently difficult bug is indistinguishable from a feature.

diff --git a/qemu/sdl.c b/qemu/sdl.c
index 02500c9..3f3b719 100644
--- a/qemu/sdl.c
+++ b/qemu/sdl.c
@@ -87,7 +87,7 @@ static void sdl_resize(DisplayState *ds, int w, int h)
 ds->data = screen->pixels;
 ds->linesize = screen->pitch;
 ds->depth = screen->format->BitsPerPixel;
-if (screen->format->Bshift > screen->format->Rshift) {
+if (ds->depth == 32 && screen->format->Rshift == 0) {
 ds->bgr = 1;
 } else {
 ds->bgr = 0;
-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] vga color

2007-10-08 Thread Avi Kivity
Zhao, Yunfeng wrote:
> It works.:)
> The issue disappeared after applied the patch.
>   

Thanks, I applied and pushed it.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel


Re: [kvm-devel] vga color

2007-10-08 Thread Zhao, Yunfeng
It works.:)
The issue disappeared after applied the patch.

Thanks
Yunfeng

>-Original Message-
>From: Avi Kivity [mailto:[EMAIL PROTECTED]
>Sent: 2007年10月8日 17:53
>To: Zhao, Yunfeng
>Cc: kvm-devel@lists.sourceforge.net
>Subject: Re: [kvm-devel] vga color
>
>Zhao, Yunfeng wrote:
>> All our machines for KVM testing have the problem.
>> I attached the output of "xdpyinfo" on one of them.
>>
>>
>
>Please try the attached patch.
>
>
>--
>Any sufficiently difficult bug is indistinguishable from a feature.

-
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/___
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel