Re: [PATCH] powerpc: remove fpscr use from [kvm_]cvt_{fd,df}
In message <1282699836.22370.566.ca...@pasglop> you wrote: > On Tue, 2010-08-24 at 15:15 +1000, Michael Neuling wrote: > > > > Do some 32 bit processors need this? > > > > > > > > In 32 bit before the merge, we use to have code that did: > > > > > > > > #if defined(CONFIG_4xx) || defined(CONFIG_E500) > > > >#define cvt_fd without save/restore fpscr > > > > #else > > > >#define cvt_fd with save/restore fpscr > > > > #end if > > > > > > > > Kumar; does this ring any bells? > > > > > > I don't see anything in the various 440 docs I have at hand that would > > > hint at lfd/stfs adffecting FPSCR. > > > > The way the ifdefs are, it's the other way around. 4xx procs don't need > > to save/restore fpscr and others do. > > Right, my bad. In any case, Paulus reckons it's all his mistake and we > really never need to save/restore fpscr. ACK :-P Mikey -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] powerpc: remove fpscr use from [kvm_]cvt_{fd,df}
On Tue, 2010-08-24 at 15:15 +1000, Michael Neuling wrote: > > > Do some 32 bit processors need this? > > > > > > In 32 bit before the merge, we use to have code that did: > > > > > > #if defined(CONFIG_4xx) || defined(CONFIG_E500) > > >#define cvt_fd without save/restore fpscr > > > #else > > >#define cvt_fd with save/restore fpscr > > > #end if > > > > > > Kumar; does this ring any bells? > > > > I don't see anything in the various 440 docs I have at hand that would > > hint at lfd/stfs adffecting FPSCR. > > The way the ifdefs are, it's the other way around. 4xx procs don't need > to save/restore fpscr and others do. Right, my bad. In any case, Paulus reckons it's all his mistake and we really never need to save/restore fpscr. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html