Re: [PATCH 03/15] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK
On 06/17/2011 05:49 PM, Alexander Graf wrote: KVM has an ioctl to define which signal mask should be used while running inside VCPU_RUN. At least for big endian systems, this mask is different on 32-bit and 64-bit systems (though the size is identical). Add a compat wrapper that converts the mask to whatever the kernel accepts, allowing 32-bit kvm user space to set signal masks. This patch fixes qemu with --enable-io-thread on ppc64 hosts when running 32-bit user land. This is already in (175c60204146b644), I believe the same version. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL 00/15] PPC KVM patch queue 2011-06-15
On 06/17/2011 05:49 PM, Alexander Graf wrote: Hi Avi/Marcelo, This is my current patch queue for PPC KVM. Please apply. It's all good except for patch 3 which is duplicate. Can you drop it and re-post the pull URL? I could apply all ^ 3 but prefer to pull. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/15] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK
On 19.06.2011, at 11:04, Avi Kivity wrote: On 06/17/2011 05:49 PM, Alexander Graf wrote: KVM has an ioctl to define which signal mask should be used while running inside VCPU_RUN. At least for big endian systems, this mask is different on 32-bit and 64-bit systems (though the size is identical). Add a compat wrapper that converts the mask to whatever the kernel accepts, allowing 32-bit kvm user space to set signal masks. This patch fixes qemu with --enable-io-thread on ppc64 hosts when running 32-bit user land. This is already in (175c60204146b644), I believe the same version. Oh? I rebased again against origin/master and it's not there. Which tree do you want to have this against? git://git.kernel.org/pub/scm/virt/kvm/kvm.git Alex -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 03/15] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK
On 06/19/2011 03:53 PM, Alexander Graf wrote: On 19.06.2011, at 11:04, Avi Kivity wrote: On 06/17/2011 05:49 PM, Alexander Graf wrote: KVM has an ioctl to define which signal mask should be used while running inside VCPU_RUN. At least for big endian systems, this mask is different on 32-bit and 64-bit systems (though the size is identical). Add a compat wrapper that converts the mask to whatever the kernel accepts, allowing 32-bit kvm user space to set signal masks. This patch fixes qemu with --enable-io-thread on ppc64 hosts when running 32-bit user land. This is already in (175c60204146b644), I believe the same version. Oh? I rebased again against origin/master and it's not there. Which tree do you want to have this against? git://git.kernel.org/pub/scm/virt/kvm/kvm.git Sorry, it's in 'next' of the same repo. Usually the window between 'next' and 'master' is short, but I haven't run autotest in a while so 'master' is a bit stale. I'll update master later today. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] KVM: Add compat ioctl for KVM_SET_SIGNAL_MASK
On 06/09/2011 06:57 PM, Paolo Bonzini wrote:
-- 8 -
From Mon Sep 17 00:00:00 2001
From: Paolo Bonzini pbonz...@redhat.com
Date: Thu, 9 Jun 2011 17:48:50 +0200
Subject: [PATCH] KVM: fix documentation for KVM_SET_SIGNAL_MASK
The signal mask passed to KVM_SET_SIGNAL_MASK needs to be ABI-compatible
with sigprocmask, so that functions operating on sigset_t can be used
with it. Referring to the signal mask as an array of bytes is incorrect
on big endian systems, fix it.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
Documentation/kvm/api.txt |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/kvm/api.txt b/Documentation/kvm/api.txt
index 9bef4e4..ec15972 100644
--- a/Documentation/kvm/api.txt
+++ b/Documentation/kvm/api.txt
@@ -464,8 +464,8 @@ signal mask.
/* for KVM_SET_SIGNAL_MASK */
struct kvm_signal_mask {
-__u32 len;
-__u8 sigset[0];
+__u32 len;
+unsigned long sigset[0];
};
But that doesn't match the definition in kvm.h. If someone sets
kvm_signal_mask::sigset[3], they'll get different answers if they look
at the documentation or the code.
So it needs to be documented in English, not C.
(and not whitespace-damaged, either)
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PULL] PPC KVM patch queue 2011-06-19
On 06/19/2011 04:42 PM, Alexander Graf wrote: Hi Avi, here's the updated pull request. Alex The following changes since commit a94925fed08e72213eabf611744b12af3e832218: Yang, Wei (1): KVM: Enable ERMS feature support for KVM are available in the git repository at: git://github.com/agraf/linux-2.6.git kvm-ppc-next Pulled, thanks. -- error compiling committee.c: too many arguments to function -- To unsubscribe from this list: send the line unsubscribe kvm-ppc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
