Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Avi Kivity
On 06/05/2012 04:58 AM, Anthony Liguori wrote:
 On 06/05/2012 08:52 AM, Andreas Färber wrote:
 Am 04.06.2012 07:46, schrieb Anthony Liguori:
 On 05/22/2012 12:37 AM, Avi Kivity wrote:
 Please pull from:

 git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

 Pulled.  Thanks.

 This broke the ppc build. Guys, why wasn't this tested? There's only
 three KVM targets to test compared to the 14 I'm struggling with...
 
 Is build bot running against uq/master?  If it's not, maybe we should
 add it to build bot to catch this sort of thing.

A build bot is overkill.  I usually do a full build (and autotest),
don't know how this was missed.


-- 
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Alexander Graf


On 05.06.2012, at 09:42, Avi Kivity a...@redhat.com wrote:

 On 06/05/2012 04:58 AM, Anthony Liguori wrote:
 On 06/05/2012 08:52 AM, Andreas Färber wrote:
 Am 04.06.2012 07:46, schrieb Anthony Liguori:
 On 05/22/2012 12:37 AM, Avi Kivity wrote:
 Please pull from:
 
git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master
 
 Pulled.  Thanks.
 
 This broke the ppc build. Guys, why wasn't this tested? There's only
 three KVM targets to test compared to the 14 I'm struggling with...
 
 Is build bot running against uq/master?  If it's not, maybe we should
 add it to build bot to catch this sort of thing.
 
 A build bot is overkill.  I usually do a full build (and autotest),
 don't know how this was missed.

Not sure why it would be overkill. We have build bots running on more exotic hw 
(ppc and s390) with kvm available for that exact purpose. They're running 
either way - all we need to do is enable uq/master and we catch these before 
the next pull request :).


Alex

--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Jan Kiszka
On 2012-06-05 10:10, Alexander Graf wrote:
 
 
 On 05.06.2012, at 09:42, Avi Kivity a...@redhat.com wrote:
 
 On 06/05/2012 04:58 AM, Anthony Liguori wrote:
 On 06/05/2012 08:52 AM, Andreas Färber wrote:
 Am 04.06.2012 07:46, schrieb Anthony Liguori:
 On 05/22/2012 12:37 AM, Avi Kivity wrote:
 Please pull from:

git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

 Pulled.  Thanks.

 This broke the ppc build. Guys, why wasn't this tested? There's only
 three KVM targets to test compared to the 14 I'm struggling with...

 Is build bot running against uq/master?  If it's not, maybe we should
 add it to build bot to catch this sort of thing.

 A build bot is overkill.  I usually do a full build (and autotest),
 don't know how this was missed.
 
 Not sure why it would be overkill. We have build bots running on more exotic 
 hw (ppc and s390) with kvm available for that exact purpose. They're running 
 either way - all we need to do is enable uq/master and we catch these before 
 the next pull request :).

I think this makes some sense. uq/master is supposed to be the staging
branch for generic and (at least) x86 kvm changes in QEMU. So it should
cover at least their builds.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Anthony Liguori

On 06/05/2012 03:42 PM, Avi Kivity wrote:

On 06/05/2012 04:58 AM, Anthony Liguori wrote:

On 06/05/2012 08:52 AM, Andreas Färber wrote:

Am 04.06.2012 07:46, schrieb Anthony Liguori:

On 05/22/2012 12:37 AM, Avi Kivity wrote:

Please pull from:

 git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master


Pulled.  Thanks.


This broke the ppc build. Guys, why wasn't this tested? There's only
three KVM targets to test compared to the 14 I'm struggling with...


Is build bot running against uq/master?  If it's not, maybe we should
add it to build bot to catch this sort of thing.


A build bot is overkill.  I usually do a full build (and autotest),
don't know how this was missed.


Note that this error is specific to KVM on PowerPC.  It doesn't affect 
qemu-system-ppc64 built on an x86_64 host.


Regards,

Anthony Liguori






--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


Re: [Qemu-devel] [PULL 00/20 1.2] kvm updates

2012-06-05 Thread Avi Kivity
On 06/05/2012 12:02 PM, Anthony Liguori wrote:
 On 06/05/2012 03:42 PM, Avi Kivity wrote:
 On 06/05/2012 04:58 AM, Anthony Liguori wrote:
 On 06/05/2012 08:52 AM, Andreas Färber wrote:
 Am 04.06.2012 07:46, schrieb Anthony Liguori:
 On 05/22/2012 12:37 AM, Avi Kivity wrote:
 Please pull from:

  git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

 Pulled.  Thanks.

 This broke the ppc build. Guys, why wasn't this tested? There's only
 three KVM targets to test compared to the 14 I'm struggling with...

 Is build bot running against uq/master?  If it's not, maybe we should
 add it to build bot to catch this sort of thing.

 A build bot is overkill.  I usually do a full build (and autotest),
 don't know how this was missed.
 
 Note that this error is specific to KVM on PowerPC.  It doesn't affect
 qemu-system-ppc64 built on an x86_64 host.

Ah, okay.

In any case I take back my comment about overkill.  An extra buildbot
run is cheap and overkill is better than underkill.

-- 
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html