[v3][KVM][PATCH 1/1] kvm:ppc: control doorbell exception with CONFIG_PPC_DOORBELL

[Tiejun Chen]

We can only use CONFIG_PPC_DOORBELL to control whether
the doorbell exception should be enabled.

Signed-off-by: Tiejun Chen tiejun.c...@windriver.com
---
v3:

Just imporve the patch head.

v2: 

Use CONFIG_PPC_DOORBELL to replace CONFIG_KVM_E500MC as that control condition.


 arch/powerpc/kvm/booke.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
index ac7ab08..2d063c7 100644
--- a/arch/powerpc/kvm/booke.c
+++ b/arch/powerpc/kvm/booke.c
@@ -794,7 +794,7 @@ static void kvmppc_restart_interrupt(struct kvm_vcpu *vcpu,
kvmppc_fill_pt_regs(regs);
timer_interrupt(regs);
break;
-#if defined(CONFIG_PPC_FSL_BOOK3E) || defined(CONFIG_PPC_BOOK3E_64)
+#if defined(CONFIG_PPC_DOORBELL)
case BOOKE_INTERRUPT_DOORBELL:
kvmppc_fill_pt_regs(regs);
doorbell_exception(regs);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [v1][KVM][PATCH 1/1] kvm:ppc:booehv: direct ISI exception to Guest

[tiejun.chen]

On 05/11/2013 03:39 AM, Alexander Graf wrote:



Am 10.05.2013 um 21:22 schrieb Scott Wood scottw...@freescale.com:


On 05/10/2013 12:57:33 PM, Alexander Graf wrote:

Could you guys please collect performance data during the next weeks on both 
guest-directed ISIs as well as VF MMIOs (preferably with in-kernel MMIO), so 
that we can decide on the direction that's worth going towards?


Collecting data on VF MMIO would require implementing it (or at least salvaging 
and fixing some old code), which is not a high priority at the moment.  If we 
do implement VF in the future we could always undo the direct ISI change, but 
it would still be nice to know if there's any real benefit in the first place.


Mike sounded like he had an almost working poc, which is good enough to collect 
rough numbers.


Which can the test case be adopted?

Mike,

If you already have a good case for your poc, please share that with me. Then 
I'd like to run that.


Tiejun



And yes, changes like these should always get at least basic performance 
numbers along with them, regardless of drawbacks.


Alex



FWIW, I doubt that the more stress on HW TLB will be significant.

-Scott




--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html