Re: [PATCH 03 of 10] [PATCH] user: ppc: better error reporting in load_file

2008-10-29 Thread Christian Ehrhardt 

Avi Kivity wrote:

Ehrhardt Christian wrote:

From: Hollis Blanchard <[EMAIL PROTECTED]>

Fancy description.
  


Ahem.


Sorry that is my patch template description :-/
A proper description header should be:

Subject: [PATCH] user: ppc: better error reporting in load_file

From: Hollis Blanchard <[EMAIL PROTECTED]>

This patch adds a better error reporting for powerpc testcases.
It prints the bytes read in load_file so far until an error occured.

Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]>
Signed-off-by: Christian Ehrhardt <[EMAIL PROTECTED]>
---

[diffstat]
main-ppc.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

[diff]

--

Grüsse / regards, 
Christian Ehrhardt

IBM Linux Technology Center, Open Virtualization

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03 of 10] [PATCH] user: ppc: better error reporting in load_file

2008-10-29 Thread Avi Kivity 

Ehrhardt Christian wrote:

From: Hollis Blanchard <[EMAIL PROTECTED]>

Fancy description.
  


Ahem.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 03 of 10] [PATCH] user: ppc: better error reporting in load_file

2008-10-28 Thread Ehrhardt Christian 
From: Hollis Blanchard <[EMAIL PROTECTED]>

Fancy description.

Signed-off-by: Hollis Blanchard <[EMAIL PROTECTED]>
Signed-off-by: Christian Ehrhardt <[EMAIL PROTECTED]>
---

[diffstat]
 main-ppc.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

[diff]

diff --git a/user/main-ppc.c b/user/main-ppc.c
--- a/user/main-ppc.c
+++ b/user/main-ppc.c
@@ -183,7 +183,7 @@
 
 static unsigned long load_file(void *mem, const char *fname, int inval_icache)
 {
-   int r;
+   ssize_t r;
int fd;
unsigned long bytes = 0;
 
@@ -200,6 +200,7 @@
 
if (r == -1) {
perror("read");
+   printf("read %d bytes\n", bytes);
exit(1);
}
 
--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html