Re: [PATCH 2/8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO

2013-07-10 Thread Alexander Graf 

On 10.07.2013, at 01:35, Alexey Kardashevskiy wrote:

 On 07/10/2013 01:35 AM, Alexander Graf wrote:
 On 06/27/2013 07:02 AM, Alexey Kardashevskiy wrote:
 Signed-off-by: Alexey Kardashevskiya...@ozlabs.ru
 ---
  include/uapi/linux/kvm.h |2 ++
  1 file changed, 2 insertions(+)
 
 diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
 index 970b1f5..0865c01 100644
 --- a/include/uapi/linux/kvm.h
 +++ b/include/uapi/linux/kvm.h
 @@ -667,6 +667,7 @@ struct kvm_ppc_smmu_info {
  #define KVM_CAP_PPC_RTAS 91
  #define KVM_CAP_IRQ_XICS 92
  #define KVM_CAP_SPAPR_MULTITCE 93
 +#define KVM_CAP_SPAPR_TCE_IOMMU 94
 
  #ifdef KVM_CAP_IRQ_ROUTING
 
 @@ -923,6 +924,7 @@ struct kvm_s390_ucas_mapping {
  /* Available with KVM_CAP_PPC_ALLOC_HTAB */
  #define KVM_PPC_ALLOCATE_HTAB  _IOWR(KVMIO, 0xa7, __u32)
  #define KVM_CREATE_SPAPR_TCE  _IOW(KVMIO,  0xa8, struct
 kvm_create_spapr_tce)
 +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO,  0xaf, struct
 kvm_create_spapr_tce_iommu)
 
 Please order them by number.
 
 Oh. Again :( We have had this discussion with Scott Wood here already.
 Where _exactly_ do you want me to put it?

8 lines further down. With a comment saying when it's available. Also why is it 
af, not ad?

 Many sections, not really ordered. Thank you.

They should all be ordered inside of their own categories.


Alex

--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO

2013-07-10 Thread Alexey Kardashevskiy 
On 07/10/2013 08:27 PM, Alexander Graf wrote:
 
 On 10.07.2013, at 01:35, Alexey Kardashevskiy wrote:
 
 On 07/10/2013 01:35 AM, Alexander Graf wrote:
 On 06/27/2013 07:02 AM, Alexey Kardashevskiy wrote:
 Signed-off-by: Alexey Kardashevskiya...@ozlabs.ru
 ---
  include/uapi/linux/kvm.h |2 ++
  1 file changed, 2 insertions(+)

 diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
 index 970b1f5..0865c01 100644
 --- a/include/uapi/linux/kvm.h
 +++ b/include/uapi/linux/kvm.h
 @@ -667,6 +667,7 @@ struct kvm_ppc_smmu_info {
  #define KVM_CAP_PPC_RTAS 91
  #define KVM_CAP_IRQ_XICS 92
  #define KVM_CAP_SPAPR_MULTITCE 93
 +#define KVM_CAP_SPAPR_TCE_IOMMU 94

  #ifdef KVM_CAP_IRQ_ROUTING

 @@ -923,6 +924,7 @@ struct kvm_s390_ucas_mapping {
  /* Available with KVM_CAP_PPC_ALLOC_HTAB */
  #define KVM_PPC_ALLOCATE_HTAB  _IOWR(KVMIO, 0xa7, __u32)
  #define KVM_CREATE_SPAPR_TCE  _IOW(KVMIO,  0xa8, struct
 kvm_create_spapr_tce)
 +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO,  0xaf, struct
 kvm_create_spapr_tce_iommu)

 Please order them by number.

 Oh. Again :( We have had this discussion with Scott Wood here already.
 Where _exactly_ do you want me to put it?
 
 8 lines further down. With a comment saying when it's available. Also why is 
 it af, not ad?


0xad and 0xae are taken.
Where should I have commented this? In the commit message? Or in the patch
itself?


 Many sections, not really ordered. Thank you.
 
 They should all be ordered inside of their own categories.


-- 
Alexey
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO

2013-07-09 Thread Alexander Graf 

On 06/27/2013 07:02 AM, Alexey Kardashevskiy wrote:

Signed-off-by: Alexey Kardashevskiya...@ozlabs.ru
---
  include/uapi/linux/kvm.h |2 ++
  1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index 970b1f5..0865c01 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h
@@ -667,6 +667,7 @@ struct kvm_ppc_smmu_info {
  #define KVM_CAP_PPC_RTAS 91
  #define KVM_CAP_IRQ_XICS 92
  #define KVM_CAP_SPAPR_MULTITCE 93
+#define KVM_CAP_SPAPR_TCE_IOMMU 94

  #ifdef KVM_CAP_IRQ_ROUTING

@@ -923,6 +924,7 @@ struct kvm_s390_ucas_mapping {
  /* Available with KVM_CAP_PPC_ALLOC_HTAB */
  #define KVM_PPC_ALLOCATE_HTAB   _IOWR(KVMIO, 0xa7, __u32)
  #define KVM_CREATE_SPAPR_TCE_IOW(KVMIO,  0xa8, struct 
kvm_create_spapr_tce)
+#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO,  0xaf, struct 
kvm_create_spapr_tce_iommu)


Please order them by number.

Alex


  /* Available with KVM_CAP_RMA */
  #define KVM_ALLOCATE_RMA_IOR(KVMIO,  0xa9, struct kvm_allocate_rma)
  /* Available with KVM_CAP_PPC_HTAB_FD */


--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO

2013-07-09 Thread Alexey Kardashevskiy 
On 07/10/2013 01:35 AM, Alexander Graf wrote:
 On 06/27/2013 07:02 AM, Alexey Kardashevskiy wrote:
 Signed-off-by: Alexey Kardashevskiya...@ozlabs.ru
 ---
   include/uapi/linux/kvm.h |2 ++
   1 file changed, 2 insertions(+)

 diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
 index 970b1f5..0865c01 100644
 --- a/include/uapi/linux/kvm.h
 +++ b/include/uapi/linux/kvm.h
 @@ -667,6 +667,7 @@ struct kvm_ppc_smmu_info {
   #define KVM_CAP_PPC_RTAS 91
   #define KVM_CAP_IRQ_XICS 92
   #define KVM_CAP_SPAPR_MULTITCE 93
 +#define KVM_CAP_SPAPR_TCE_IOMMU 94

   #ifdef KVM_CAP_IRQ_ROUTING

 @@ -923,6 +924,7 @@ struct kvm_s390_ucas_mapping {
   /* Available with KVM_CAP_PPC_ALLOC_HTAB */
   #define KVM_PPC_ALLOCATE_HTAB  _IOWR(KVMIO, 0xa7, __u32)
   #define KVM_CREATE_SPAPR_TCE  _IOW(KVMIO,  0xa8, struct
 kvm_create_spapr_tce)
 +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO,  0xaf, struct
 kvm_create_spapr_tce_iommu)
 
 Please order them by number.

Oh. Again :( We have had this discussion with Scott Wood here already.
Where _exactly_ do you want me to put it? Many sections, not really
ordered. Thank you.



-- 
Alexey
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/8] KVM: PPC: reserve a capability and ioctl numbers for realmode VFIO

2013-07-06 Thread Alexey Kardashevskiy 
This is to reserve a capablity number for upcoming support
of VFIO-IOMMU DMA operations in real mode.

Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
---
 include/uapi/linux/kvm.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index 970b1f5..0865c01 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h
@@ -667,6 +667,7 @@ struct kvm_ppc_smmu_info {
 #define KVM_CAP_PPC_RTAS 91
 #define KVM_CAP_IRQ_XICS 92
 #define KVM_CAP_SPAPR_MULTITCE 93
+#define KVM_CAP_SPAPR_TCE_IOMMU 94
 
 #ifdef KVM_CAP_IRQ_ROUTING
 
@@ -923,6 +924,7 @@ struct kvm_s390_ucas_mapping {
 /* Available with KVM_CAP_PPC_ALLOC_HTAB */
 #define KVM_PPC_ALLOCATE_HTAB_IOWR(KVMIO, 0xa7, __u32)
 #define KVM_CREATE_SPAPR_TCE _IOW(KVMIO,  0xa8, struct 
kvm_create_spapr_tce)
+#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO,  0xaf, struct 
kvm_create_spapr_tce_iommu)
 /* Available with KVM_CAP_RMA */
 #define KVM_ALLOCATE_RMA _IOR(KVMIO,  0xa9, struct kvm_allocate_rma)
 /* Available with KVM_CAP_PPC_HTAB_FD */
-- 
1.8.3.2

--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html