Re: [PATCH v2] KVM: booke: Do Not start decrementer when SPRN_DEC set 0

2011-11-10 Thread Alexander Graf

On 10/31/2011 09:52 AM, Bharat Bhushan wrote:

As per specification the decrementer interrupt not happen when DEC is written 
with 0. Also when DEC is zero, no decrementer running. So we should not start 
hrtimer for decrementer when DEC = 0.

Signed-off-by: Bharat Bhushan


Thanks, applied to kvm-ppc-next.


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[PATCH v2] KVM: booke: Do Not start decrementer when SPRN_DEC set 0

2011-10-31 Thread Bharat Bhushan
As per specification the decrementer interrupt not happen when DEC is written 
with 0. Also when DEC is zero, no decrementer running. So we should not start 
hrtimer for decrementer when DEC = 0.

Signed-off-by: Bharat Bhushan 
---
 arch/powerpc/kvm/emulate.c |3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
index 141dce3..0452357 100644
--- a/arch/powerpc/kvm/emulate.c
+++ b/arch/powerpc/kvm/emulate.c
@@ -77,7 +77,8 @@ static int kvmppc_dec_enabled(struct kvm_vcpu *vcpu)
 #else
 static int kvmppc_dec_enabled(struct kvm_vcpu *vcpu)
 {
-   return vcpu->arch.tcr & TCR_DIE;
+   /* On BOOKE, DEC = 0 is as good as decrementer not enabled */
+   return (vcpu->arch.tcr & TCR_DIE) && vcpu->arch.dec;
 }
 #endif
 
-- 
1.7.0.4


--
To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html