Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Jean Delvare]

Hi Avi,

On Wed, 19 May 2010 20:16:35 +0300, Avi Kivity wrote:
 On 05/18/2010 10:34 AM, Jean Delvare wrote:
  kvmppc_e500_exit() is a module_exit function, so it should be tagged
  with __exit, not __init. The incorrect annotation was added by commit
  2986b8c72c272ea58edd37903b042c6da985627d.
 
 Applied, thanks.

Still not upstream?

-- 
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Avi Kivity]

On 05/18/2010 10:34 AM, Jean Delvare wrote:

kvmppc_e500_exit() is a module_exit function, so it should be tagged
with __exit, not __init. The incorrect annotation was added by commit
2986b8c72c272ea58edd37903b042c6da985627d.
   


Applied, thanks.

--
Do not meddle in the internals of kernels, for they are subtle and quick to 
panic.

--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] KVM: powerpc: fix init/exit annotation

[Mu Lin]

Hi, All,

Is there a status summary somewhere about Linux KVM on powerpc?

I am interested in KVM on MPC8572 with e500 core, and how about e500mc?

Is there bench mark testing results?

Thanks

Mu

From: kvm-ppc-ow...@vger.kernel.org [kvm-ppc-ow...@vger.kernel.org] On Behalf 
Of Jean Delvare [kh...@linux-fr.org]
Sent: Tuesday, May 18, 2010 12:34 AM
To: kvm-ppc@vger.kernel.org
Cc: Stephen Rothwell; Avi Kivity
Subject: [PATCH] KVM: powerpc: fix init/exit annotation

kvmppc_e500_exit() is a module_exit function, so it should be tagged
with __exit, not __init. The incorrect annotation was added by commit
2986b8c72c272ea58edd37903b042c6da985627d.

Signed-off-by: Jean Delvare kh...@linux-fr.org
Cc: Stephen Rothwell s...@canb.auug.org.au
Cc: Avi Kivity a...@redhat.com
Cc: sta...@kernel.org
---
 arch/powerpc/kvm/e500.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.34.orig/arch/powerpc/kvm/e500.c   2010-05-17 18:51:04.0 
+0200
+++ linux-2.6.34/arch/powerpc/kvm/e500.c2010-05-18 09:21:08.0 
+0200
@@ -164,7 +164,7 @@ static int __init kvmppc_e500_init(void)
return kvm_init(NULL, sizeof(struct kvmppc_vcpu_e500), THIS_MODULE);
 }

-static void __init kvmppc_e500_exit(void)
+static void __exit kvmppc_e500_exit(void)
 {
kvmppc_booke_exit();
 }


--
Jean Delvare
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] KVM: powerpc: fix init/exit annotation

[Alexander Graf]

On 18.05.2010, at 09:34, Jean Delvare wrote:

 kvmppc_e500_exit() is a module_exit function, so it should be tagged
 with __exit, not __init. The incorrect annotation was added by commit
 2986b8c72c272ea58edd37903b042c6da985627d.
 
 Signed-off-by: Jean Delvare kh...@linux-fr.org
 Cc: Stephen Rothwell s...@canb.auug.org.au
 Cc: Avi Kivity a...@redhat.com
 Cc: sta...@kernel.org

Good catch!

Signed-off-by: Alexander Graf ag...@suse.de


Alex

--
To unsubscribe from this list: send the line unsubscribe kvm-ppc in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html