[Launchpad-reviewers] [Merge] ~cjwatson/launchpad:charm-librarian-service-name-host into launchpad:master
Colin Watson has proposed merging
~cjwatson/launchpad:charm-librarian-service-name-host into launchpad:master.
Commit message:
charm/launchpad-librarian: Set service_name to host names
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/+git/launchpad/+merge/444678
This works a little better when related to `squid-reverseproxy`, since that
puts the service name in a `dstdomain` ACL.
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~cjwatson/launchpad:charm-librarian-service-name-host into launchpad:master.
diff --git a/charm/launchpad-librarian/reactive/launchpad-librarian.py b/charm/launchpad-librarian/reactive/launchpad-librarian.py
index fd9eded..516e537 100644
--- a/charm/launchpad-librarian/reactive/launchpad-librarian.py
+++ b/charm/launchpad-librarian/reactive/launchpad-librarian.py
@@ -210,7 +210,7 @@ def configure_loadbalancer():
unit_ip = hookenv.unit_private_ip()
services = [
{
-"service_name": "librarian-download",
+"service_name": config["librarian_download_host"],
"service_port": config["librarian_download_port"],
"service_host": "0.0.0.0",
"service_options": list(service_options_download),
@@ -225,7 +225,7 @@ def configure_loadbalancer():
],
},
{
-"service_name": "librarian-upload",
+"service_name": config["librarian_upload_host"],
"service_port": config["librarian_upload_port"],
"service_host": "0.0.0.0",
"service_options": list(service_options_upload),
@@ -241,7 +241,7 @@ def configure_loadbalancer():
],
},
{
-"service_name": "librarian-restricted-download",
+"service_name": config["librarian_restricted_download_host"],
"service_port": config["librarian_restricted_download_port"],
"service_host": "0.0.0.0",
"service_options": list(service_options_download),
@@ -256,7 +256,7 @@ def configure_loadbalancer():
],
},
{
-"service_name": "librarian-restricted-upload",
+"service_name": config["librarian_restricted_upload_host"],
"service_port": config["librarian_restricted_upload_port"],
"service_host": "0.0.0.0",
"service_options": list(service_options_upload),
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] ~petermakowski/launchpad:update-description-font-size into launchpad:master
Peter Makowski has proposed merging
~petermakowski/launchpad:update-description-font-size into launchpad:master.
Commit message:
update description font-size
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/444647
update description font-size to match body font size
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~petermakowski/launchpad:update-description-font-size into launchpad:master.
diff --git a/lib/canonical/launchpad/icing/style.css b/lib/canonical/launchpad/icing/style.css
index fcda434..125f723 100644
--- a/lib/canonical/launchpad/icing/style.css
+++ b/lib/canonical/launchpad/icing/style.css
@@ -28,6 +28,8 @@
div#edit-description,
div#edit-commit_message {
font-family: "Ubuntu Mono variable", "Ubuntu Mono", Consolas, Monaco, Courier, monospace;
+font-size: 0.8rem;
+line-height: 1.2rem;
margin: 1em 0;
}
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] ~petermakowski/launchpad:set-font-color-#000 into launchpad:master
Peter Makowski has proposed merging
~petermakowski/launchpad:set-font-color-#000 into launchpad:master.
Commit message:
set body font color to #000
Requested reviews:
Launchpad code reviewers (launchpad-reviewers)
For more details, see:
https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/444621
set body font color to #000 as suggested by Vanilla framework team.
This increases colour contrast and is likely to improve font rendering that's
been reported to cause issues for some users.
## Before
https://share.cleanshot.com/CZRm3XQB
## After
https://share.cleanshot.com/xCf8bMVz
--
Your team Launchpad code reviewers is requested to review the proposed merge of
~petermakowski/launchpad:set-font-color-#000 into launchpad:master.
diff --git a/lib/canonical/launchpad/icing/css/base.scss b/lib/canonical/launchpad/icing/css/base.scss
index a28ec5d..970fce5 100644
--- a/lib/canonical/launchpad/icing/css/base.scss
+++ b/lib/canonical/launchpad/icing/css/base.scss
@@ -6,7 +6,7 @@ body {
sans-serif;
font-size: 0.8rem;
line-height: 1.2rem;
-color: #333;
+color: #000;
&.private, &.public {
/* It must be obvious to the user that the context is private */
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] ~petermakowski/launchpad:set-font-color-#000 into launchpad:master
The proposal to merge ~petermakowski/launchpad:set-font-color-#000 into launchpad:master has been updated. Description changed to: set body font color to #000 as suggested by Vanilla framework team. This increases colour contrast and is likely to improve font rendering that's been reported to cause issues for some users. ## Before https://share.cleanshot.com/CZRm3XQB ## After https://share.cleanshot.com/xCf8bMVz For more details, see: https://code.launchpad.net/~petermakowski/launchpad/+git/launchpad/+merge/444621 -- Your team Launchpad code reviewers is requested to review the proposed merge of ~petermakowski/launchpad:set-font-color-#000 into launchpad:master. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
Re: [Launchpad-reviewers] [Merge] txpkgupload:update-wheel-command-makefile into txpkgupload:master
LGTM! -- https://code.launchpad.net/~lazr-developers/txpkgupload/+git/txpkgupload/+merge/444615 Your team Launchpad code reviewers is requested to review the proposed merge of txpkgupload:update-wheel-command-makefile into txpkgupload:master. ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
[Launchpad-reviewers] [Merge] txpkgupload:update-wheel-command-makefile into txpkgupload:master
Ines Almeida has proposed merging txpkgupload:update-wheel-command-makefile into txpkgupload:master. Commit message: Add requirements to pip wheel command in make file Requested reviews: Launchpad code reviewers (launchpad-reviewers) For more details, see: https://code.launchpad.net/~lazr-developers/txpkgupload/+git/txpkgupload/+merge/444615 This should make the txpkgupload tarball publisher to swift to actually have its dependencies met -- Your team Launchpad code reviewers is requested to review the proposed merge of txpkgupload:update-wheel-command-makefile into txpkgupload:master. diff --git a/Makefile b/Makefile index 7a96876..ddd2107 100644 --- a/Makefile +++ b/Makefile @@ -106,7 +106,8 @@ build-tarball: @echo "Creating deployment tarball at $(TARBALL_BUILD_PATH)" rm -rf $(ENV) $(MAKE) $(ENV) - $(PIP) wheel -f $(DEPENDENCY_DIR) --no-index -w $(WHEELS) + $(PIP) wheel -f $(DEPENDENCY_DIR) --no-index -w $(WHEELS) \ + -r bootstrap-requirements.txt -r requirements.txt mkdir -p $(TARBALL_BUILD_DIR) tar -czf $(TARBALL_BUILD_PATH) \ --exclude-vcs \ ___ Mailing list: https://launchpad.net/~launchpad-reviewers Post to : launchpad-reviewers@lists.launchpad.net Unsubscribe : https://launchpad.net/~launchpad-reviewers More help : https://help.launchpad.net/ListHelp
