Re: [Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:frontpage-revamp-change-layout into ~ines-almeida/launchpad:frontpage-revamp-remove-top-project

2024-02-22 Thread Ines Almeida 
I pushed a few new commits after the demo this morning:
 - The CSS file is now hosted locally
 - Small update to the style of  items in Launchpad
 - Updates the icon colors slightly and added a new icon
 - Updates the 'Launchpad' and 'Get Started' sections (see screenshots below)

Logged out: https://pasteboard.co/SgtcNkGLevV0.png
Logged in: https://pasteboard.co/j3yJPECBjUZY.png
-- 
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
Your team Launchpad code reviewers is requested to review the proposed merge of 
~ines-almeida/launchpad:frontpage-revamp-change-layout into 
~ines-almeida/launchpad:frontpage-revamp-remove-top-project.


___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

[Launchpad-reviewers] [Merge] ~philroche/launchpad:feature/dont-expire-security-staging-ppa into launchpad:master

2024-02-22 Thread Philip Roche 
Philip Roche has proposed merging 
~philroche/launchpad:feature/dont-expire-security-staging-ppa into 
launchpad:master.

Commit message:
feat: Don't expire Ubuntu Security Staging PPA

This archive is used for many security builds and to ensure further support for 
our
reproducible builds efforts the packages in this PPA should always be available 
and should not expire.

We should keep their history in the same way we do with the main archive.



Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~philroche/launchpad/+git/launchpad/+merge/461054
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of 
~philroche/launchpad:feature/dont-expire-security-staging-ppa into 
launchpad:master.
diff --git a/lib/lp/soyuz/scripts/expire_archive_files.py b/lib/lp/soyuz/scripts/expire_archive_files.py
index 55fb8ce..1509bcb 100755
--- a/lib/lp/soyuz/scripts/expire_archive_files.py
+++ b/lib/lp/soyuz/scripts/expire_archive_files.py
@@ -50,6 +50,7 @@ ubuntu-esm/esm-apps-updates
 ubuntu-esm/esm-infra-security
 ubuntu-esm/esm-infra-updates
 ubuntu-mobile
+ubuntu-security/ubuntu-security-staging
 ubuntu-security-proposed/ppa
 wheelbarrow
 """.split()
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Launchpad-reviewers] [Merge] ~philroche/launchpad:feature/dont-expire-security-staging-ppa into launchpad:master

2024-02-22 Thread Philip Roche 
The is a follow on from 
https://code.launchpad.net/~philroche/launchpad/+git/launchpad/+merge/460937 
-- 
https://code.launchpad.net/~philroche/launchpad/+git/launchpad/+merge/461054
Your team Launchpad code reviewers is requested to review the proposed merge of 
~philroche/launchpad:feature/dont-expire-security-staging-ppa into 
launchpad:master.


___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:qastaging-documentation-improvement into launchpad-buildd:master

2024-02-22 Thread Jürgen Gmach 



Diff comments:

> diff --git a/docs/how-to/deployment.rst b/docs/how-to/deployment.rst
> index 7365bee..fbe4b22 100644
> --- a/docs/how-to/deployment.rst
> +++ b/docs/how-to/deployment.rst
> @@ -42,11 +42,14 @@ Testing on qastaging
> 
> `__.
>  
>  #. Run ``mojo run -m manifest-rebuild-images`` in the management environment
> -   (``stg-vbuilder@launchpad-bastion-ps5``) to start rebuilding images.
> +   (``stg-vbuilder-qastaging@launchpad-bastion-ps5``) to start rebuilding 
> images.
> After a minute or so, ``juju status glance-simplestreams-sync-\*`` will
> show "Synchronising images"; once this says "Sync completed", images have
> been rebuilt.
>  
> +   Note that if ``mojo run -m manifest-rebuild-images`` fails, run ``mojo 
> run``
> +   instead.

Why?

> +
>  #. Builders will get the new image after they finish their next build (or
> are disabled) and go through being reset.  Since qastaging's build farm
> is typically mostly idle, you can use ``manage-builders -l qastaging


-- 
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/461052
Your team Launchpad code reviewers is requested to review the proposed merge of 
~pelpsi/launchpad-buildd:qastaging-documentation-improvement into 
launchpad-buildd:master.


___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

[Launchpad-reviewers] [Merge] ~pelpsi/launchpad-buildd:qastaging-documentation-improvement into launchpad-buildd:master

2024-02-22 Thread Simone Pelosi 
Simone Pelosi has proposed merging 
~pelpsi/launchpad-buildd:qastaging-documentation-improvement into 
launchpad-buildd:master.

Commit message:
Improve documentation for qastaging deployment

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~pelpsi/launchpad-buildd/+git/launchpad-buildd/+merge/461052
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of 
~pelpsi/launchpad-buildd:qastaging-documentation-improvement into 
launchpad-buildd:master.
diff --git a/debian/changelog b/debian/changelog
index 8bddfae..f261f59 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+launchpad-buildd (237) UNRELEASED; urgency=medium
+
+  [ Simone Pelosi ]
+  * Improve documentation for qastaging deployment.
+
+ -- Simone Pelosi   Thu, 22 Feb 2024 17:16:55 +0100
+
 launchpad-buildd (236) focal; urgency=medium
 
   [ Colin Watson ]
diff --git a/docs/how-to/deployment.rst b/docs/how-to/deployment.rst
index 7365bee..fbe4b22 100644
--- a/docs/how-to/deployment.rst
+++ b/docs/how-to/deployment.rst
@@ -42,11 +42,14 @@ Testing on qastaging
`__.
 
 #. Run ``mojo run -m manifest-rebuild-images`` in the management environment
-   (``stg-vbuilder@launchpad-bastion-ps5``) to start rebuilding images.
+   (``stg-vbuilder-qastaging@launchpad-bastion-ps5``) to start rebuilding images.
After a minute or so, ``juju status glance-simplestreams-sync-\*`` will
show "Synchronising images"; once this says "Sync completed", images have
been rebuilt.
 
+   Note that if ``mojo run -m manifest-rebuild-images`` fails, run ``mojo run``
+   instead.
+
 #. Builders will get the new image after they finish their next build (or
are disabled) and go through being reset.  Since qastaging's build farm
is typically mostly idle, you can use ``manage-builders -l qastaging
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

[Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:frontpage-revamp-change-layout into ~ines-almeida/launchpad:frontpage-revamp-remove-top-project

2024-02-22 Thread Ines Almeida 
Ines Almeida has proposed merging 
~ines-almeida/launchpad:frontpage-revamp-change-layout into 
~ines-almeida/launchpad:frontpage-revamp-remove-top-project.

Commit message:
ui: Launchpad homepage revamp

 - Imported Vanilla framework directly to the homepage
 - Re-organized homepage sections and reworked them using Vanilla components
 - Cleaned up CSS styling and page views that are no longer used

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)
  Peter Makowski (petermakowski): code

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819

Initial stab at making Launchpad's homepage a little bit more modern
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of 
~ines-almeida/launchpad:frontpage-revamp-change-layout into 
~ines-almeida/launchpad:frontpage-revamp-remove-top-project.
diff --git a/lib/canonical/launchpad/icing/css/components/_index.scss b/lib/canonical/launchpad/icing/css/components/_index.scss
index 59e25ed..057da90 100644
--- a/lib/canonical/launchpad/icing/css/components/_index.scss
+++ b/lib/canonical/launchpad/icing/css/components/_index.scss
@@ -1,6 +1,7 @@
 @import 'access_tokens',
 'batch_navigation',
 'bug_picker',
+'homepage',
 'profiling_info',
 'sidebar_portlets',
 'bug_listing',
diff --git a/lib/canonical/launchpad/icing/css/components/homepage.scss b/lib/canonical/launchpad/icing/css/components/homepage.scss
new file mode 100644
index 000..17b63cc
--- /dev/null
+++ b/lib/canonical/launchpad/icing/css/components/homepage.scss
@@ -0,0 +1,18 @@
+.homepage {
+margin: auto;
+width: 90%;
+max-width: 80em;
+}
+
+// Make search box wide
+#homepage-searchform {
+width: 100%;
+
+.p-form__group {
+flex-grow: 1;
+}
+
+.p-form__control {
+width: 100%;
+}
+}
diff --git a/lib/canonical/launchpad/images/add-homepage.png b/lib/canonical/launchpad/images/add-homepage.png
new file mode 100644
index 000..0cd9f6f
Binary files /dev/null and b/lib/canonical/launchpad/images/add-homepage.png differ
diff --git a/lib/canonical/launchpad/images/bug-homepage.png b/lib/canonical/launchpad/images/bug-homepage.png
new file mode 100644
index 000..3599ff9
Binary files /dev/null and b/lib/canonical/launchpad/images/bug-homepage.png differ
diff --git a/lib/canonical/launchpad/images/ppa-icon-homepage.png b/lib/canonical/launchpad/images/ppa-icon-homepage.png
new file mode 100644
index 000..f6f529c
Binary files /dev/null and b/lib/canonical/launchpad/images/ppa-icon-homepage.png differ
diff --git a/lib/canonical/launchpad/images/question-homepage.png b/lib/canonical/launchpad/images/question-homepage.png
new file mode 100644
index 000..f43e96f
Binary files /dev/null and b/lib/canonical/launchpad/images/question-homepage.png differ
diff --git a/lib/canonical/launchpad/images/translation-homepage.png b/lib/canonical/launchpad/images/translation-homepage.png
new file mode 100644
index 000..6988a2b
Binary files /dev/null and b/lib/canonical/launchpad/images/translation-homepage.png differ
diff --git a/lib/lp/app/browser/tales.py b/lib/lp/app/browser/tales.py
index c91b890..d6b2760 100644
--- a/lib/lp/app/browser/tales.py
+++ b/lib/lp/app/browser/tales.py
@@ -826,11 +826,10 @@ class ObjectImageDisplayAPI:
 # XXX: this should go away as soon as all image:icon where replaced
 return None
 
-def logo(self):
-"""Return the appropriate  tag for this object's logo.
+def logo_src(self):
+"""Return the appropriate src attribute for this object's logo.
 
-:return: A string, or None if the context object doesn't have
-a logo.
+:return: A string, or None if the context object doesn't have a logo.
 """
 context = self._context
 if not IHasLogo.providedBy(context):
@@ -843,10 +842,18 @@ class ObjectImageDisplayAPI:
 url = context.logo.getURL()
 else:
 url = self.default_logo_resource(context)
-if url is None:
-# We want to indicate that there is no logo for this
-# object.
-return None
+return url
+
+def logo(self):
+"""Return the appropriate  tag for this object's logo.
+
+:return: A string, or None if the context object doesn't have a logo.
+"""
+url = self.logo_src()
+if url is None:
+# We want to indicate that there is no logo for this
+# object.
+return None
 logo = ''
 return logo % url
 
diff --git a/lib/lp/app/templates/root-index.pt b/lib/lp/app/templates/root-index.pt
index ee51d55..16eae94 100644
--- a/lib/lp/app/templates/root-index.pt
+++ b/lib/lp/app/templates/root-index.pt
@@ -6,48 +6,7 @@
   metal:use-macro="view/macro:page/main_only"
   i18n:domain="launchpad">
   
-
-  .homepage {
-  margin: auto;
-

[Launchpad-reviewers] [Merge] ~ines-almeida/launchpad:frontpage-revamp-change-layout into ~ines-almeida/launchpad:frontpage-revamp-remove-top-project

2024-02-22 Thread Ines Almeida 
The proposal to merge ~ines-almeida/launchpad:frontpage-revamp-change-layout 
into ~ines-almeida/launchpad:frontpage-revamp-remove-top-project has been 
updated.

Status: Needs review => Work in progress

For more details, see:
https://code.launchpad.net/~ines-almeida/launchpad/+git/launchpad/+merge/460819
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of 
~ines-almeida/launchpad:frontpage-revamp-change-layout into 
~ines-almeida/launchpad:frontpage-revamp-remove-top-project.


___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

[Launchpad-reviewers] [Merge] ~lgp171188/launchpad:fix-launchpad-codehosting-config-changed-handler-when_any-instead-of-when into launchpad:master

2024-02-22 Thread Guruprasad 
Guruprasad has proposed merging 
~lgp171188/launchpad:fix-launchpad-codehosting-config-changed-handler-when_any-instead-of-when
 into launchpad:master.

Commit message:
charm/launchpad-codehosting: Use the when_any decorator for 
config.changed.

This should fix the bug and allow the handler to run when any of the
options are changed, instead of when all of them are changed.



Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~lgp171188/launchpad/+git/launchpad/+merge/461014
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of 
~lgp171188/launchpad:fix-launchpad-codehosting-config-changed-handler-when_any-instead-of-when
 into launchpad:master.
diff --git a/charm/launchpad-codehosting/reactive/launchpad-codehosting.py b/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
index f8cd61f..073480b 100644
--- a/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
+++ b/charm/launchpad-codehosting/reactive/launchpad-codehosting.py
@@ -21,6 +21,7 @@ from charms.reactive import (
 set_flag,
 set_state,
 when,
+when_any,
 when_not,
 when_not_all,
 )
@@ -429,7 +430,7 @@ def configure_frontend_loadbalancer():
 set_state("launchpad-codehosting.frontend-loadbalancer.configured")
 
 
-@when(
+@when_any(
 "config.changed.haproxy_service_options_http",
 "config.changed.haproxy_service_options_https",
 "config.changed.haproxy_service_options_ssh",
@@ -488,7 +489,7 @@ def configure_loadbalancer():
 set_state("launchpad-codehosting.loadbalancer.configured")
 
 
-@when(
+@when_any(
 "config.changed.haproxy_service_options_internal_branch_by_id",
 "config.changed.haproxy_server_options",
 "config.changed.port_bzr_internal",
___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp