[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/email-force-strong-auth into lp:launchpad

2018-05-14 Thread noreply 
The proposal to merge lp:~cjwatson/launchpad/email-force-strong-auth into 
lp:launchpad has been updated.

Status: Needs review => Merged

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/email-force-strong-auth/+merge/343790
-- 
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

Re: [Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/email-force-strong-auth into lp:launchpad

2018-05-01 Thread William Grant 
Review: Approve code



Diff comments:

> 
> === modified file 'lib/lp/registry/interfaces/person.py'
> --- lib/lp/registry/interfaces/person.py  2018-04-17 00:26:25 +
> +++ lib/lp/registry/interfaces/person.py  2018-04-23 08:41:01 +
> @@ -569,6 +572,24 @@
>  required=False, default=False)
>  
>  
> +class IPersonSettingsModerate(Interface):
> +"""Settings for a person (not a team!) that are used relatively rarely.
> +
> +These attributes need launchpad.View to see, and launchpad.Moderate to
> +change.
> +"""
> +
> +require_strong_email_authentication = Bool(
> +title=_("Require strong authentication for incoming emails"),
> +description=_(
> +"If this option is set, Launchpad will only accept incoming "
> +"emails from you if it can authenticate them using GPG or DKIM.  
> "

s/GPG/OpenPGP/?

> +"Launchpad administrators may set this if one of your email "
> +"addresses is being forged as the sender address for incoming "
> +"spam."),
> +required=False, default=False)
> +
> +
>  class IPersonPublic(IPrivacy):
>  """Public attributes for a Person.
>  


-- 
https://code.launchpad.net/~cjwatson/launchpad/email-force-strong-auth/+merge/343790
Your team Launchpad code reviewers is subscribed to branch lp:launchpad.

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp

[Launchpad-reviewers] [Merge] lp:~cjwatson/launchpad/email-force-strong-auth into lp:launchpad

2018-04-23 Thread Colin Watson 
Colin Watson has proposed merging 
lp:~cjwatson/launchpad/email-force-strong-auth into lp:launchpad.

Commit message:
Allow rejecting unsigned email from a given user.

Requested reviews:
  Launchpad code reviewers (launchpad-reviewers)

For more details, see:
https://code.launchpad.net/~cjwatson/launchpad/email-force-strong-auth/+merge/343790

This is a useful strategy when handling incoming email spam from addresses 
whose associated users are legitimately active (and so can't just be suspended) 
but which are being forged by spammers.
-- 
Your team Launchpad code reviewers is requested to review the proposed merge of 
lp:~cjwatson/launchpad/email-force-strong-auth into lp:launchpad.
=== modified file 'lib/lp/registry/browser/person.py'
--- lib/lp/registry/browser/person.py	2017-06-01 12:58:53 +
+++ lib/lp/registry/browser/person.py	2018-04-23 08:41:01 +
@@ -1,4 +1,4 @@
-# Copyright 2009-2017 Canonical Ltd.  This software is licensed under the
+# Copyright 2009-2018 Canonical Ltd.  This software is licensed under the
 # GNU Affero General Public License version 3 (see the file LICENSE).
 
 """Person-related view classes."""
@@ -1231,7 +1231,9 @@
 label = "Review person"
 field_names = [
 'name', 'display_name',
-'personal_standing', 'personal_standing_reason']
+'personal_standing', 'personal_standing_reason',
+'require_strong_email_authentication',
+]
 custom_widget(
 'personal_standing_reason', TextAreaWidget, height=5, width=60)
 

=== modified file 'lib/lp/registry/browser/tests/person-admin-views.txt'
--- lib/lp/registry/browser/tests/person-admin-views.txt	2015-10-01 10:25:19 +
+++ lib/lp/registry/browser/tests/person-admin-views.txt	2018-04-23 08:41:01 +
@@ -18,7 +18,8 @@
 []
 >>> view.field_names
 ['name', 'display_name',
- 'personal_standing', 'personal_standing_reason']
+ 'personal_standing', 'personal_standing_reason',
+ 'require_strong_email_authentication']
 >>> view.label
 'Review person'
 
@@ -50,6 +51,8 @@
 
 >>> print user.personal_standing_reason
 Zaphod's just this guy.
+>>> user.require_strong_email_authentication
+False
 
 Non administrators cannot access the +review view
 

=== modified file 'lib/lp/registry/configure.zcml'
--- lib/lp/registry/configure.zcml	2017-06-16 11:10:39 +
+++ lib/lp/registry/configure.zcml	2018-04-23 08:41:01 +
@@ -1,4 +1,4 @@
-
 
@@ -1028,7 +1028,8 @@
 interface="lp.registry.interfaces.person.IPersonLimitedView"/>
 
+interface="lp.registry.interfaces.person.IPersonViewRestricted
+   lp.registry.interfaces.person.IPersonModerate"/>
 
@@ -1047,6 +1048,7 @@
 
 http://launchpad.dev/~%s/+editpgpkeys\n\n;
+"If you did not knowingly send email to Launchpad, then spammers "
+"may be\n"
+"forging messages as if they were sent from your address, perhaps "
+"due to\n"
+"a compromised address book, and you can safely ignore this "
+"message.\n" % sender.name)
+self.assertEqual(expected_message, error.message)

___
Mailing list: https://launchpad.net/~launchpad-reviewers
Post to : launchpad-reviewers@lists.launchpad.net
Unsubscribe : https://launchpad.net/~launchpad-reviewers
More help   : https://help.launchpad.net/ListHelp