Re: [Lazarus] Extended filter for Code Completion

2018-01-17 Thread Ondrej Pokorny via Lazarus 

On 17.01.2018 22:35, Juha Manninen via Lazarus wrote:

Ondrej, please check my fix in r57109.


Yeap, thanks.

Ondrej
--
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-17 Thread Juha Manninen via Lazarus 
Ondrej, please check my fix in r57109.

Juha
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-17 Thread Juha Manninen via Lazarus 
On Wed, Jan 17, 2018 at 9:23 AM, Ondrej Pokorny via Lazarus
 wrote:
> I fixed this by myself in r57105.

Thanks.

See also
 https://bugs.freepascal.org/view.php?id=24043
which I marked as related to
  https://bugs.freepascal.org/view.php?id=32974

Juha
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-16 Thread Ondrej Pokorny via Lazarus 

On 17.01.2018 13:00, Ondrej Pokorny via Lazarus wrote:

On 09.01.2018 0:55, Juha Manninen via Lazarus wrote:

I applied the patch from here:
  https://bugs.freepascal.org/view.php?id=32974
It looks good to me.
Please test everybody. Does it have negative side-effects of some kind?


The highlight color of the keyword is hard coded and it doesn't change 
for selected item meaning I can hardly read the selected item.


I fixed this by myself in r57105.

Ondrej
--
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-16 Thread Ondrej Pokorny via Lazarus 

On 09.01.2018 0:55, Juha Manninen via Lazarus wrote:

I applied the patch from here:
  https://bugs.freepascal.org/view.php?id=32974
It looks good to me.
Please test everybody. Does it have negative side-effects of some kind?


The highlight color of the keyword is hard coded and it doesn't change 
for selected item meaning I can hardly read the selected item.




A second question: why are the settings in "Editor -> Completion and 
hints" page of IDE options and not "Codetools -> Identifier completion" ?


Ondrej
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-13 Thread Juha Manninen via Lazarus 
I renamed variable names and improved the GUI text in r57072.
Now it says: "Include identifiers containing prefix".
Please test.
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-10 Thread Juha Manninen via Lazarus 
On Tue, Jan 9, 2018 at 8:44 PM, Mattias Gaertner via Lazarus
 wrote:
> "AddContainsPrefix" or (not) "OnlyBeginsWithPrefix"?

Or "IncludeContainsPrefix"?
The GUI checkbox caption would be "Include items containing typed text".
Or something ...

Juha
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-09 Thread Mattias Gaertner via Lazarus 
On Mon, 8 Jan 2018 19:55:11 +0200
Juha Manninen via Lazarus  wrote:

> I applied the patch from here:
>  https://bugs.freepascal.org/view.php?id=32974
> It looks good to me.
> Please test everybody. Does it have negative side-effects of some kind?

The name ExtendedFilter sounds as if it gives more options.

Instead it adds identifiers that contains the identifier, behind the
usual list of identifiers that starts with the identifiers. What would
be a good name for this option?
"AddContainsPrefix" or (not) "OnlyBeginsWithPrefix"?

Mattias
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-09 Thread Denis Kozlov via Lazarus 

This feature is awesome! Works perfect so far, even with unit names.

It was on my wishlist since Lazarus 0.9 days.

Denis


On 08/01/2018 17:55, Juha Manninen via Lazarus wrote:

I applied the patch from here:
  https://bugs.freepascal.org/view.php?id=32974
It looks good to me.
Please test everybody. Does it have negative side-effects of some kind?

Juha


--
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-08 Thread Vojtěch Čihák via Lazarus 

It can be resized by mouse, by the small handle in bottom-rigth corner.
 
V.
__

Od: AlexeyT via Lazarus <lazarus@lists.lazarus-ide.org>
Komu: Juha Manninen via Lazarus <lazarus@lists.lazarus-ide.org>
Datum: 08.01.2018 19:30
Předmět: Re: [Lazarus] Extended filter for Code Completion

patch makes red hilite of current ID in the listbox. Can you tell how to 
make listbox 2x-3x wider? it's narrow.

> Please test everybody. Does it have negative side-effects of some kind?

--
Regards,
Alexey

--
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus 
<https://lists.lazarus-ide.org/listinfo/lazarus>

-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] Extended filter for Code Completion

2018-01-08 Thread AlexeyT via Lazarus 
patch makes red hilite of current ID in the listbox. Can you tell how to 
make listbox 2x-3x wider? it's narrow.

Please test everybody. Does it have negative side-effects of some kind?


--
Regards,
Alexey

--
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

[Lazarus] Extended filter for Code Completion

2018-01-08 Thread Juha Manninen via Lazarus 
I applied the patch from here:
 https://bugs.freepascal.org/view.php?id=32974
It looks good to me.
Please test everybody. Does it have negative side-effects of some kind?

Juha
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus