Re: [Lazarus] IDE "Rename identifier" misfeature

2020-05-26 Thread Juha Manninen via lazarus 
On Tue, May 26, 2020 at 10:49 AM Pascal Riekenberg via lazarus
 wrote:
> Well, IDE doesn't check for conflicts. It's up to you!

Actually it should check. There is also different pieces of code for
different rename functions behaving a little differently.
There are some related issues. See:
 https://bugs.freepascal.org/view.php?id=24275
 https://bugs.freepascal.org/view.php?id=33024

Juha
-- 
___
lazarus mailing list
lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

Re: [Lazarus] IDE "Rename identifier" misfeature

2020-05-26 Thread Pascal Riekenberg via lazarus 
Well, IDE doesn't check for conflicts. It's up to you!

Pascal

> "Alexey Tor. via lazarus"  hat am 26. Mai 2020 
> um 00:25 geschrieben:
> 
> 
> Hello
> 
> ATSynEdit has such function
> procedure TATSynRanges.DeleteFromLineIndexer(AIndex: integer);
> var
>    Ptr: PATSynRange;
>    NItemLen, iLine, iItem, j: integer;
> begin
>    Ptr:= ItemPtr(AIndex);
>    for iLine:= Ptr^.Y2 downto Ptr^.Y do
>    begin
>      ..
>    end;
> end;
> 
> when I do "Rename identifier" from Ptr to ItemPtr, IDE allows to do it,
> and I have conflict with class method ItemPtr(), which is even called in 
> this function.
> 
> -- 
> Regards,
> Alexey Torgashin
> 
> -- 
> ___
> lazarus mailing list
> lazarus@lists.lazarus-ide.org
> https://lists.lazarus-ide.org/listinfo/lazarus
-- 
___
lazarus mailing list
lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus

[Lazarus] IDE "Rename identifier" misfeature

2020-05-25 Thread Alexey Tor. via lazarus 

Hello

ATSynEdit has such function
procedure TATSynRanges.DeleteFromLineIndexer(AIndex: integer);
var
  Ptr: PATSynRange;
  NItemLen, iLine, iItem, j: integer;
begin
  Ptr:= ItemPtr(AIndex);
  for iLine:= Ptr^.Y2 downto Ptr^.Y do
  begin
    ..
  end;
end;

when I do "Rename identifier" from Ptr to ItemPtr, IDE allows to do it,
and I have conflict with class method ItemPtr(), which is even called in 
this function.


--
Regards,
Alexey Torgashin

--
___
lazarus mailing list
lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus