Re: [Lazarus] Unix Select Printer dlg: tab-order fix

2018-07-27 Thread Juha Manninen via Lazarus
On Fri, Jul 27, 2018 at 2:22 PM Maxim Ganetsky via Lazarus
 wrote:
> The patch looks good, please apply it too.

Ok, applied in r58641.

Juha
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus


Re: [Lazarus] Unix Select Printer dlg: tab-order fix

2018-07-27 Thread Maxim Ganetsky via Lazarus
27.07.2018 13:29, Juha Manninen via Lazarus пишет:
> On Thu, Jul 26, 2018 at 12:52 PM AlexeyT via Lazarus
>  wrote:
>> this fixes weird tab-order.
> 
> I applied this one in r58640. Thanks.
> I leave the i18n patch for Maxim.

The patch looks good, please apply it too.

-- 
Best regards,
 Maxim Ganetsky  mailto:gan...@narod.ru
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus


Re: [Lazarus] Unix Select Printer dlg: tab-order fix

2018-07-27 Thread Juha Manninen via Lazarus
On Thu, Jul 26, 2018 at 12:52 PM AlexeyT via Lazarus
 wrote:
> this fixes weird tab-order.

I applied this one in r58640. Thanks.
I leave the i18n patch for Maxim.

Juha
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus


[Lazarus] Unix Select Printer dlg: tab-order fix

2018-07-26 Thread AlexeyT via Lazarus

this fixes weird tab-order.

--
Regards,
Alexey

Index: components/printers/unix/udlgselectprinter.lfm
===
--- components/printers/unix/udlgselectprinter.lfm	(revision 58637)
+++ components/printers/unix/udlgselectprinter.lfm	(working copy)
@@ -12,7 +12,7 @@
   OnCreate = dlgSelectPrinterCREATE
   OnShow = dlgSelectPrinterSHOW
   Position = poScreenCenter
-  LCLVersion = '1.5'
+  LCLVersion = '1.9.0.0'
   object PrinterGroupbox: TGroupBox
 Left = 6
 Height = 137
@@ -110,7 +110,7 @@
   AutoSize = True
   Caption = 'Properties ...'
   OnClick = btnPropCLICK
-  TabOrder = 0
+  TabOrder = 1
 end
 object cbPrintToFile: TCheckBox
   AnchorSideRight.Side = asrBottom
@@ -120,7 +120,7 @@
   Width = 101
   Anchors = [akRight, akBottom]
   Caption = 'Print to file'
-  TabOrder = 1
+  TabOrder = 2
 end
 object cbPrinters: TComboBox
   AnchorSideRight.Control = btnProp
@@ -134,7 +134,7 @@
   OnChange = cbPrintersCHANGE
   OnKeyPress = cbPrintersKEYPRESS
   Style = csDropDownList
-  TabOrder = 2
+  TabOrder = 0
 end
   end
   object NbOpts: TPageControl
@@ -201,7 +201,7 @@
   Anchors = [akTop, akLeft, akRight]
   BorderSpacing.Left = 15
   BorderSpacing.Right = 6
-  TabOrder = 0
+  TabOrder = 4
 end
 object edPageSet: TComboBox
   AnchorSideTop.Control = labPage
@@ -222,7 +222,7 @@
 'Even pages'
   )
   Style = csDropDownList
-  TabOrder = 1
+  TabOrder = 5
   Text = 'All pages'
 end
 object rbCurrentPage: TRadioButton
@@ -236,7 +236,7 @@
   Caption = 'Current page'
   DragCursor = crDefault
   Enabled = False
-  TabOrder = 2
+  TabOrder = 1
 end
 object rbRange: TRadioButton
   AnchorSideTop.Control = rbSelection
@@ -248,7 +248,7 @@
   BorderSpacing.Around = 2
   Caption = 'Range'
   DragCursor = crDefault
-  TabOrder = 4
+  TabOrder = 3
 end
 object rbAllPage: TRadioButton
   Left = 8
@@ -258,7 +258,7 @@
   Caption = 'All '
   Checked = True
   DragCursor = crDefault
-  TabOrder = 3
+  TabOrder = 0
   TabStop = True
 end
 object rbSelection: TRadioButton
@@ -272,7 +272,7 @@
   Caption = 'Selection'
   DragCursor = crDefault
   Enabled = False
-  TabOrder = 5
+  TabOrder = 2
 end
   end
   object gbCopies: TGroupBox
@@ -335,7 +335,7 @@
   Caption = 'Collate'
   DragCursor = crDefault
   OnClick = cbReverseCLICK
-  TabOrder = 2
+  TabOrder = 1
 end
 object cbReverse: TCheckBox
   AnchorSideTop.Control = cbCollate
@@ -349,7 +349,7 @@
   Caption = 'Reverse'
   DragCursor = crDefault
   OnClick = cbReverseCLICK
-  TabOrder = 1
+  TabOrder = 2
 end
   end
 end
@@ -469,7 +469,7 @@
   Caption = 'Cancel'
   Constraints.MinWidth = 80
   ModalResult = 2
-  TabOrder = 0
+  TabOrder = 3
 end
 object btnPrint: TButton
   Left = 391
@@ -484,7 +484,7 @@
   Default = True
   ModalResult = 1
   OnClick = btnPrintCLICK
-  TabOrder = 1
+  TabOrder = 2
 end
 object btnReduc: TButton
   Left = 6
@@ -497,7 +497,7 @@
   Caption = 'More ...'
   Constraints.MinWidth = 80
   OnClick = btnReducCLICK
-  TabOrder = 2
+  TabOrder = 0
 end
 object btnPreview: TButton
   Left = 305
@@ -510,7 +510,7 @@
   Caption = 'Preview'
   Constraints.MinWidth = 80
   ModalResult = 6
-  TabOrder = 3
+  TabOrder = 1
 end
   end
   object panLabels: TPanel
-- 
___
Lazarus mailing list
Lazarus@lists.lazarus-ide.org
https://lists.lazarus-ide.org/listinfo/lazarus