[Lazarus] Attn Mattias: is r45063 correct? Fixed building lhelp under FPC 2.6.4

2014-05-19 Thread Reinier Olislagers 
Saw this
r45063
lhelp: fixed building lhelp under fpc 2.6.4

---
branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas
2014/05/17 18:55:25 45062
+++
branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas
2014/05/17 18:57:08 45063
@@ -283,6 +283,9 @@
   //  Exit;

   Proc := TProcessUTF8.Create(nil);
+  {$if FPC_FULLVERSION20400}
+  Proc.InheritHandles := false;
+  {$endif}
   {$if (fpc_version=2) and (fpc_release5)}
   Proc.CommandLine := Lazbuild+' '+WS+' '+PCP+' '+LHelpProject;
   {$else}

However, that tests for FPC up to and including FPC 2.3, not 2.6.4 and up
Either:
1. the description of the fix is wrong
2. the fix is wrong
3. I haven't had enough coffee or there's something else wrong with me...

Thanks,
Reinier

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus

Re: [Lazarus] Attn Mattias: is r45063 correct? Fixed building lhelp under FPC 2.6.4

2014-05-19 Thread Mattias Gaertner 
On Mon, 19 May 2014 10:21:44 +0200
Reinier Olislagers reinierolislag...@gmail.com wrote:

 Saw this
 r45063
 lhelp: fixed building lhelp under fpc 2.6.4
 
 ---
 branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas
 2014/05/17 18:55:25   45062
 +++
 branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas
 2014/05/17 18:57:08   45063
 @@ -283,6 +283,9 @@
//  Exit;
 
Proc := TProcessUTF8.Create(nil);
 +  {$if FPC_FULLVERSION20400}
 +  Proc.InheritHandles := false;
 +  {$endif}
{$if (fpc_version=2) and (fpc_release5)}
Proc.CommandLine := Lazbuild+' '+WS+' '+PCP+' '+LHelpProject;
{$else}
 
 However, that tests for FPC up to and including FPC 2.3, not 2.6.4 and up
 Either:
 1. the description of the fix is wrong
 2. the fix is wrong
 3. I haven't had enough coffee or there's something else wrong with me...

You are right. It should be 20604. Fixed.

Mattias

--
___
Lazarus mailing list
Lazarus@lists.lazarus.freepascal.org
http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus