Re: [lazarus] Version Information: your comments please

2006-04-04 Thread Mattias Gaertner
On Thu, 16 Mar 2006 20:04:53 +0100
Marc Weustink <[EMAIL PROTECTED]> wrote:

> Jouke Rensma wrote:
> > I've sent the mail below earlier but apparantly it did not make it. 
> > Maybe due to the attachements? I now zipped them into one (smaller)
> > file. ---
> > Hi all,
> > After some strugling, re-doing and starting from scratch again, I 
> > managed to
> > get the version information hooked into the compile process. With
> > several things still to do (see below), now I would like to know:
> > - Am I on the right track?
> > - Have I hooked in on the right places?
> > - Where did I go wrong, and where not?
> 
> 
> I had a quick look at the code and it looked OK. However IMO the 
> W32VersionInfo unit doesn't belong there.
> I don't see a problem with having a TVersionInfo class generating a .rc 
> file for every platform. Then in some pre/post build step some .rc 
> "compiler" can per platform:
>   * compile a .res to be linked in or put it in an exe
> direclty (win32)
>   * generate/edit a Info.plist and/or setup resource in the
> project.app dir (OSX)
>   * maybe do something (some other platform)

Right.
And there is a bug:
Every BeginBlock must be closed with an EndBlock.

Any volunteers?

Mattias

_
 To unsubscribe: mail [EMAIL PROTECTED] with
"unsubscribe" as the Subject
   archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] Version Information: your comments please

2006-03-16 Thread Marc Weustink

Jouke Rensma wrote:
I've sent the mail below earlier but apparantly it did not make it. 
Maybe due to the attachements? I now zipped them into one (smaller) file.

---
Hi all,
After some strugling, re-doing and starting from scratch again, I 
managed to

get the version information hooked into the compile process. With several
things still to do (see below), now I would like to know:
- Am I on the right track?
- Have I hooked in on the right places?
- Where did I go wrong, and where not?



I had a quick look at the code and it looked OK. However IMO the 
W32VersionInfo unit doesn't belong there.
I don't see a problem with having a TVersionInfo class generating a .rc 
file for every platform. Then in some pre/post build step some .rc 
"compiler" can per platform:

 * compile a .res to be linked in or put it in an exe
   direclty (win32)
 * generate/edit a Info.plist and/or setup resource in the
   project.app dir (OSX)
 * maybe do something (some other platform)

Marc

_
To unsubscribe: mail [EMAIL PROTECTED] with
   "unsubscribe" as the Subject
  archives at http://www.lazarus.freepascal.org/mailarchives


[lazarus] Version Information: your comments please

2006-03-15 Thread Jouke Rensma
I've sent the mail below earlier but apparantly it did not make it. Maybe 
due to the attachements? I now zipped them into one (smaller) file. 

--- 

Hi all, 


After some strugling, re-doing and starting from scratch again, I managed to
get the version information hooked into the compile process. With several
things still to do (see below), now I would like to know: 


- Am I on the right track?
- Have I hooked in on the right places?
- Where did I go wrong, and where not? 


Current status:
- the rc file has to be created by hand.
- you can select in the project options if you want to use version info.
- if so, you can also select if you want to auto-update the build number.
- if selected the build number will be updated.
- if you deselect the use of versioninfo, the rc file is not updated anymore
and is not re-compiled, however the "old" info is kept in the executable
(see todo). 


Things to do:
- Include the other Version Info fields:
- "Comments"
- "CompanyName"
- "FileDescription"
- "InternalName"
- "LegalCopyright"
- "LegalTrademarks"
- "OriginalFilename"
- "ProductName"
- "ProductVersion"
- Also include the additional fields:
-  "Translation" (this is one line in the rc file, but contains 2 
fields:
Language and Character Set)
- Detect if the build of the application itself went ok or not and keep
build-number accordingly.
- Removal of the Version Info, when user decides to not use it anymore.	 



So, ladies and gentlemen, your comments please... 


Cheers,
Jouke 


PS I hope I created the patch the right way etc.???
PS2 the number in the filename of the patch is just for my own reference. 





zippyeoF6g5es.zip
Description: Zip archive