Re: [lazarus] New synedit patch

2008-01-27 Thread Felipe Monteiro de Carvalho
Thanks, applied as it's much better then the current behavior.

However, it still isn't perfect. On:

  Caption := 'éé';
  Edit1.Text := 'éé';

If you double click Caption the cursor ends up 1 char before C

If you double click Text it goes between t and 1

thanks,
-- 
Felipe Monteiro de Carvalho

_
 To unsubscribe: mail [EMAIL PROTECTED] with
unsubscribe as the Subject
   archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] New synedit patch

2008-01-27 Thread Paul Ishenin

Felipe Monteiro de Carvalho wrote:

If you double click Text it goes between t and 1
  

Sorry, where is 1 in word Text :) ?

Best regards,
Paul Ishenin.

_
To unsubscribe: mail [EMAIL PROTECTED] with
   unsubscribe as the Subject
  archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] New synedit patch

2008-01-27 Thread Ales Katona

Felipe Monteiro de Carvalho  wrote / napísal(a):

Thanks, applied as it's much better then the current behavior.

However, it still isn't perfect. On:

  Caption := 'éé';
  Edit1.Text := 'éé';

If you double click Caption the cursor ends up 1 char before C

If you double click Text it goes between t and 1

thanks,
  
You're right, this is a logical problem on my end. I need to know how 
many utf8 chars are BEFORE the current word, not on the whole line. I'll 
try to fix this.


Ales

_
To unsubscribe: mail [EMAIL PROTECTED] with
   unsubscribe as the Subject
  archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] New synedit patch

2008-01-27 Thread Ales Katona

Felipe Monteiro de Carvalho  wrote / napísal(a):

Thanks, applied as it's much better then the current behavior.

However, it still isn't perfect. On:

  Caption := 'éé';
  Edit1.Text := 'éé';

If you double click Caption the cursor ends up 1 char before C

If you double click Text it goes between t and 1

thanks,
  

This patch fixed the oversight :)

Ales
Index: components/synedit/synedit.pp
===
--- components/synedit/synedit.pp	(revision 13892)
+++ components/synedit/synedit.pp	(working copy)
@@ -6516,6 +6516,7 @@
   CaretXY := Runner;
   {$IFDEF SYN_LAZARUS}
   if UseUTF8 then begin
+Delete(TempString, fBlockEnd.X, Length(TempString));
 CaretX := CaretX - Max(0, (Length(TempString) - UTF8Length(TempString)));
   end;
   {$ENDIF}


Re: [lazarus] New synedit patch

2008-01-27 Thread Felipe Monteiro de Carvalho
On Jan 27, 2008 3:48 PM, Paul Ishenin [EMAIL PROTECTED] wrote:
 Felipe Monteiro de Carvalho wrote:
  If you double click Text it goes between t and 1
 
 Sorry, where is 1 in word Text :) ?

It's on the word on the left of it: Edit1.Text

The idea is that you click one word and the caret goes to the other
word on the left.

-- 
Felipe Monteiro de Carvalho

_
 To unsubscribe: mail [EMAIL PROTECTED] with
unsubscribe as the Subject
   archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] New synedit patch

2008-01-27 Thread Felipe Monteiro de Carvalho
Thanks applied. I did some testing and it looks perfect now =)

thanks again,
-- 
Felipe Monteiro de Carvalho

_
 To unsubscribe: mail [EMAIL PROTECTED] with
unsubscribe as the Subject
   archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] New synedit patch

2008-01-27 Thread Ales Katona

Felipe Monteiro de Carvalho  wrote / napísal(a):

On Jan 27, 2008 3:48 PM, Paul Ishenin [EMAIL PROTECTED] wrote:
  

Felipe Monteiro de Carvalho wrote:


If you double click Text it goes between t and 1

  

Sorry, where is 1 in word Text :) ?



It's on the word on the left of it: Edit1.Text

The idea is that you click one word and the caret goes to the other
word on the left.

  
If you apply my last patch (see a few mails earlier, synedit3.patch), 
you'll fix this :)


Ales

_
To unsubscribe: mail [EMAIL PROTECTED] with
   unsubscribe as the Subject
  archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] New synedit patch

2008-01-27 Thread Felipe Monteiro de Carvalho
Ok, so we are now reduced to zero known regressions introduced by
unicode win32 Lazarus.

Just thougth I could use this opportunity to encourage people to test it =)

thanks,
-- 
Felipe Monteiro de Carvalho

_
 To unsubscribe: mail [EMAIL PROTECTED] with
unsubscribe as the Subject
   archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] New synedit patch

2008-01-27 Thread zaher dirkey
How we can test it?, i use compile from SVN i will use Arabic language in my
units (strings).
Is we can use it also for WinCE?

On Jan 27, 2008 6:20 PM, Felipe Monteiro de Carvalho 
[EMAIL PROTECTED] wrote:

 Ok, so we are now reduced to zero known regressions introduced by
 unicode win32 Lazarus.

 Just thougth I could use this opportunity to encourage people to test it
 =)

 thanks,
 --
 Felipe Monteiro de Carvalho

 _
 To unsubscribe: mail [EMAIL PROTECTED] with
unsubscribe as the Subject
   archives at http://www.lazarus.freepascal.org/mailarchives




-- 
Zaher Dirkey


Re: [lazarus] New synedit patch

2008-01-27 Thread Ales Katona

zaher dirkey  wrote / napísal(a):
How we can test it?, i use compile from SVN i will use Arabic language 
in my units (strings).

Is we can use it also for WinCE?

On Jan 27, 2008 6:20 PM, Felipe Monteiro de Carvalho 
[EMAIL PROTECTED] 
mailto:[EMAIL PROTECTED] wrote:


Ok, so we are now reduced to zero known regressions introduced by
unicode win32 Lazarus.

Just thougth I could use this opportunity to encourage people to
test it =)

thanks,
--
Felipe Monteiro de Carvalho

_
To unsubscribe: mail [EMAIL PROTECTED]
mailto:[EMAIL PROTECTED] with
   unsubscribe as the Subject
  archives at http://www.lazarus.freepascal.org/mailarchives




--
Zaher Dirkey 


Just doubleclick a word with special (non latin1) chars, and see if it's 
properly selected. Or try other functions like SynEdit.NextWordPos etc.


Ales

_
To unsubscribe: mail [EMAIL PROTECTED] with
   unsubscribe as the Subject
  archives at http://www.lazarus.freepascal.org/mailarchives


Re: [lazarus] New synedit patch

2008-01-27 Thread Felipe Monteiro de Carvalho
On Jan 27, 2008 10:43 PM, zaher dirkey [EMAIL PROTECTED] wrote:
 How we can test it?, i use compile from SVN i will use Arabic language in my
 units (strings).

You need to recompile with unicode enabled:

http://wiki.lazarus.freepascal.org/LCL_Unicode_Support#Compiling_LCL-Win32_with_Unicode

Then you can write unicode text to the code editor and the object
inspector. Legacy code needs to be converted to utf-8

 Is we can use it also for WinCE?

Not yet. I hope to implement it in the next month(s).

-- 
Felipe Monteiro de Carvalho

_
 To unsubscribe: mail [EMAIL PROTECTED] with
unsubscribe as the Subject
   archives at http://www.lazarus.freepascal.org/mailarchives