Re: [lazarus] VersionInfo - How to set SomethingHasChanged?
Mattias Gaertner wrote: On Thu, 07 Sep 2006 16:40:05 +0200 Jouke Rensma [EMAIL PROTECTED] wrote: Hello, So I got things working now! The code is in the enclosed (zipped) patch. I realize it needs some finetuning, but the basic logic does what I had in mind. Now I think it needs some testing, in order to get it ready for the world. Some questions and remarks: - I had to create an extra form for the projectoptions. Can it stay like this or are there other possibilities/ideas? - I created a check for the targetos, so it should not interfere non-win32 systems, but I cannot test that right now. - the rewriting of the .rc file is not protected with try yet. That's my first change... Thanks. Applied. Any other remarks and suggestions are welcome. Project.Modified is a property. You can not give it to a 'var' parameter. It's a compiler bug to allow that. I replaced Project.Modified. Possible improvement: Add a Modified property to the version info. Minors: The lazarus code should have a maximum line length of 80. Try to avoid nested comments. Major: avoid memleaks. Heap dump by heaptrc unit 266867 memory blocks allocated : 16990426/17694552 266849 memory blocks freed : 16987445/17691520 18 unfreed memory blocks : 2981 True heap size : 3899392 (112 used in System startup) True free heap : 3893168 Should be : 3893512 Call trace for block $04C13CA0 size 55 $008AE785 fpc_ansistr_setlength, line 378 of C:/lazarus/source/fpc/2.1/rtl/i nc/astrings.inc $008AE3C7 fpc_ansistr_concat, line 163 of C:/lazarus/source/fpc/2.1/rtl/inc/ astrings.inc $007ECB19 TVERSIONINFO__SETFILENAMES, line 574 of W32VersionInfo.pas $0070B88E TPROJECT__READPROJECT, line 2028 of Project.pp $00671FE7 TMAINIDE__DOOPENPROJECTFILE, line 6862 of Main.pp $00689105 TMAINIDE__SETUPSTARTPROJECT, line 1670 of Main.pp $006898EC TMAINIDE__STARTIDE, line 1113 of Main.pp Vincent _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] VersionInfo - How to set SomethingHasChanged?
On Sat, 09 Sep 2006 14:52:44 +0200 Vincent Snijders [EMAIL PROTECTED] wrote: Mattias Gaertner wrote: On Thu, 07 Sep 2006 16:40:05 +0200 Jouke Rensma [EMAIL PROTECTED] wrote: Hello, So I got things working now! The code is in the enclosed (zipped) patch. I realize it needs some finetuning, but the basic logic does what I had in mind. Now I think it needs some testing, in order to get it ready for the world. Some questions and remarks: - I had to create an extra form for the projectoptions. Can it stay like this or are there other possibilities/ideas? - I created a check for the targetos, so it should not interfere non-win32 systems, but I cannot test that right now. - the rewriting of the .rc file is not protected with try yet. That's my first change... Thanks. Applied. Any other remarks and suggestions are welcome. Project.Modified is a property. You can not give it to a 'var' parameter. It's a compiler bug to allow that. I replaced Project.Modified. Possible improvement: Add a Modified property to the version info. Minors: The lazarus code should have a maximum line length of 80. Try to avoid nested comments. Major: avoid memleaks. Fixed. Mattias Heap dump by heaptrc unit 266867 memory blocks allocated : 16990426/17694552 266849 memory blocks freed : 16987445/17691520 18 unfreed memory blocks : 2981 True heap size : 3899392 (112 used in System startup) True free heap : 3893168 Should be : 3893512 Call trace for block $04C13CA0 size 55 $008AE785 fpc_ansistr_setlength, line 378 of C:/lazarus/source/fpc/2.1/rtl/i nc/astrings.inc $008AE3C7 fpc_ansistr_concat, line 163 of C:/lazarus/source/fpc/2.1/rtl/inc/ astrings.inc $007ECB19 TVERSIONINFO__SETFILENAMES, line 574 of W32VersionInfo.pas $0070B88E TPROJECT__READPROJECT, line 2028 of Project.pp $00671FE7 TMAINIDE__DOOPENPROJECTFILE, line 6862 of Main.pp $00689105 TMAINIDE__SETUPSTARTPROJECT, line 1670 of Main.pp $006898EC TMAINIDE__STARTIDE, line 1113 of Main.pp Vincent _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] VersionInfo - How to set SomethingHasChanged?
On Thu, 07 Sep 2006 16:40:05 +0200 Jouke Rensma [EMAIL PROTECTED] wrote: Hello, So I got things working now! The code is in the enclosed (zipped) patch. I realize it needs some finetuning, but the basic logic does what I had in mind. Now I think it needs some testing, in order to get it ready for the world. Some questions and remarks: - I had to create an extra form for the projectoptions. Can it stay like this or are there other possibilities/ideas? - I created a check for the targetos, so it should not interfere non-win32 systems, but I cannot test that right now. - the rewriting of the .rc file is not protected with try yet. That's my first change... Thanks. Applied. Any other remarks and suggestions are welcome. Project.Modified is a property. You can not give it to a 'var' parameter. It's a compiler bug to allow that. I replaced Project.Modified. Possible improvement: Add a Modified property to the version info. Minors: The lazarus code should have a maximum line length of 80. Try to avoid nested comments. Mattias _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
Re: [lazarus] VersionInfo - How to set SomethingHasChanged? (fwd)
Yes, you must make sure you send them from the address you signed up with. Your From address was different on the first one from the looks of it. On Fri, 2006-09-01 at 18:21 +0200, Jouke Rensma wrote: Somehow I cannot get this mail through. Maybe this one??? -- Forwarded message -- From: [EMAIL PROTECTED] To: lazarus@miraclec.com lazarus@miraclec.com Subject: VersionInfo - How to set SomethingHasChanged? Date: Fri, 01 Sep 2006 13:16:44 +0200 Hi, I'm still working on the VersionInfo and I'm getting closer! This thing I cannot really find how to do: I have some parameters in the ProjectOptions. I want them to be saved in the lpi file. I've added the statements for doing that in the WriteProject routine. This works fine when you click Save or Save All, but how can I force this save on closure (of Lazarus)? I've seen something like SomethingHasChanged, but my guess is that there is a better way... Thanks! Jouke _ To unsubscribe: mail [EMAIL PROTECTED] with unsubscribe as the Subject archives at http://www.lazarus.freepascal.org/mailarchives
