Re: [LEDE-DEV] [PATCH] brcm2708: include upstream bcm2835-rpi-zero DT binary in image

2017-04-13 Thread Álvaro Fernández Rojas 
NACK,

If you want to test something with the alternative device trees then you can 
modify a single line while doing so.

Apart from that there are other alternative device trees for the other models, 
so why only adding the pi-zero one?
I guess because that's the one you're using for testing...

BTW, there's another way of using those alternative device trees without adding 
them to config.txt: using --283x when generating the kernel image:
https://github.com/raspberrypi/linux/blob/rpi-4.9.y/scripts/mkknlimg#L47

El 31/03/2017 a las 22:42, Rafał Miłecki escribió:
> From: Rafał Miłecki 
> 
> This allows easier testing/developing/debugging of upstream DTS file.
> Foundation's start.elf doesn't use it on its own so this won't cause any
> regressions. Testing this DTB requires using U-Boot or adding
> device_tree entry to the config.txt.
> 
> Signed-off-by: Rafał Miłecki 
> ---
>  target/linux/brcm2708/image/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/linux/brcm2708/image/Makefile 
> b/target/linux/brcm2708/image/Makefile
> index 7909c6d814..9c048f5e33 100644
> --- a/target/linux/brcm2708/image/Makefile
> +++ b/target/linux/brcm2708/image/Makefile
> @@ -56,7 +56,7 @@ endef
>  
>  define Device/rpi
>DEVICE_TITLE := Raspberry Pi B/B+/CM/Zero/ZeroW
> -  DEVICE_DTS := bcm2708-rpi-b bcm2708-rpi-b-plus bcm2708-rpi-cm 
> bcm2708-rpi-0-w
> +  DEVICE_DTS := bcm2708-rpi-b bcm2708-rpi-b-plus bcm2708-rpi-cm 
> bcm2708-rpi-0-w bcm2835-rpi-zero
>  endef
>  ifeq ($(SUBTARGET),bcm2708)
>TARGET_DEVICES += rpi
> 

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] brcm2708: include upstream bcm2835-rpi-zero DT binary in image

2017-04-13 Thread Álvaro Fernández Rojas 
Hi Rafał,

Yeah, you're right, but I've been busy with other stuff and I didn't want to 
reply until I had tested your patches.
I will reply now but I haven't been able to test them yet.

Regards,
Álvaro.

El 14/04/2017 a las 0:27, Rafał Miłecki escribió:
> Hi Alvaro,
> 
> On 03/31/2017 10:42 PM, Rafał Miłecki wrote:
>> From: Rafał Miłecki 
>>
>> This allows easier testing/developing/debugging of upstream DTS file.
>> Foundation's start.elf doesn't use it on its own so this won't cause any
>> regressions. Testing this DTB requires using U-Boot or adding
>> device_tree entry to the config.txt.
>>
>> Signed-off-by: Rafał Miłecki 
> 
> I didn't get any response for this or 2 another brcm2708 patches for 2 weeks.
> 
> You are brcm2708 maintainer so I didn't want to push them without your ack but
> I also can't work on brcm2708 having to wait that long every time.
> 
> Would some other solution work for you maybe? Would you be able to provide
> quicker replies or maybe could you give me a green light for pushing brcm2708
> changes on my own?
> 
> Please don't get this question wrong, there is no offence, I'm just looking
> for something that would work well for both of us :)

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [PATCH] brcm2708: include upstream bcm2835-rpi-zero DT binary in image

2017-04-13 Thread Rafał Miłecki 

Hi Alvaro,

On 03/31/2017 10:42 PM, Rafał Miłecki wrote:

From: Rafał Miłecki 

This allows easier testing/developing/debugging of upstream DTS file.
Foundation's start.elf doesn't use it on its own so this won't cause any
regressions. Testing this DTB requires using U-Boot or adding
device_tree entry to the config.txt.

Signed-off-by: Rafał Miłecki 


I didn't get any response for this or 2 another brcm2708 patches for 2 weeks.

You are brcm2708 maintainer so I didn't want to push them without your ack but
I also can't work on brcm2708 having to wait that long every time.

Would some other solution work for you maybe? Would you be able to provide
quicker replies or maybe could you give me a green light for pushing brcm2708
changes on my own?

Please don't get this question wrong, there is no offence, I'm just looking
for something that would work well for both of us :)

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

[LEDE-DEV] [PATCH] brcm2708: include upstream bcm2835-rpi-zero DT binary in image

2017-03-31 Thread Rafał Miłecki 
From: Rafał Miłecki 

This allows easier testing/developing/debugging of upstream DTS file.
Foundation's start.elf doesn't use it on its own so this won't cause any
regressions. Testing this DTB requires using U-Boot or adding
device_tree entry to the config.txt.

Signed-off-by: Rafał Miłecki 
---
 target/linux/brcm2708/image/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/linux/brcm2708/image/Makefile 
b/target/linux/brcm2708/image/Makefile
index 7909c6d814..9c048f5e33 100644
--- a/target/linux/brcm2708/image/Makefile
+++ b/target/linux/brcm2708/image/Makefile
@@ -56,7 +56,7 @@ endef
 
 define Device/rpi
   DEVICE_TITLE := Raspberry Pi B/B+/CM/Zero/ZeroW
-  DEVICE_DTS := bcm2708-rpi-b bcm2708-rpi-b-plus bcm2708-rpi-cm bcm2708-rpi-0-w
+  DEVICE_DTS := bcm2708-rpi-b bcm2708-rpi-b-plus bcm2708-rpi-cm 
bcm2708-rpi-0-w bcm2835-rpi-zero
 endef
 ifeq ($(SUBTARGET),bcm2708)
   TARGET_DEVICES += rpi
-- 
2.11.0


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev