[LEDE-DEV] [PATCH] lantiq: fix console print

2017-01-04 Thread Hauke Mehrtens
The boot loader of many boards provides a kernel boot argument with a
broken console parameter to the kernel. This will be taken before the
stdout-path defined in device tree and the serial will not work on this
board. Multiple boards are affected by this problem, so revert this
patch for all boards. Later we can remove the boot arguments from the
device tree again, after the individual board was checked to work.

This partly reverts this commit:
commit 4995c64857a09c4cc92238ba0bd52cdb06c4c581
Author: Martin Blumenstingl 
Date:   Sun Dec 11 21:55:00 2016 +0100

lantiq: specify console using stdout-path instead of cmdline argument

Signed-off-by: Hauke Mehrtens 
---
 target/linux/lantiq/dts/ACMP252.dts   | 4 
 target/linux/lantiq/dts/ARV4510PW.dts | 4 
 target/linux/lantiq/dts/ARV4518PWR01.dtsi | 4 
 target/linux/lantiq/dts/ARV4519PW.dts | 4 
 target/linux/lantiq/dts/ARV4520PW.dts | 4 
 target/linux/lantiq/dts/ARV452CQW.dts | 4 
 target/linux/lantiq/dts/ARV7510PW22.dts   | 4 
 target/linux/lantiq/dts/ARV7518PW.dts | 4 
 target/linux/lantiq/dts/ARV7519PW.dts | 4 
 target/linux/lantiq/dts/ARV7519RW22.dts   | 4 
 target/linux/lantiq/dts/ARV7525PW.dts | 4 
 target/linux/lantiq/dts/ARV752DPW.dts | 4 
 target/linux/lantiq/dts/ARV752DPW22.dts   | 4 
 target/linux/lantiq/dts/BTHOMEHUBV2B.dts  | 4 
 target/linux/lantiq/dts/BTHOMEHUBV3A.dts  | 4 
 target/linux/lantiq/dts/BTHOMEHUBV5A.dts  | 4 
 target/linux/lantiq/dts/DGN1000B.dts  | 4 
 target/linux/lantiq/dts/DGN3500.dtsi  | 2 +-
 target/linux/lantiq/dts/EASY50712.dts | 4 
 target/linux/lantiq/dts/EASY50810.dts | 4 
 target/linux/lantiq/dts/EASY80920.dtsi| 4 
 target/linux/lantiq/dts/FRITZ3370.dts | 2 +-
 target/linux/lantiq/dts/FRITZ7320.dts | 4 
 target/linux/lantiq/dts/FRITZ7360SL.dts   | 4 
 target/linux/lantiq/dts/GIGASX76X.dts | 4 
 target/linux/lantiq/dts/H201L.dts | 4 
 target/linux/lantiq/dts/P2601HNFX.dts | 4 
 target/linux/lantiq/dts/P2812HNUFX.dtsi   | 4 
 target/linux/lantiq/dts/TDW89X0.dtsi  | 4 
 target/linux/lantiq/dts/VG3503J.dts   | 4 
 target/linux/lantiq/dts/VGV7510KW22.dtsi  | 2 +-
 target/linux/lantiq/dts/VGV7519.dtsi  | 2 +-
 target/linux/lantiq/dts/VR200v.dts| 4 
 target/linux/lantiq/dts/WBMR.dts  | 4 
 target/linux/lantiq/dts/WBMR300.dts   | 4 
 35 files changed, 128 insertions(+), 4 deletions(-)

diff --git a/target/linux/lantiq/dts/ACMP252.dts 
b/target/linux/lantiq/dts/ACMP252.dts
index 50c011acaa..a94014b0f9 100644
--- a/target/linux/lantiq/dts/ACMP252.dts
+++ b/target/linux/lantiq/dts/ACMP252.dts
@@ -5,6 +5,10 @@
 / {
model = "ACMP252 - AudioCodes MediaPack MP-252";
 
+   chosen {
+   bootargs = "console=ttyLTQ0,115200";
+   };
+
memory@0 {
reg = <0x0 0x400>;
};
diff --git a/target/linux/lantiq/dts/ARV4510PW.dts 
b/target/linux/lantiq/dts/ARV4510PW.dts
index 58507672a6..17609e25ba 100644
--- a/target/linux/lantiq/dts/ARV4510PW.dts
+++ b/target/linux/lantiq/dts/ARV4510PW.dts
@@ -7,6 +7,10 @@
 / {
model = "ARV4510PW - Wippies, Elisa";
 
+   chosen {
+   bootargs = "console=ttyLTQ0,115200";
+   };
+
aliases {
led-boot = &power;
led-failsafe = &power2;
diff --git a/target/linux/lantiq/dts/ARV4518PWR01.dtsi 
b/target/linux/lantiq/dts/ARV4518PWR01.dtsi
index c527147e91..8e712bfec6 100644
--- a/target/linux/lantiq/dts/ARV4518PWR01.dtsi
+++ b/target/linux/lantiq/dts/ARV4518PWR01.dtsi
@@ -3,6 +3,10 @@
 #include 
 
 / {
+   chosen {
+   bootargs = "console=ttyLTQ0,115200";
+   };
+
aliases {
led-boot = &power;
led-failsafe = &power;
diff --git a/target/linux/lantiq/dts/ARV4519PW.dts 
b/target/linux/lantiq/dts/ARV4519PW.dts
index fe0f9a7ac4..86c0d48763 100644
--- a/target/linux/lantiq/dts/ARV4519PW.dts
+++ b/target/linux/lantiq/dts/ARV4519PW.dts
@@ -7,6 +7,10 @@
 / {
model = "ARV4519PW - Vodafone Netfaster IAD 2, Pirelli P.RG A4201G";
 
+   chosen {
+   bootargs = "console=ttyLTQ0,115200";
+   };
+
aliases {
led-boot = &power_green;
led-failsafe = &power_red;
diff --git a/target/linux/lantiq/dts/ARV4520PW.dts 
b/target/linux/lantiq/dts/ARV4520PW.dts
index 2ad3a8a080..030e316c87 100644
--- a/target/linux/lantiq/dts/ARV4520PW.dts
+++ b/target/linux/lantiq/dts/ARV4520PW.dts
@@ -7,6 +7,10 @@
 / {
model = "ARV4520PW - Easybox 800, WAV-281";
 
+   chosen {
+   bootargs = "console=ttyLTQ0,115200";
+   };
+
aliases {
led-boot = &power_blue;
led-failsafe = &power_red;
diff --git a/target/linux/lantiq/dts/ARV452CQW.dts 
b/target/linux/lantiq/dts/ARV452CQW.dts
index 8d47b3b7db..6bc0796f9e 100644
--- 

Re: [LEDE-DEV] [PATCH] lantiq: fix console print

2017-01-05 Thread Martin Blumenstingl via Lede-dev
The sender domain has a DMARC Reject/Quarantine policy which disallows
sending mailing list messages using the original "From" header.

To mitigate this problem, the original message has been wrapped
automatically by the mailing list software.--- Begin Message ---
Hi Hauke,

sorry for the late reply - turns out I didn't have time to look into
this all week until now.

On Wed, Jan 4, 2017 at 11:11 PM, Hauke Mehrtens  wrote:
> The boot loader of many boards provides a kernel boot argument with a
> broken console parameter to the kernel. This will be taken before the
> stdout-path defined in device tree and the serial will not work on this
> board. Multiple boards are affected by this problem, so revert this
> patch for all boards. Later we can remove the boot arguments from the
> device tree again, after the individual board was checked to work.
>
> This partly reverts this commit:
> commit 4995c64857a09c4cc92238ba0bd52cdb06c4c581
> Author: Martin Blumenstingl 
> Date:   Sun Dec 11 21:55:00 2016 +0100
>
> lantiq: specify console using stdout-path instead of cmdline argument
nit picking here: your patch actually fixes
6b94234a6598b855573a6516494de8e7d755e944 because I removed the
bootargs in that patch -> the kernel only uses the bootloader's
cmdline if there are no bootargs inside the .dts

your change looks good to me, except for two boards (there might be
more, I don't have access to a computer with a sane operating system
at the momemnt) which are still missing the bootargs:
* ARV4525PW
* ARV8539PW22

both are including danube.dtsi which provided default bootargs for all
danube boards, see [0]
unfortunately I won't be able to send a patch until Sunday (fingers
crossed...), so it'd be awesome if someone else could do this.

thanks for un-breaking things I broke!

Regards,
Martin


[0] 
https://git.lede-project.org/?p=source.git;a=blobdiff;f=target/linux/lantiq/dts/danube.dtsi;h=f11787f9754c9f6d0a04bb100944a53ea6fd;hp=37db51245448fa09eb86fa0e70c1c230833db99a;hb=6b94234a6598b855573a6516494de8e7d755e944;hpb=4995c64857a09c4cc92238ba0bd52cdb06c4c581

--- End Message ---
___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev