Re: [LEDE-DEV] [PATCH v2] kernel: bump to 4.4.39
Hi, i merged Kevin's version from github as it used the sha256sum stuff that Felix recently added. the rest was identical afaict John On 19/12/2016 09:24, Koen Vandeputte wrote: > Hi Stijn S., > > I indeed addressed Stijn Tintel (CC'd him in 1st mail) as he kindly > requested not to send kernel updates until I got familiar enough with > the update process. > As this is my 1st kernel update patch since that day, it would be nice > to have him confirming this one ensuring it's ok now. > > Thanks for testing! > Highly appreciated, > > Koen > > On 2016-12-16 20:02, Stijn Segers wrote: >> Hi Koen, >> >> I pulled your patch (not sure if you were talking about Stijn Tintel >> or me), I am getting whitespace errors: >> >> $ git apply --whitespace=fix >> ../patches/main/0001-Kernel-bump-to-4.4.39.patch >> ../patches/main/0001-Kernel-bump-to-4.4.39.patch:39: trailing whitespace. >> >> ../patches/main/0001-Kernel-bump-to-4.4.39.patch:63: trailing whitespace. >> >> ../patches/main/0001-Kernel-bump-to-4.4.39.patch:86: trailing whitespace. >> >> ../patches/main/0001-Kernel-bump-to-4.4.39.patch:106: trailing >> whitespace. >> >> ../patches/main/0001-Kernel-bump-to-4.4.39.patch:140: space before tab >> in indent. >> >> I think you'll need to fix before the patch gets accepted. >> >> Other than that: >> * Compile-tested on ar71xx / ramips/mt7621 / x86/64. >> * Run-tested on ar71xx / ramips/mt7621. >> >> Tested-by: Stijn Segers >> >> Cheers >> >> Stijn >> > ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2] kernel: bump to 4.4.39
On 2016-12-16 20:02, Stijn Segers wrote: > Hi Koen, > > I pulled your patch (not sure if you were talking about Stijn Tintel or > me), I am getting whitespace errors: > > $ git apply --whitespace=fix > ../patches/main/0001-Kernel-bump-to-4.4.39.patch > ../patches/main/0001-Kernel-bump-to-4.4.39.patch:39: trailing > whitespace. > > ../patches/main/0001-Kernel-bump-to-4.4.39.patch:63: trailing > whitespace. > > ../patches/main/0001-Kernel-bump-to-4.4.39.patch:86: trailing > whitespace. > > ../patches/main/0001-Kernel-bump-to-4.4.39.patch:106: trailing > whitespace. > > ../patches/main/0001-Kernel-bump-to-4.4.39.patch:140: space before tab > in indent. > > I think you'll need to fix before the patch gets accepted. git apply doesn't know about patch files, so it doesn't know that these trailing whitespaces are legitimate (and necessary). - Felix ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
Re: [LEDE-DEV] [PATCH v2] kernel: bump to 4.4.39
Hi Koen, I pulled your patch (not sure if you were talking about Stijn Tintel or me), I am getting whitespace errors: $ git apply --whitespace=fix ../patches/main/0001-Kernel-bump-to-4.4.39.patch ../patches/main/0001-Kernel-bump-to-4.4.39.patch:39: trailing whitespace. ../patches/main/0001-Kernel-bump-to-4.4.39.patch:63: trailing whitespace. ../patches/main/0001-Kernel-bump-to-4.4.39.patch:86: trailing whitespace. ../patches/main/0001-Kernel-bump-to-4.4.39.patch:106: trailing whitespace. ../patches/main/0001-Kernel-bump-to-4.4.39.patch:140: space before tab in indent. I think you'll need to fix before the patch gets accepted. Other than that: * Compile-tested on ar71xx / ramips/mt7621 / x86/64. * Run-tested on ar71xx / ramips/mt7621. Tested-by: Stijn Segers Cheers Stijn ___ Lede-dev mailing list Lede-dev@lists.infradead.org http://lists.infradead.org/mailman/listinfo/lede-dev
