Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-22 Thread Russell Senior 
> "Syrone" == Syrone Wong  writes:

Syrone> either runtime dependency ``` DEPENDS:=+kmod-sched-core
Syrone> +iptables ```

Syrone> or build-time dependency

Syrone> ``` PKG_BUILD_DEPENDS:=iptables ```

Syrone> Don't add both of them.

That does not fix the problem.  With the runtime dependency and without
the BUILD_DEPENDS, I still get:

$ make defconfig
Collecting package info: done
tmp/.config-package.in:53710:error: recursive dependency detected!
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
tmp/.config-package.in:53710:   symbol PACKAGE_iptables is selected by 
PACKAGE_tc
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
tmp/.config-package.in:59483:   symbol PACKAGE_tc is selected by 
PACKAGE_luci-app-splash
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
tmp/.config-package.in:35320:   symbol PACKAGE_luci-app-splash is selected by 
PACKAGE_luci-mod-freifunk-community
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
tmp/.config-package.in:34418:   symbol PACKAGE_luci-mod-freifunk-community 
depends on PACKAGE_firewall
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
tmp/.config-package.in:246: symbol PACKAGE_firewall is selected by 
PACKAGE_luci-app-firewall
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
tmp/.config-package.in:34775:   symbol PACKAGE_luci-app-firewall is selected by 
PACKAGE_luci-app-p2pblock
For a resolution refer to Documentation/kbuild/kconfig-language.txt
subsection "Kconfig recursive dependency limitations"
tmp/.config-package.in:35066:   symbol PACKAGE_luci-app-p2pblock depends on 
PACKAGE_iptables
#
# configuration written to .config
#

Documentation/kbuild/kconfig-language.txt (from the kernel tree)
suggests changing all the dependencies to either "selected by" or
"depends on".  That would seem to mean touching the luci packages.


-- 
Russell Senior, President
russ...@personaltelco.net

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-22 Thread Syrone Wong 
either runtime dependency

```
DEPENDS:=+kmod-sched-core +iptables
```

or build-time dependency

```
PKG_BUILD_DEPENDS:=iptables
```

Don't add both of them.

Best Regards,
Syrone Wong


On Wed, Mar 22, 2017 at 2:53 PM, Russell Senior
 wrote:
>> "Russell" == Russell Senior  writes:
>
>> "Syrone" == Syrone Wong  writes:
> Syrone> It seems this chunk is redundant - DEPENDS:=+kmod-sched-core +
> Syrone> DEPENDS:=+kmod-sched-core iptables
>
> Syrone> If you really want to add iptables as runtime dependency, it
> Syrone> should be `+iptables`.
>
> Russell> Syrone, afaict, tc dlopen()'s iptables .so's, which implies
> Russell> that iptables is needed at runtime, at least to support the
> Russell> associated features.
>
> Russell> I didn't get circular dependency problems with this either.
>
> Argh.  Yes I did.
>
> $ make defconfig
> Collecting package info: done
> tmp/.config-package.in:53710:error: recursive dependency detected!
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> tmp/.config-package.in:53710:   symbol PACKAGE_iptables is selected by 
> PACKAGE_tc
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> tmp/.config-package.in:59483:   symbol PACKAGE_tc is selected by 
> PACKAGE_luci-app-splash
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> tmp/.config-package.in:35320:   symbol PACKAGE_luci-app-splash is selected by 
> PACKAGE_luci-mod-freifunk-community
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
> subsection "Kconfig recursive dependency limitations"
> tmp/.config-package.in:34418:   symbol PACKAGE_luci-mod-freifunk-community 
> depends on PACKAGE_iptables
> #
> # configuration written to .config
> #
>
>
> Suggestions?
>
>
> --
> Russell Senior, President
> russ...@personaltelco.net

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-21 Thread Russell Senior 
> "Syrone" == Syrone Wong  writes:

Syrone> It seems this chunk is redundant - DEPENDS:=+kmod-sched-core +
Syrone> DEPENDS:=+kmod-sched-core iptables

Syrone> If you really want to add iptables as runtime dependency, it
Syrone> should be `+iptables`.

Syrone, afaict, tc dlopen()'s iptables .so's, which implies that
iptables is needed at runtime, at least to support the associated
features.

I didn't get circular dependency problems with this either.

Please test:

diff --git a/package/network/utils/iproute2/Makefile 
b/package/network/utils/iproute2/Makefile
index 65ae5cb457..17f28f0d16 100644
--- a/package/network/utils/iproute2/Makefile
+++ b/package/network/utils/iproute2/Makefile
@@ -19,6 +19,7 @@ PKG_BUILD_PARALLEL:=1
 PKG_LICENSE:=GPL-2.0
 
 
PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(BUILD_VARIANT)/$(PKG_NAME)-$(PKG_VERSION)
+PKG_BUILD_DEPENDS:=iptables
 
 include $(INCLUDE_DIR)/package.mk
 
@@ -44,7 +45,7 @@ Package/ip-full:=$(call Package/iproute2/Default,full,Full,ip)
 define Package/tc
 $(call Package/iproute2/Default)
   TITLE:=Traffic control utility
-  DEPENDS:=+kmod-sched-core
+  DEPENDS:=+kmod-sched-core +iptables
 endef
 
 define Package/genl


-- 
Russell Senior, President
russ...@personaltelco.net

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-21 Thread Russell Senior 
> "Russell" == Russell Senior  writes:

Please test:

diff --git a/package/network/utils/iproute2/Makefile 
b/package/network/utils/iproute2/Makefile
index 65ae5cb457..3a4b114039 100644
--- a/package/network/utils/iproute2/Makefile
+++ b/package/network/utils/iproute2/Makefile
@@ -19,6 +19,7 @@ PKG_BUILD_PARALLEL:=1
 PKG_LICENSE:=GPL-2.0
 
 
PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(BUILD_VARIANT)/$(PKG_NAME)-$(PKG_VERSION)
+PKG_BUILD_DEPENDS:=iptables
 
 include $(INCLUDE_DIR)/package.mk
 
@@ -44,7 +45,7 @@ Package/ip-full:=$(call Package/iproute2/Default,full,Full,ip)
 define Package/tc
 $(call Package/iproute2/Default)
   TITLE:=Traffic control utility
-  DEPENDS:=+kmod-sched-core
+  DEPENDS:=+kmod-sched-core iptables
 endef
 
 define Package/genl


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-21 Thread Yousong Zhou 
On 21 March 2017 at 03:54, Russell Senior  wrote:
> The new ip-tiny ipk is 20k bigger than the old version (~79k vs ~100k).
> There may be some additional pruning possible to get it back down to a
> similar size.

It will be really nice if the size can be squeezed for at least the
ip-tiny package.  Are you already working on this?

The other thing is that adding iptables as a build dependency should
be the way to go if only header files of that packages are needed to
build iproute2.

Regards,
yousong

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-20 Thread Russell Senior 
> "Russell" == Russell Senior  writes:

> "Russell" == Russell Senior  writes:
Russell> There may also be a missing depends.  I had temporary -j16
Russell> build failures due to a missing iptables header file.
Russell> Restarting worked, presumably because the header had by then
Russell> appeared where expected.  I am not sure what, exactly, was
Russell> providing the header.

Russell> ../include/xtables.h:34:29: fatal error: xtables-version.h: No
Russell> such file or directory

Russell> This seems to fix the missing header problem.

The last version's @@ line got wrapped.  This version should apply as a patch.

diff --git a/package/network/utils/iproute2/Makefile 
b/package/network/utils/iproute2/Makefile
index 65ae5cb457..a561b0b5af 100644
--- a/package/network/utils/iproute2/Makefile
+++ b/package/network/utils/iproute2/Makefile
@@ -44,7 +44,7 @@ Package/ip-full:=$(call Package/iproute2/Default,full,Full,ip)
 define Package/tc
 $(call Package/iproute2/Default)
   TITLE:=Traffic control utility
-  DEPENDS:=+kmod-sched-core
+  DEPENDS:=+kmod-sched-core +iptables
 endef
 
 define Package/genl


-- 
Russell Senior, President
russ...@personaltelco.net

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-20 Thread Russell Senior 
> "Russell" == Russell Senior  writes:

Russell> There may also be a missing depends.  I had temporary -j16
Russell> build failures due to a missing iptables header file.
Russell> Restarting worked, presumably because the header had by then
Russell> appeared where expected.  I am not sure what, exactly, was
Russell> providing the header.

Russell> ../include/xtables.h:34:29: fatal error: xtables-version.h: No
Russell> such file or directory

This seems to fix the missing header problem.

diff --git a/package/network/utils/iproute2/Makefile 
b/package/network/utils/iproute2/Makefile
index 65ae5cb457..a561b0b5af 100644
--- a/package/network/utils/iproute2/Makefile
+++ b/package/network/utils/iproute2/Makefile
@@ -44,7 +44,7 @@ Package/ip-full:=$(call
Package/iproute2/Default,full,Full,ip)
 define Package/tc
 $(call Package/iproute2/Default)
   TITLE:=Traffic control utility
-  DEPENDS:=+kmod-sched-core
+  DEPENDS:=+kmod-sched-core +iptables
 endef
 
 define Package/genl



-- 
Russell Senior, President
russ...@personaltelco.net

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-20 Thread Syrone Wong 
My solution is to disable parallel build and make iptables as build dependency.

PKG_BUILD_PARALLEL:=0
PKG_BUILD_DEPENDS:=iptables

BTW, iproute2 doesn't honor COPTS correctly, I fixed this by reordering flags.

more detail can be found here:

https://github.com/wongsyrone/lede-1/commit/1d75df6a16ce98fa20bb84ba88c0004ceb89e987
https://github.com/wongsyrone/lede-1/commit/32d516646d6bcba2b7aeb2d3d692944070cbe58b

Best Regards,
Syrone Wong


On Tue, Mar 21, 2017 at 7:51 AM, Russell Senior
 wrote:
>> "Russell" == Russell Senior  writes:
>
>> "Kevin" == Kevin Darbyshire-Bryant  
>> writes:
> Kevin> On 20/03/17 12:35, Yousong Zhou wrote:
 On 19 March 2017 at 20:38, Russell Senior  
 wrote:
>
> Thanks to Syrone Wong  for the pointer to
> UAPI fixes.  This builds now, at least on x86/geode.  It would be
> nice to have some testing.
>
> Signed-off-by: Russell Senior  ---

 Tested-by: Yousong Zhou 

 CC jogo, can we have these two patches in generic dir (271, 272)
 upstreamed?

 Regards, yousong
>
> Kevin> Was this tested on a 4.4 kernel?  When I tried it wouldn't
> Kevin> compile (but it was a quick 5 seconds before I had to run out the
> Kevin> door type test, so I could have done summit stooopid)
>
> Russell> I tested ip-tiny on a Buffalo WZR600DHP (ar71xx):
>
> Russell> root@hostname:/# uname -a Linux hostname 4.4.53 #0 Sun Mar 19
> Russell> 12:42:50 2017 mips GNU/Linux root@hostname:/# ip -V ip utility,
> Russell> iproute2-ss4.10.0-1-lede
>
> Russell> The new ip-tiny ipk is 20k bigger than the old version (~79k vs
> Russell> ~100k).  There may be some additional pruning possible to get
> Russell> it back down to a similar size.
>
> There may also be a missing depends.  I had temporary -j16 build
> failures due to a missing iptables header file.  Restarting worked,
> presumably because the header had by then appeared where expected.  I am
> not sure what, exactly, was providing the header.
>
> ../include/xtables.h:34:29: fatal error: xtables-version.h: No such file or 
> directory
>
>
> --
> Russell Senior, President
> russ...@personaltelco.net
>
> ___
> Lede-dev mailing list
> Lede-dev@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/lede-dev

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-20 Thread Russell Senior 
> "Russell" == Russell Senior  writes:

> "Kevin" == Kevin Darbyshire-Bryant  writes:
Kevin> On 20/03/17 12:35, Yousong Zhou wrote:
>>> On 19 March 2017 at 20:38, Russell Senior  wrote:
 
 Thanks to Syrone Wong  for the pointer to
 UAPI fixes.  This builds now, at least on x86/geode.  It would be
 nice to have some testing.
 
 Signed-off-by: Russell Senior  ---
>>> 
>>> Tested-by: Yousong Zhou 
>>> 
>>> CC jogo, can we have these two patches in generic dir (271, 272)
>>> upstreamed?
>>> 
>>> Regards, yousong

Kevin> Was this tested on a 4.4 kernel?  When I tried it wouldn't
Kevin> compile (but it was a quick 5 seconds before I had to run out the
Kevin> door type test, so I could have done summit stooopid)

Russell> I tested ip-tiny on a Buffalo WZR600DHP (ar71xx):

Russell> root@hostname:/# uname -a Linux hostname 4.4.53 #0 Sun Mar 19
Russell> 12:42:50 2017 mips GNU/Linux root@hostname:/# ip -V ip utility,
Russell> iproute2-ss4.10.0-1-lede

Russell> The new ip-tiny ipk is 20k bigger than the old version (~79k vs
Russell> ~100k).  There may be some additional pruning possible to get
Russell> it back down to a similar size.

There may also be a missing depends.  I had temporary -j16 build
failures due to a missing iptables header file.  Restarting worked,
presumably because the header had by then appeared where expected.  I am
not sure what, exactly, was providing the header.

../include/xtables.h:34:29: fatal error: xtables-version.h: No such file or 
directory


-- 
Russell Senior, President
russ...@personaltelco.net

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-20 Thread Kevin Darbyshire-Bryant 



On 20/03/17 19:54, Russell Senior wrote:



Kevin> Was this tested on a 4.4 kernel?  When I tried it wouldn't
Kevin> compile (but it was a quick 5 seconds before I had to run out the
Kevin> door type test, so I could have done summit stooopid)

I tested ip-tiny on a Buffalo WZR600DHP (ar71xx):

root@hostname:/# uname -a
Linux hostname 4.4.53 #0 Sun Mar 19 12:42:50 2017 mips GNU/Linux
root@hostname:/# ip -V
ip utility, iproute2-ss4.10.0-1-lede

The new ip-tiny ipk is 20k bigger than the old version (~79k vs ~100k).
There may be some additional pruning possible to get it back down to a
similar size.


As I suspected, I was doing something stoopid - managed to get a build 
out & running on an Archer C7.  :-)


Apologies for the noise.  Good to have iproute up to date :-)

Kevin

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-20 Thread Russell Senior 
> "Kevin" == Kevin Darbyshire-Bryant  writes:

Kevin> On 20/03/17 12:35, Yousong Zhou wrote:
>> On 19 March 2017 at 20:38, Russell Senior  wrote:
>>> 
>>> Thanks to Syrone Wong  for the pointer to
>>> UAPI fixes.  This builds now, at least on x86/geode.  It would be
>>> nice to have some testing.
>>> 
>>> Signed-off-by: Russell Senior  ---
>> 
>> Tested-by: Yousong Zhou 
>> 
>> CC jogo, can we have these two patches in generic dir (271, 272)
>> upstreamed?
>> 
>> Regards, yousong

Kevin> Was this tested on a 4.4 kernel?  When I tried it wouldn't
Kevin> compile (but it was a quick 5 seconds before I had to run out the
Kevin> door type test, so I could have done summit stooopid)

I tested ip-tiny on a Buffalo WZR600DHP (ar71xx):

root@hostname:/# uname -a
Linux hostname 4.4.53 #0 Sun Mar 19 12:42:50 2017 mips GNU/Linux
root@hostname:/# ip -V
ip utility, iproute2-ss4.10.0-1-lede

The new ip-tiny ipk is 20k bigger than the old version (~79k vs ~100k).
There may be some additional pruning possible to get it back down to a
similar size.


-- 
Russell Senior, President
russ...@personaltelco.net

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-20 Thread Kevin Darbyshire-Bryant 



On 20/03/17 12:35, Yousong Zhou wrote:

On 19 March 2017 at 20:38, Russell Senior  wrote:


Thanks to Syrone Wong  for the pointer to UAPI
fixes.  This builds now, at least on x86/geode.  It would be nice to
have some testing.

Signed-off-by: Russell Senior 
---


Tested-by: Yousong Zhou 

CC jogo, can we have these two patches in generic dir (271, 272) upstreamed?

Regards,
   yousong


Was this tested on a 4.4 kernel?  When I tried it wouldn't compile (but 
it was a quick 5 seconds before I had to run out the door type test, so 
I could have done summit stooopid)


___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev

Re: [LEDE-DEV] [RFC] iproute2: update to v4.10.0

2017-03-20 Thread Yousong Zhou 
On 19 March 2017 at 20:38, Russell Senior  wrote:
>
> Thanks to Syrone Wong  for the pointer to UAPI
> fixes.  This builds now, at least on x86/geode.  It would be nice to
> have some testing.
>
> Signed-off-by: Russell Senior 
> ---

Tested-by: Yousong Zhou 

CC jogo, can we have these two patches in generic dir (271, 272) upstreamed?

Regards,
   yousong

___
Lede-dev mailing list
Lede-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/lede-dev