Re: Support for Qt5 has begun

['Terry Brown' via leo-editor]

On Fri, 27 Jun 2014 09:24:03 -0700 (PDT)
Edward K. Ream edream...@gmail.com wrote:

 On Friday, June 27, 2014 11:17:01 AM UTC-5, Edward K. Ream wrote:
 
 
  Just added an event arg (the first arg) for several clicked 
  callbacks.  The find buttons now work again ;-) 
 
  I'll do the same for triggered next.
 
 
 Done at the latest rev.  However, some callbacks are defined using
 lambda. I didn't change these and some of them (detach tab, for
 instance) appear to work.
 
 Terry, when you get a chance, please review all the triggered
 callbacks. Thanks.

I've made a note.

I think it's generally a bool 'checked' arg. rather than the event
object that's passed in these cases, e.g.:
http://qt-project.org/doc/qt-5/qabstractbutton.html#clicked
but that doesn't stop adding an arg. named 'event' fixing things.

I think the lambda cases are either more robust or will produce a
runtime error more convincingly, but I'll have a look at them.

Of course the problem would never have arisen if Qt wasn't also trying
to support legacy languages like C++  ;-)  (kidding).

Cheers -Terry

-- 
You received this message because you are subscribed to the Google Groups 
leo-editor group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at http://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.

Re: problems with the minibuffer

['Terry Brown' via leo-editor]

On Sat, 28 Jun 2014 07:47:24 -0500
Edward K. Ream edream...@gmail.com wrote:

 On Fri, Jun 27, 2014 at 6:07 AM, Zoltan Benedek benzol...@gmail.com
 wrote:
  Hi,
 
  Recently I've tried some commands in the minibuffer and got some
  problems:
 
 These have been fixed at rev ba20f6dbaa86.  They were introduced June
 20 at rev 288847b40e3.
 
 I'm glad this bug happened.  To find it, I had to zero in on the
 offending rev using a divide  conquer strategy.  This is super easy
 to do using git checkout.  Once I could see the buggy code, it was

Heh - read the docs. for `git bisect` :-)  Doesn't get easier than that
(although I've used it with an invalid bug test, doesn't work well
then :-)

Cheers -Terry

 obvious what the fix was.  My usual strategy of tracing the flow of
 focus-related calls did not work in this case.
 
 Edward
 

-- 
You received this message because you are subscribed to the Google Groups 
leo-editor group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To post to this group, send email to leo-editor@googlegroups.com.
Visit this group at http://groups.google.com/group/leo-editor.
For more options, visit https://groups.google.com/d/optout.