Re: PR #3286 merged into devel. Please continue testing

[Edward K. Ream]

On Tue, Apr 18, 2023 at 12:03 PM Thomas Passin  wrote:

> This whole exercise puts me in mind of the several levels of testing:
> unit, integration, and system.  Unit tests can only take you so far.  In
> the case of these os.path-like functions, a unit test could prove that the
> output equals the intended output, but it could not show that all consuming
> modules expect the function to act that way.
>

Yes. And this exercise shows the limits of waiting for approving reviews of
PRs, hehe.

I think our travails were worthwhile. The new code, and the new names, are
better.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/CAMF8tS1HtnHiPxE1HosFucGH6UkAjXOyhqXwuZ66kACmpMRMDQ%40mail.gmail.com.

Re: PR #3286 merged into devel. Please continue testing

[Thomas Passin]

This whole exercise puts me in mind of the several levels of testing: unit, 
integration, and system.  Unit tests can only take you so far.  In the case 
of these os.path-like functions, a unit test could prove that the output 
equals the intended output, but it could not show that all consuming 
modules expect the function to act that way.

On Tuesday, April 18, 2023 at 12:58:46 PM UTC-4 Thomas Passin wrote:

> g.os_path_join() is still doing the right thing on my system.
>
> On Tuesday, April 18, 2023 at 12:34:10 PM UTC-4 Edward K. Ream wrote:
>
>> On Tuesday, April 18, 2023 at 11:10:29 AM UTC-5 Edward K. Ream wrote:
>>
>> I've made copies of the g.os_path_expanduser and g.os_path_join as they 
>> existed in Leo 6.7.2.  We can't go back to the exact legacy code, but I'll 
>> take yet another look after I take a break.
>>
>>
>> As of rev ca92d1f 
>> 
>>  
>> in devel, g.os_path_expanduser calls os.path.normpath, as in Leo 6.7.2.
>>
>> This change should ensure that all legacy scripts and plugins work 
>> exactly as before.
>>
>> As always, please report any problems.
>>
>> Edward
>>
>> P.S. g.os_path_join needs no further changes. It should be exactly 
>> equivalent to the legacy version.
>>
>> EKR
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/29ec3f4a-2dba-45c2-bbc1-ea7d3575d059n%40googlegroups.com.

Re: PR #3286 merged into devel. Please continue testing

[Thomas Passin]

g.os_path_join() is still doing the right thing on my system.

On Tuesday, April 18, 2023 at 12:34:10 PM UTC-4 Edward K. Ream wrote:

> On Tuesday, April 18, 2023 at 11:10:29 AM UTC-5 Edward K. Ream wrote:
>
> I've made copies of the g.os_path_expanduser and g.os_path_join as they 
> existed in Leo 6.7.2.  We can't go back to the exact legacy code, but I'll 
> take yet another look after I take a break.
>
>
> As of rev ca92d1f 
> 
>  
> in devel, g.os_path_expanduser calls os.path.normpath, as in Leo 6.7.2.
>
> This change should ensure that all legacy scripts and plugins work exactly 
> as before.
>
> As always, please report any problems.
>
> Edward
>
> P.S. g.os_path_join needs no further changes. It should be exactly 
> equivalent to the legacy version.
>
> EKR
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/f16ae801-016c-4530-84f7-3a6e5e0f6722n%40googlegroups.com.

Re: PR #3286 merged into devel. Please continue testing

[Edward K. Ream]

On Tuesday, April 18, 2023 at 11:10:29 AM UTC-5 Edward K. Ream wrote:

I've made copies of the g.os_path_expanduser and g.os_path_join as they 
existed in Leo 6.7.2.  We can't go back to the exact legacy code, but I'll 
take yet another look after I take a break.


As of rev ca92d1f 

 
in devel, g.os_path_expanduser calls os.path.normpath, as in Leo 6.7.2.

This change should ensure that all legacy scripts and plugins work exactly 
as before.

As always, please report any problems.

Edward

P.S. g.os_path_join needs no further changes. It should be exactly 
equivalent to the legacy version.

EKR

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/0ce8b161-41b8-4936-ae4f-21cf46b4855an%40googlegroups.com.

Re: PR #3286 merged into devel. Please continue testing

[Edward K. Ream]

On Tue, Apr 18, 2023 at 11:02 AM Thomas Passin  wrote:

> This has fixed the g.os_path_join() problem.
>

Whew.  Thanks for the testing.

I've made copies of the g.os_path_expanduser and g.os_path_join as they
existed in Leo 6.7.2.  We can't go back to the exact legacy code, but I'll
take yet another look after I take a break.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/CAMF8tS2tLovJ-Ra_VBCv3YOQn_Ci1NYoy58OFsUDfsgO%2B%2B6E9Q%40mail.gmail.com.

Re: PR #3286 merged into devel. Please continue testing

[Thomas Passin]

This has fixed the g.os_path_join() problem.

On Tuesday, April 18, 2023 at 11:50:23 AM UTC-4 Edward K. Ream wrote:

> On Tuesday, April 18, 2023 at 10:46:39 AM UTC-5 Edward K. Ream wrote:
>
> PR #3286  is now in 
> devel. It restores some legacy functions and fixes a missing alias.
>
> Please continue testing. The latest code fixes several brain spikes on my 
> part, but more problems may remain.
>
>
> Meh.  g.os_path_expanduser does *not* (now) finalize its result. That may 
> be wrong, but I can't be sure yet.
>
> Edward
>

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/cbe41ce9-7de5-4796-9ed6-0a3984b080ean%40googlegroups.com.

Re: PR #3286 merged into devel. Please continue testing

[Edward K. Ream]

On Tuesday, April 18, 2023 at 10:46:39 AM UTC-5 Edward K. Ream wrote:

PR #3286  is now in 
devel. It restores some legacy functions and fixes a missing alias.

Please continue testing. The latest code fixes several brain spikes on my 
part, but more problems may remain.


Meh.  g.os_path_expanduser does *not* (now) finalize its result. That may 
be wrong, but I can't be sure yet.

Edward

-- 
You received this message because you are subscribed to the Google Groups 
"leo-editor" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to leo-editor+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/leo-editor/16ed0c8a-38c3-44ec-bb34-439cda518c9an%40googlegroups.com.