Re: [lftp-devel] lftp snapshot 20150401 is available

2015-04-01 Thread Jeroen Roovers 
On Wed, 1 Apr 2015 15:51:25 +0300
Alexander V. Lukyanov l...@netis.ru wrote:

 http://lftp.yar.ru/ftp/devel/lftp-4.6.1.20150401.tar.gz
 Please test.

The linker complains:

/bin/bash ../libtool --silent  --tag=CXX   --mode=link
x86_64-pc-linux-gnu-g++  -frecord-gcc-switches -g -pipe -O2 -Wall
-Wformat=2 -march=core2 -Wall -Wwrite-strings -Woverloaded-virtual
-fno-exceptions -fno-rtti -fno-implement-inlines  -Wl,-O1
-Wl,--hash-style=gnu -Wl,--as-needed -L/usr/lib -o lftp lftp.o
complete.o lftp_rl.o attach.o liblftp-jobs.la -lreadline -lutil -ltinfo
-ldl -lidn
lftp-4.6.1.20150401/src/.libs/liblftp-tasks.so: undefined reference to
`is_ipv6_address(char const*)'
collect2: error: ld returned 1 exit status


Regards,
  jer
___
lftp-devel mailing list
lftp-devel@uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp-devel

Re: [lftp-devel] lftp snapshot 20150401 is available

2015-04-01 Thread Jeroen Roovers 
On Wed, 1 Apr 2015 17:58:12 +0200
Jeroen Roovers j...@gentoo.org wrote:

 On Wed, 1 Apr 2015 15:51:25 +0300
 Alexander V. Lukyanov l...@netis.ru wrote:
 
  http://lftp.yar.ru/ftp/devel/lftp-4.6.1.20150401.tar.gz
  Please test.
 
 The linker complains:
 
 /bin/bash ../libtool --silent  --tag=CXX   --mode=link
 x86_64-pc-linux-gnu-g++  -frecord-gcc-switches -g -pipe -O2 -Wall
 -Wformat=2 -march=core2 -Wall -Wwrite-strings -Woverloaded-virtual
 -fno-exceptions -fno-rtti -fno-implement-inlines  -Wl,-O1
 -Wl,--hash-style=gnu -Wl,--as-needed -L/usr/lib -o lftp lftp.o
 complete.o lftp_rl.o attach.o liblftp-jobs.la -lreadline -lutil
 -ltinfo -ldl -lidn
 lftp-4.6.1.20150401/src/.libs/liblftp-tasks.so: undefined reference to
 `is_ipv6_address(char const*)'
 collect2: error: ld returned 1 exit status

Would this be a sane solution?

--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -82,7 +82,7 @@
  IdNameCache.h PatternSet.cc PatternSet.h LocalDir.cc LocalDir.h
 liblftp_tasks_la_LIBADD = $(TASK_MODULES_STATIC) $(TRIO) $(GNULIB)\
  $(LIB_CRYPTO) $(INET_PTON_LIB) $(LIB_CLOCK_GETTIME) $(SOCKSLIBS)\
- $(LIBSOCKET) $(LIB_POLL) $(LIB_SELECT) $(LTLIBINTL) $(LTLIBICONV)
+ $(LIBSOCKET) $(LIB_POLL) $(LIB_SELECT) $(LTLIBINTL) $(LTLIBICONV)
liblftp-network.la

 liblftp_jobs_la_SOURCES = Job.cc Job.h CmdExec.cc CmdExec.h\
  commands.cc mgetJob.h mgetJob.cc SysCmdJob.cc SysCmdJob.h rmJob.cc
  rmJob.h\

 
Regards,
  jer--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -82,7 +82,7 @@
  IdNameCache.h PatternSet.cc PatternSet.h LocalDir.cc LocalDir.h
 liblftp_tasks_la_LIBADD = $(TASK_MODULES_STATIC) $(TRIO) $(GNULIB)\
  $(LIB_CRYPTO) $(INET_PTON_LIB) $(LIB_CLOCK_GETTIME) $(SOCKSLIBS)\
- $(LIBSOCKET) $(LIB_POLL) $(LIB_SELECT) $(LTLIBINTL) $(LTLIBICONV)
+ $(LIBSOCKET) $(LIB_POLL) $(LIB_SELECT) $(LTLIBINTL) $(LTLIBICONV) 
liblftp-network.la
 
 liblftp_jobs_la_SOURCES = Job.cc Job.h CmdExec.cc CmdExec.h\
  commands.cc mgetJob.h mgetJob.cc SysCmdJob.cc SysCmdJob.h rmJob.cc rmJob.h\
___
lftp-devel mailing list
lftp-devel@uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp-devel

Re: [lftp] lftp 4.5.6 (stable) and 4.6.0

2014-10-14 Thread Jeroen Roovers 
On Tue, 14 Oct 2014 14:14:26 +0200
Juan Simón deced...@gmail.com wrote:

 Without '--with-modules' fails too.
 
 And without any flag in './configure' fails compilation too in another
 point:
 Making all in m4
 Making all in doc
 Making all in lib
 Making all in src
 lftp_ssl.cc: In member function 'int lftp_ssl_gnutls::read(char*,
 int)': lftp_ssl.cc:563:62: error: 'GNUTLS_E_PREMATURE_TERMINATION'
 was not declared in this scope
else if(res==GNUTLS_E_UNEXPECTED_PACKET_LENGTH ||
 res==GNUTLS_E_PREMATURE_TERMINATION)

https://github.com/lavv17/lftp/pull/97


 jer

___
lftp mailing list
lftp@uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp

Re: [lftp] lftp 4.5.5

2014-09-04 Thread Jeroen Roovers 
On Thu, 4 Sep 2014 14:25:18 +0200
Juan Simón deced...@gmail.com wrote:

 ftpclass.cc: In destructor 'Ftp::Connection::~Connection()':
 ftpclass.cc:1074:15: error: lvalue required as left operand of
 assignment control_ssl=0; // ssl should be freed after send/recv
^
 make[1]: *** [ftpclass.lo] Error 1
 make[1]: *** Se espera a que terminen otras tareas
 make: *** [all-recursive] Error 1

Patch attached.


Regards,
 jer
--- a/src/ftpclass.cc
+++ b/src/ftpclass.cc
@@ -1071,7 +1071,9 @@
 
control_send=0;
control_recv=0;
+#if USE_SSL
control_ssl=0; // ssl should be freed after send/recv
+#endif
 
if(control_sock!=-1)
{
___
lftp mailing list
lftp@uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp

[lftp] [PATCH] Fix building against GNU libc 2.16 (gets undefined)

2012-08-09 Thread Jeroen Roovers 
Martin Jansa reported[1] a bug compiling lftp against GNU libc 2.16. The
code assumes gets is defined when in 2.16 it is not. The attached
patch adds the necessary check.


 jer


[1] https://bugs.gentoo.org/show_bug.cgi?id=425026--- a/lib/stdio.in.h
+++ b/lib/stdio.in.h
@@ -702,10 +702,12 @@
 /* It is very rare that the developer ever has full control of stdin,
so any use of gets warrants an unconditional warning; besides, C11
removed it.  */
+#ifdef gets
 #undef gets
 #if HAVE_RAW_DECL_GETS
 _GL_WARN_ON_USE (gets, gets is a security hole - use fgets instead);
 #endif
+#endif
 
 
 #if @GNULIB_OBSTACK_PRINTF@ || @GNULIB_OBSTACK_PRINTF_POSIX@
___
lftp mailing list
lftp@uniyar.ac.ru
http://univ.uniyar.ac.ru/mailman/listinfo/lftp

autoconf 2.64 patch

2009-11-21 Thread Jeroen Roovers 
Gentoo bug #293958 [1] details a patch to fix building with autoconf
version 2.64.


Regards,
 jer


[1]  https://bugs.gentoo.org/show_bug.cgi?id=293958--- configure.ac-old	2009-10-16 18:44:26.0 +0200
+++ configure.ac	2009-11-21 15:09:58.0 +0100
@@ -255,7 +255,7 @@
 AC_ARG_WITH(gnutls, AS_HELP_STRING([--without-gnutls], [don't use GNUTLS library]),
   [with_gnutls=$withval], [with_gnutls=yes])
 AC_ARG_WITH(openssl,
-AS_HELP_STRING([--with-openssl[[=/path]]], [use OpenSSL [at /path]])
+AS_HELP_STRING([--with-openssl@:@=/path@:@], [use OpenSSL @:@at /path@:@])
 AS_HELP_STRING([--without-openssl], [don't use OpenSSL (default)]),
   [with_openssl=$withval], [with_openssl=no])
 case $with_openssl in

Re: liblftp-{tasks,jobs}.la dependencies do no exist [PATCH]

2009-10-14 Thread Jeroen Roovers 
I sent this reply or something similar earlier but gmane or
mail-archive apparently sent it to /dev/null instead.


On Mon, 21 Sep 2009 17:43:31 +0200
Markus Rothe mar...@unixforces.net wrote:

 The result is that /usr/lib64/liblftp-tasks.{a,la} and
 /usr/lib64/liblftp-jobs.{a,la} are installed. The .la files depend on
 the following files, which are not installed:

Patch attached.

 Another problem is that there is an empty directory being created if
 lftp is compiled without the --build-modules option: /usr/lib64/lftp/

Don't know about that one.


Regards,
 jer--- lftp-4.0.2.91.orig/src/Makefile.am	2009-07-29 08:29:10.0 +0200
+++ lftp-4.0.2.91/src/Makefile.am	2009-10-13 18:32:26.0 +0200
@@ -18,7 +18,8 @@
 example_module1_la_SOURCES = example-module1.cc
 example_module1_la_LDFLAGS  = -module -avoid-version -rpath $(pkgverlibdir)
 
-TASK_MODULES = liblftp-pty.la liblftp-network.la proto-ftp.la proto-http.la proto-file.la proto-fish.la proto-sftp.la
+TASK_MODULES = liblftp-pty.la liblftp-network.la proto-ftp.la proto-http.la proto-file.la proto-fish.la proto-sftp.la liblftp-tasks.la liblftp-jobs.la
+
 JOB_MODULES = cmd-mirror.la cmd-sleep.la cmd-torrent.la
 if WITH_MODULES
   pkgverlib_LTLIBRARIES = $(TASK_MODULES) $(JOB_MODULES)
@@ -26,8 +27,6 @@
   TASK_MODULES_STATIC = $(TASK_MODULES)
   JOB_MODULES_STATIC = $(JOB_MODULES)
 endif
-lib_LTLIBRARIES = liblftp-tasks.la liblftp-jobs.la
-
 proto_ftp_la_SOURCES  = ftpclass.cc ftpclass.h FtpListInfo.cc FtpListInfo.h\
  FtpDirList.cc FtpDirList.h ftp-opie.c FileCopyFtp.cc FileCopyFtp.h
 proto_http_la_SOURCES = Http.cc Http.h HttpDir.cc HttpDir.h HttpDirXML.cc

Fw: liblftp-{tasks,jobs}.la dependencies do no exist [PATCH]

2009-10-13 Thread Jeroen Roovers 


Begin forwarded message:

Date: Wed, 14 Oct 2009 02:03:54 +0200
From: Jeroen Roovers j...@xs4all.nl
To: Alexander V. Lukyanov l...@netis.ru, lftp-devel@uniyar.ac.ru
Subject: Re: liblftp-{tasks,jobs}.la dependencies do no exist [PATCH]


I sent this reply or something similar earlier but gmane or
mail-archive apparently sent it to /dev/null instead.


On Mon, 21 Sep 2009 17:43:31 +0200
Markus Rothe mar...@unixforces.net wrote:

 The result is that /usr/lib64/liblftp-tasks.{a,la} and
 /usr/lib64/liblftp-jobs.{a,la} are installed. The .la files depend on
 the following files, which are not installed:

Patch attached.

 Another problem is that there is an empty directory being created if
 lftp is compiled without the --build-modules option: /usr/lib64/lftp/

Don't know about that one.


Regards,
 jer--- lftp-4.0.2.91.orig/src/Makefile.am	2009-07-29 08:29:10.0 +0200
+++ lftp-4.0.2.91/src/Makefile.am	2009-10-13 18:32:26.0 +0200
@@ -18,7 +18,8 @@
 example_module1_la_SOURCES = example-module1.cc
 example_module1_la_LDFLAGS  = -module -avoid-version -rpath $(pkgverlibdir)
 
-TASK_MODULES = liblftp-pty.la liblftp-network.la proto-ftp.la proto-http.la proto-file.la proto-fish.la proto-sftp.la
+TASK_MODULES = liblftp-pty.la liblftp-network.la proto-ftp.la proto-http.la proto-file.la proto-fish.la proto-sftp.la liblftp-tasks.la liblftp-jobs.la
+
 JOB_MODULES = cmd-mirror.la cmd-sleep.la cmd-torrent.la
 if WITH_MODULES
   pkgverlib_LTLIBRARIES = $(TASK_MODULES) $(JOB_MODULES)
@@ -26,8 +27,6 @@
   TASK_MODULES_STATIC = $(TASK_MODULES)
   JOB_MODULES_STATIC = $(JOB_MODULES)
 endif
-lib_LTLIBRARIES = liblftp-tasks.la liblftp-jobs.la
-
 proto_ftp_la_SOURCES  = ftpclass.cc ftpclass.h FtpListInfo.cc FtpListInfo.h\
  FtpDirList.cc FtpDirList.h ftp-opie.c FileCopyFtp.cc FileCopyFtp.h
 proto_http_la_SOURCES = Http.cc Http.h HttpDir.cc HttpDir.h HttpDirXML.cc

lftp-3.99.5 - cmd-torrent.so needs to be relinked

2009-07-29 Thread Jeroen Roovers 
 Hello there,


as Gentoo Linux's lftp package maintainer I was playing around with
lftp-3.99 when I noticed that cmd-torrent.so isn't being linked to
liblftp-network.la.

jer...@misha ~/torrents $ lftp -c torrent
http://torrent.fedoraproject.org/torrents//Fedora-11-x86_64-DVD.torrent 
/usr/lib/lftp/3.99.5/cmd-torrent.so:
undefined symbol: _ZN9RateLimit9BytesUsedEiNS_5dir_tE

Patch attached.


Kind regards,
 jer--- src/Makefile.am.orig	2009-06-26 17:14:39.0 +0200
+++ src/Makefile.am	2009-07-29 06:35:41.0 +0200
@@ -63,6 +63,7 @@
 proto_http_la_LIBADD = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la $(EXPAT_LIBS)
 proto_fish_la_LIBADD = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la liblftp-pty.la
 proto_sftp_la_LIBADD = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la liblftp-pty.la
+cmd_torrent_la_LIBADD  = -L$(DESTDIR)$(pkgverlibdir) liblftp-network.la
 
 liblftp_tasks_la_SOURCES = PollVec.cc PollVec.h SMTask.cc SMTask.h ProcWait.cc\
  ProcWait.h GetPass.cc GetPass.h ConnectionSlot.cc ConnectionSlot.h\