Re: [libav-devel] [PATCH] configure: Remove unneeded icl inline compatibility definition
On Tue, 18 Jun 2013, Alex Smith wrote:
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 93a9b30..543763f 100755
--- a/configure
+++ b/configure
@@ -2625,7 +2625,7 @@ probe_cc(){
# -Qdiag-error to make icl error when presented with certain unknown
arguments
_flags='-nologo -Qdiag-error:4044,10157'
# -Qvec- -Qsimd- to prevent miscompilation, -GS for consistency with
msvc which enables it by default
-_cflags='-D_USE_MATH_DEFINES -Dinline=__inline -FIstdlib.h
-Dstrtoll=_strtoi64 -Qms0 -Qvec- -Qsimd- -GS'
+_cflags='-D_USE_MATH_DEFINES -FIstdlib.h -Dstrtoll=_strtoi64 -Qms0
-Qvec- -Qsimd- -GS'
if [ $pfx = hostcc ]; then
append _cflags -Dsnprintf=_snprintf
fi
--
1.8.1.msysgit.1
Looks good to me.
// Martin
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 1/2] configure: More msvc/icl combining
--- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 543763f..f6c89ac 100755 --- a/configure +++ b/configure @@ -3945,14 +3945,14 @@ elif enabled tms470; then add_cflags -pds=824 -pds=837 elif enabled pathscale; then add_cflags -fstrict-overflow -OPT:wrap_around_unsafe_opt=OFF -elif enabled msvc; then +elif enabled_any msvc icl; then enabled x86_32 disable aligned_stack -elif enabled icl; then -enabled x86_32 disable aligned_stack -# basically -fstrict-aliasing for icl that doesn't work (correctly) on 13.x+ -check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias -# icl will pass the inline asm tests but inline asm is currently not supported (build will fail) -disable inline_asm +if enabled icl; then +# basically -fstrict-aliasing for icl that doesn't work (correctly) on 13.x+ +check_cpp_condition windows.h __ICL 1300 add_cflags -Qansi-alias +# icl will pass the inline asm tests but inline asm is currently not supported (build will fail) +disable inline_asm +fi fi case $target_os in -- 1.8.1.msysgit.1 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH 2/2] configure: Do not explicitly set Oy for msvc/icl
Instead, since it is implied by O1 or O2, selectively disable frame
pointer omission for x86 debug builds. Oy is ignored for x64 targets.
This also silences warnings with icl targeting x64.
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index f6c89ac..01251ca 100755
--- a/configure
+++ b/configure
@@ -2353,7 +2353,7 @@ msvc_common_flags(){
-Wall);;
-std=c99) ;;
# Common flags
--fomit-frame-pointer) echo -Oy ;;
+-fomit-frame-pointer) ;;
-g) echo -Z7 ;;
-fno-math-errno) ;;
-fno-common) ;;
@@ -3947,6 +3947,7 @@ elif enabled pathscale; then
add_cflags -fstrict-overflow -OPT:wrap_around_unsafe_opt=OFF
elif enabled_any msvc icl; then
enabled x86_32 disable aligned_stack
+enabled_all x86_32 debug add_cflags -Oy-
if enabled icl; then
# basically -fstrict-aliasing for icl that doesn't work (correctly) on
13.x+
check_cpp_condition windows.h __ICL 1300 add_cflags
-Qansi-alias
--
1.8.1.msysgit.1
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] avconv: report the error for codec open failure
External codec may have corner case reason to fail at init, better
report them instead having the user wonder.
---
This helped a lot debugging why the QSV failed to init when running
avconv through ssh on windows (yes I do such stuff).
avconv.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/avconv.c b/avconv.c
index 4808235..8ef1495 100644
--- a/avconv.c
+++ b/avconv.c
@@ -1371,10 +1371,16 @@ static int init_input_stream(int ist_index, char
*error, int error_len)
if (!av_dict_get(ist-opts, threads, NULL, 0))
av_dict_set(ist-opts, threads, auto, 0);
if ((ret = avcodec_open2(ist-st-codec, codec, ist-opts)) 0) {
+char errbuf[128];
+const char *errbuf_ptr = errbuf;
if (ret == AVERROR_EXPERIMENTAL)
abort_codec_experimental(codec, 0);
-snprintf(error, error_len, Error while opening decoder for input
stream #%d:%d,
-ist-file_index, ist-st-index);
+if (av_strerror(ret, errbuf, sizeof(errbuf)) 0)
+errbuf_ptr = strerror(AVUNERROR(ret));
+
+snprintf(error, error_len,
+ Error while opening decoder for input stream #%d:%d :
%s,
+ ist-file_index, ist-st-index, errbuf_ptr);
return ret;
}
assert_avoptions(ist-opts);
--
1.8.2.1
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/2] configure: More msvc/icl combining
On 2013-06-20 00:07, Alex Smith wrote: --- configure | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) If you prefer .. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/2] configure: Do not explicitly set Oy for msvc/icl
On 2013-06-20 00:07, Alex Smith wrote:
Instead, since it is implied by O1 or O2, selectively disable frame
pointer omission for x86 debug builds. Oy is ignored for x64 targets.
This also silences warnings with icl targeting x64.
--- a/configure
+++ b/configure
@@ -2353,7 +2353,7 @@ msvc_common_flags(){
-std=c99) ;;
# Common flags
--fomit-frame-pointer) echo -Oy ;;
+-fomit-frame-pointer) ;;
-g) echo -Z7 ;;
-fno-math-errno) ;;
@@ -3947,6 +3947,7 @@ elif enabled pathscale; then
elif enabled_any msvc icl; then
enabled x86_32 disable aligned_stack
+enabled_all x86_32 debug add_cflags -Oy-
This changes the semantics of --disable-optimizations, which will no
longer disable this flag.
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 1/4] lpc: remove decay argument
On 2013-06-18 5:30 PM, Loren Merritt wrote: We never used the rolling-average mode, and this makes av_update_lls 15% faster. --- libavcodec/lpc.c | 2 +- libavutil/lls.c | 7 +++ libavutil/lls.h | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) Seems pretty reasonable. I'm assuming there's not much of a future use case either. - Derek ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/4] lpc: use function pointers, in preparation for asm
On 2013-06-18 5:30 PM, Loren Merritt wrote: --- libavcodec/lpc.c | 4 ++-- libavutil/lls.c | 26 ++ libavutil/lls.h | 15 +-- 3 files changed, 29 insertions(+), 16 deletions(-) Although passing the struct to one of its members is kinda ugly, I see no obviously better way... Seems OK. - Derek ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] avconv: report the error for codec open failure
On Thu, 20 Jun 2013 00:08:36 +0200, Luca Barbato lu_z...@gentoo.org wrote:
External codec may have corner case reason to fail at init, better
report them instead having the user wonder.
---
This helped a lot debugging why the QSV failed to init when running
avconv through ssh on windows (yes I do such stuff).
avconv.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/avconv.c b/avconv.c
index 4808235..8ef1495 100644
--- a/avconv.c
+++ b/avconv.c
@@ -1371,10 +1371,16 @@ static int init_input_stream(int ist_index, char
*error, int error_len)
if (!av_dict_get(ist-opts, threads, NULL, 0))
av_dict_set(ist-opts, threads, auto, 0);
if ((ret = avcodec_open2(ist-st-codec, codec, ist-opts)) 0) {
+char errbuf[128];
+const char *errbuf_ptr = errbuf;
if (ret == AVERROR_EXPERIMENTAL)
abort_codec_experimental(codec, 0);
-snprintf(error, error_len, Error while opening decoder for
input stream #%d:%d,
-ist-file_index, ist-st-index);
+if (av_strerror(ret, errbuf, sizeof(errbuf)) 0)
+errbuf_ptr = strerror(AVUNERROR(ret));
I think av_strerror already falls back to strerror, so there should be no need
for this.
--
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
