Re: [libav-devel] [PATCH] h264: Correctly initialize interlaced_frame if tff is set

2017-02-13 Thread Luca Barbato 
On 10/02/2017 23:20, Vittorio Giovara wrote:
> In particular cases, it is possible to initialize top_field_first
> but not interlaced_frame. Make sure to correctly tag a frame
> as interlaced when this happens.
> 
> Signed-off-by: Vittorio Giovara 
> ---
>  libavcodec/h264_slice.c | 10 ++
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 

Should not hurt.

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/4] Rename "tools" subdirectory to "utilities"

2017-02-13 Thread Diego Biurrun 
On Mon, Feb 13, 2017 at 05:16:00PM +0100, Diego Biurrun wrote:
> On Mon, Feb 13, 2017 at 10:51:38AM -0500, Vittorio Giovara wrote:
> > On Sat, Feb 11, 2017 at 2:58 PM, Luca Barbato  wrote:
> > > On 06/01/2017 14:45, Diego Biurrun wrote:
> > >> ---
> > >
> > > Seems fine.
> > 
> > I don't mean to bikeshed the name, but why?
> > Is it too similar to avtools directory? If so please mention that in
> > the commit log.
> 
> This is an obsolete patch that has since been superseded.

Superseded by putting the av* tools in the avtools directory and leaving
the tools directory alone.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/4] Rename "tools" subdirectory to "utilities"

2017-02-13 Thread Diego Biurrun 
On Mon, Feb 13, 2017 at 10:51:38AM -0500, Vittorio Giovara wrote:
> On Sat, Feb 11, 2017 at 2:58 PM, Luca Barbato  wrote:
> > On 06/01/2017 14:45, Diego Biurrun wrote:
> >> ---
> >
> > Seems fine.
> 
> I don't mean to bikeshed the name, but why?
> Is it too similar to avtools directory? If so please mention that in
> the commit log.

This is an obsolete patch that has since been superseded.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] mov: Do not try to parse multiple stsd boxes for the same track

2017-02-13 Thread Vittorio Giovara 
On Sat, Feb 11, 2017 at 4:44 PM, Luca Barbato  wrote:
> Bug-Id: 1017
> CC: libav-sta...@libav.org
> ---
>
>  libavformat/mov.c | 6 ++
>  1 file changed, 6 insertions(+)
>
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index 2810960..001abcc 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -1911,6 +1911,12 @@ static int mov_read_stsd(MOVContext *c, AVIOContext 
> *pb, MOVAtom atom)
>  avio_rb24(pb); /* flags */
>  entries = avio_rb32(pb);
>
> +if (sc->extradata) {
> +av_log(c->fc, AV_LOG_ERROR,
> +   "A stsd atom already found for the track.\n");

atom is the "mov" way of saying "box" and that might cause confusion,
so I would rephrase the error message just

"Duplicate stsd found in this track"

Related, I'd drop "boxes" from the commit title as well.

Otherwise OK.
-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/4] Rename "tools" subdirectory to "utilities"

2017-02-13 Thread Vittorio Giovara 
On Sat, Feb 11, 2017 at 2:58 PM, Luca Barbato  wrote:
> On 06/01/2017 14:45, Diego Biurrun wrote:
>> ---
>
> Seems fine.
>

I don't mean to bikeshed the name, but why?
Is it too similar to avtools directory? If so please mention that in
the commit log.
-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] avconv: Move rescale to stream timebase before monotonisation

2017-02-13 Thread Luca Barbato 
On 13/02/2017 00:53, Mark Thompson wrote:
> If the stream timebase is coarser than the muxing timebase then the
> monotonisation process may fail because adding one to the timestamp
> need not actually produce a different timestamp after the rescale.
> ---
> As mentioned earlier on IRC.
> 

Possibly Ok.

lu

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel