Re: [libav-devel] [PATCH] v210: Use separate sample_factors

2016-01-31 Thread Diego Elio Pettenò 
LGTM, although I would have preferred seeing the use case for this split
together with the split, but not much of a blocker.

On Sun, Jan 31, 2016 at 3:06 PM Luca Barbato <lu_z...@gentoo.org> wrote:

> The 10bit and the 8bit functions can now be implemented to process
> a different amount of samples.
>
> And while at it simplify a little the code.
> ---
>
> As Diego asked IRL.
>
>  libavcodec/v210enc.c  | 19 ++-
>  libavcodec/v210enc.h  |  3 ++-
>  libavcodec/x86/v210enc_init.c |  7 ---
>  3 files changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/libavcodec/v210enc.c b/libavcodec/v210enc.c
> index da0b23f..51c182c 100644
> --- a/libavcodec/v210enc.c
> +++ b/libavcodec/v210enc.c
> @@ -86,7 +86,8 @@ av_cold void ff_v210enc_init(V210EncContext *s)
>  {
>  s->pack_line_8  = v210_planar_pack_8_c;
>  s->pack_line_10 = v210_planar_pack_10_c;
> -s->sample_factor = 1;
> +s->sample_factor_8  = 1;
> +s->sample_factor_10 = 1;
>
>  if (ARCH_X86)
>  ff_v210enc_init_x86(s);
> @@ -133,15 +134,19 @@ static int encode_frame(AVCodecContext *avctx,
> AVPacket *pkt,
>  const uint16_t *y = (const uint16_t *)pic->data[0];
>  const uint16_t *u = (const uint16_t *)pic->data[1];
>  const uint16_t *v = (const uint16_t *)pic->data[2];
> +
> +const int sample_size = 6 * s->sample_factor_10;
> +const int sample_w= avctx->width / sample_size;
> +
>  for (h = 0; h < avctx->height; h++) {
>  uint32_t val;
> -w = (avctx->width / (6 * s->sample_factor)) * 6 *
> s->sample_factor;
> +w = sample_w * sample_size;
>  s->pack_line_10(y, u, v, dst, w);
>
>  y += w;
>  u += w >> 1;
>  v += w >> 1;
> -dst += (w / (6 * s->sample_factor)) * 16 * s->sample_factor;
> +dst += sample_w * 16 * s->sample_factor_10;
>
>  for (; w < avctx->width - 5; w += 6) {
>  WRITE_PIXELS(u, y, v);
> @@ -178,15 +183,19 @@ static int encode_frame(AVCodecContext *avctx,
> AVPacket *pkt,
>  const uint8_t *y = pic->data[0];
>  const uint8_t *u = pic->data[1];
>  const uint8_t *v = pic->data[2];
> +
> +const int sample_size = 12 * s->sample_factor_8;
> +const int sample_w= avctx->width / sample_size;
> +
>  for (h = 0; h < avctx->height; h++) {
>  uint32_t val;
> -w = (avctx->width / (12 * s->sample_factor)) * 12 *
> s->sample_factor;
> +w = sample_w * sample_size;
>  s->pack_line_8(y, u, v, dst, w);
>
>  y += w;
>  u += w >> 1;
>  v += w >> 1;
> -dst += (w / (12 * s->sample_factor)) * 32 * s->sample_factor;
> +dst += sample_w * 32 * s->sample_factor_8;
>
>  for (; w < avctx->width - 5; w += 6) {
>  WRITE_PIXELS8(u, y, v);
> diff --git a/libavcodec/v210enc.h b/libavcodec/v210enc.h
> index 74b0514..ee3637a 100644
> --- a/libavcodec/v210enc.h
> +++ b/libavcodec/v210enc.h
> @@ -28,7 +28,8 @@ typedef struct V210EncContext {
>  const uint8_t *v, uint8_t *dst, ptrdiff_t width);
>  void (*pack_line_10)(const uint16_t *y, const uint16_t *u,
>   const uint16_t *v, uint8_t *dst, ptrdiff_t
> width);
> -int sample_factor;
> +int sample_factor_8;
> +int sample_factor_10;
>  } V210EncContext;
>
>  void ff_v210enc_init(V210EncContext *s);
> diff --git a/libavcodec/x86/v210enc_init.c b/libavcodec/x86/v210enc_init.c
> index 33f2e41..c4d2745 100644
> --- a/libavcodec/x86/v210enc_init.c
> +++ b/libavcodec/x86/v210enc_init.c
> @@ -46,8 +46,9 @@ av_cold void ff_v210enc_init_x86(V210EncContext *s)
>  s->pack_line_8 = ff_v210_planar_pack_8_avx;
>
>  if (EXTERNAL_AVX2(cpu_flags)) {
> -s->sample_factor = 2;
> -s->pack_line_8   = ff_v210_planar_pack_8_avx2;
> -s->pack_line_10  = ff_v210_planar_pack_10_avx2;
> +s->sample_factor_8  = 2;
> +s->pack_line_8  = ff_v210_planar_pack_8_avx2;
> +s->sample_factor_10 = 2;
> +s->pack_line_10 = ff_v210_planar_pack_10_avx2;
>  }
>  }
> --
> 2.6.1
>
> --
Diego Elio Pettenò (aka Flameeyes)
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [Website PATCH 2/2] about: update link to ffmpeg-mt to point to the archived Gitorious repository.

2016-01-24 Thread Diego Elio Pettenò 
Signed-off-by: Diego Elio Pettenò <flamee...@flameeyes.eu>
---
 src/about | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/about b/src/about
index e5665ba..b1c43e4 100644
--- a/src/about
+++ b/src/about
@@ -73,7 +73,7 @@ might lead to new interesting outcomes. 
 lead FFmpeg to merge important and long requested features such as http://article.gmane.org/gmane.comp.video.ffmpeg.devel/129927;>
 frame based multi-threaded decoding based on
-https://gitorious.org/~astrange/ffmpeg/ffmpeg-mt/;>ffmpeg-mt,
+https://gitorious.org/ffmpeg/ffmpeg-mt;>ffmpeg-mt,
 something the project leader strongly refused to merge during our attempts to
 reconcile with him. 
 
-- 
2.4.10

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [Website PATCH 1/2] download: remove gitorious mirror, since it's no longer forkable.

2016-01-24 Thread Diego Elio Pettenò 
The current archived copy of gitorious.org does not get synced, so there is no 
reason to have it listed.

Signed-off-by: Diego Elio Pettenò <flamee...@flameeyes.eu>
---
 src/download | 6 --
 1 file changed, 6 deletions(-)

diff --git a/src/download b/src/download
index 904a556..e14624c 100644
--- a/src/download
+++ b/src/download
@@ -153,12 +153,6 @@ developers and groups of developers are available.
 
 
 
-git://gitorious.org/libav/libav.git
-https://gitorious.org/libav/libav;>https://gitorious.org/libav/libav
-Libav team
-Gitorious Mirror
-
-
 git://github.com/libav/libav.git
 https://github.com/libav/libav;>https://github.com/libav/libav
 Libav team
-- 
2.4.10

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] tiff: return proper error for missing LZMA compression.

2014-08-18 Thread Diego Elio Pettenò 
The LZMA support is a semi-official extension supported by libtiff 4.0.0
and later.

Signed-off-by: Diego Elio Pettenò flamee...@flameeyes.eu
---
 libavcodec/tiff.c | 3 +++
 libavcodec/tiff.h | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index ca5ec75..3b2fc7d 100644
--- a/libavcodec/tiff.c
+++ b/libavcodec/tiff.c
@@ -408,6 +408,9 @@ static int tiff_decode_tag(TiffContext *s)
 case TIFF_NEWJPEG:
 avpriv_report_missing_feature(s-avctx, JPEG compression);
 return AVERROR_PATCHWELCOME;
+case TIFF_LZMA:
+avpriv_report_missing_feature(s-avctx, LZMA compression);
+return AVERROR_PATCHWELCOME;
 default:
 av_log(s-avctx, AV_LOG_ERROR, Unknown compression method %i\n,
s-compr);
diff --git a/libavcodec/tiff.h b/libavcodec/tiff.h
index 8a3f7f7..68ac695 100644
--- a/libavcodec/tiff.h
+++ b/libavcodec/tiff.h
@@ -71,7 +71,8 @@ enum TiffCompr {
 TIFF_NEWJPEG,
 TIFF_ADOBE_DEFLATE,
 TIFF_PACKBITS = 0x8005,
-TIFF_DEFLATE  = 0x80B2
+TIFF_DEFLATE  = 0x80B2,
+TIFF_LZMA = 0x886D,
 };
 
 enum TiffTypes {
-- 
1.8.5.5

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] tiff: return proper error for missing LZMA compression.

2014-08-17 Thread Diego Elio Pettenò 
The LZMA support was added to tiff 4.0.0. Whle not very common, it's nice
to tell the user why the file is not working.

Signed-off-by: Diego Elio Pettenò flamee...@flameeyes.eu
---
 libavcodec/tiff.c | 3 +++
 libavcodec/tiff.h | 3 ++-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index ca5ec75..3b2fc7d 100644
--- a/libavcodec/tiff.c
+++ b/libavcodec/tiff.c
@@ -408,6 +408,9 @@ static int tiff_decode_tag(TiffContext *s)
 case TIFF_NEWJPEG:
 avpriv_report_missing_feature(s-avctx, JPEG compression);
 return AVERROR_PATCHWELCOME;
+case TIFF_LZMA:
+avpriv_report_missing_feature(s-avctx, LZMA compression);
+return AVERROR_PATCHWELCOME;
 default:
 av_log(s-avctx, AV_LOG_ERROR, Unknown compression method %i\n,
s-compr);
diff --git a/libavcodec/tiff.h b/libavcodec/tiff.h
index 8a3f7f7..c42fa41 100644
--- a/libavcodec/tiff.h
+++ b/libavcodec/tiff.h
@@ -71,7 +71,8 @@ enum TiffCompr {
 TIFF_NEWJPEG,
 TIFF_ADOBE_DEFLATE,
 TIFF_PACKBITS = 0x8005,
-TIFF_DEFLATE  = 0x80B2
+TIFF_DEFLATE  = 0x80B2,
+TIFF_LZMA = 0x886d
 };
 
 enum TiffTypes {
-- 
1.8.5.5

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] tiff: only use PAL8 if palette is present, else use GRAY8 for pixfmt.

2014-08-09 Thread Diego Elio Pettenò 
Instead of simulating a grayscale palette, use real grayscale pixels, if no
palette is actually defined.

Signed-off-by: Diego Elio Pettenò flamee...@flameeyes.eu
---
 libavcodec/tiff.c | 14 +++---
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c
index 2aff45a..ca5ec75 100644
--- a/libavcodec/tiff.c
+++ b/libavcodec/tiff.c
@@ -246,15 +246,14 @@ static int tiff_unpack_strip(TiffContext *s, uint8_t 
*dst, int stride,
 
 static int init_image(TiffContext *s, AVFrame *frame)
 {
-int i, ret;
-uint32_t *pal;
+int ret;
 
 switch (s-bpp * 10 + s-bppcount) {
 case 11:
 s-avctx-pix_fmt = AV_PIX_FMT_MONOBLACK;
 break;
 case 81:
-s-avctx-pix_fmt = AV_PIX_FMT_PAL8;
+s-avctx-pix_fmt = s-palette_is_set ? AV_PIX_FMT_PAL8 : 
AV_PIX_FMT_GRAY8;
 break;
 case 243:
 s-avctx-pix_fmt = AV_PIX_FMT_RGB24;
@@ -290,14 +289,7 @@ static int init_image(TiffContext *s, AVFrame *frame)
 return ret;
 }
 if (s-avctx-pix_fmt == AV_PIX_FMT_PAL8) {
-if (s-palette_is_set) {
-memcpy(frame-data[1], s-palette, sizeof(s-palette));
-} else {
-/* make default grayscale pal */
-pal = (uint32_t *) frame-data[1];
-for (i = 0; i  256; i++)
-pal[i] = i * 0x010101;
-}
+memcpy(frame-data[1], s-palette, sizeof(s-palette));
 }
 return 0;
 }
-- 
1.8.5.5

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] x86: Skip compiling/assembling unused SIMD optimizations on x86_64

2013-10-06 Thread Diego Elio Pettenò 
On Sun, Oct 6, 2013 at 6:28 PM, Diego Biurrun di...@biurrun.de wrote:


 before

 $ ls -l libavcodec/libavcodec.a
 -rw-rw-r-- 1 biurrun 10006 84458588 Oct  6 19:22 libavcodec/libavcodec.a

 after

 $ ls -l libavcodec/libavcodec.a
 -rw-rw-r-- 1 biurrun 10006 84349546 Oct  6 18:57 libavcodec/libavcodec.a



Diego, can you please use rbelf-diff for this kind of changes? I'd be more
interested in the difference on either avconv or libavcodec.so, rather than
the final size of the .a that makes little sense.


Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] MSN Audio support

2013-09-07 Thread Diego Elio Pettenò 
On Sat, Sep 7, 2013 at 8:12 PM, Kostya Shishkov
kostya.shish...@gmail.comwrote:

 +const int* ff_gsm_apcm_bits[][4] = {


const int * const ?

Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] mem: Document the av_realloc family of function properly

2013-09-04 Thread Diego Elio Pettenò 
On Wed, Sep 4, 2013 at 10:44 AM, Diego Biurrun di...@biurrun.de wrote:

 I did not OK this, nor is this OK; the grammar is Unenglish.  I even
 reviewed this, but the mail seems to have been eaten somewhere...


Luca was referring to me in this instance.

Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] mem: Do not check unsigned values for negative size

2013-09-04 Thread Diego Elio Pettenò 
LGTM.

Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


On Wed, Sep 4, 2013 at 11:43 AM, Diego Biurrun di...@biurrun.de wrote:

 ---

 Now w/o stupid and obvious mistakes.

  libavutil/mem.c |6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

 diff --git a/libavutil/mem.c b/libavutil/mem.c
 index b4a190a..5f64f56 100644
 --- a/libavutil/mem.c
 +++ b/libavutil/mem.c
 @@ -138,7 +138,7 @@ void *av_realloc(void *ptr, size_t size)

  void *av_realloc_array(void *ptr, size_t nmemb, size_t size)
  {
 -if (size = 0 || nmemb = INT_MAX / size)
 +if (!size || nmemb = INT_MAX / size)
  return NULL;
  return av_realloc(ptr, nmemb * size);
  }
 @@ -147,9 +147,9 @@ int av_reallocp_array(void *ptr, size_t nmemb, size_t
 size)
  {
  void **ptrptr = ptr;
  void *ret;
 -if (size = 0 || nmemb = INT_MAX / size)
 +if (!size || nmemb = INT_MAX / size)
  return AVERROR(ENOMEM);
 -if (nmemb = 0) {
 +if (!nmemb) {
  av_freep(ptr);
  return 0;
  }
 --
 1.7.9.5

 ___
 libav-devel mailing list
 libav-devel@libav.org
 https://lists.libav.org/mailman/listinfo/libav-devel

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] mpeg12enc: refactor ff_mpeg1_encode_mb

2013-09-02 Thread Diego Elio Pettenò 
LGTM.

Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


On Mon, Sep 2, 2013 at 5:08 PM, Vittorio Giovara vittorio.giov...@gmail.com
 wrote:

 ---
 I did a simple performance test for this, as suggested on IRC and got

 WITHOUT
 real2m57.078s
 user4m16.308s
 sys 0m31.410s

 WITH
 real2m56.643s
 user4m16.052s
 sys 0m31.714s

 Plus I think code is more readable. I think there might be quite a few
 places that could receive the same treatment.

 Cheers,
 Vittorio

  libavcodec/mpeg12enc.c |   14 ++
  1 file changed, 2 insertions(+), 12 deletions(-)

 diff --git a/libavcodec/mpeg12enc.c b/libavcodec/mpeg12enc.c
 index 0ede7c4..a69d9b6 100644
 --- a/libavcodec/mpeg12enc.c
 +++ b/libavcodec/mpeg12enc.c
 @@ -439,15 +439,13 @@ static inline void put_mb_modes(MpegEncContext *s,
 int n, int bits, int has_mv,
  }
  }

 -static av_always_inline void mpeg1_encode_mb_internal(MpegEncContext *s,
 -  int16_t
 block[6][64],
 -  int motion_x, int
 motion_y,
 -  int mb_block_count)
 +void ff_mpeg1_encode_mb(MpegEncContext *s, int16_t block[6][64], int
 motion_x, int motion_y)
  {
  int i, cbp;
  const int mb_x = s-mb_x;
  const int mb_y = s-mb_y;
  const int first_mb = mb_x == s-resync_mb_x  mb_y == s-resync_mb_y;
 +const int mb_block_count = s-chroma_format == CHROMA_420 ? 6 : 8;

  /* compute cbp */
  cbp = 0;
 @@ -671,14 +669,6 @@ static av_always_inline void
 mpeg1_encode_mb_internal(MpegEncContext *s,
  }
  }

 -void ff_mpeg1_encode_mb(MpegEncContext *s, int16_t block[6][64], int
 motion_x, int motion_y)
 -{
 -if (s-chroma_format == CHROMA_420)
 -mpeg1_encode_mb_internal(s, block, motion_x, motion_y, 6);
 -else
 -mpeg1_encode_mb_internal(s, block, motion_x, motion_y, 8);
 -}
 -
  // RAL: Parameter added: f_or_b_code
  static void mpeg1_encode_motion(MpegEncContext *s, int val, int
 f_or_b_code)
  {
 --
 1.7.9.5

 ___
 libav-devel mailing list
 libav-devel@libav.org
 https://lists.libav.org/mailman/listinfo/libav-devel

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] vf_lut: constantize.

2013-08-31 Thread Diego Elio Pettenò 
The pix format tables are never modified, mark them as constant.

Signed-off-by: Diego Elio Pettenò flamee...@flameeyes.eu
---
 libavfilter/vf_lut.c | 11 ++-
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/libavfilter/vf_lut.c b/libavfilter/vf_lut.c
index 348ef32..e02f113 100644
--- a/libavfilter/vf_lut.c
+++ b/libavfilter/vf_lut.c
@@ -140,16 +140,17 @@ static av_cold void uninit(AVFilterContext *ctx)
 AV_PIX_FMT_ABGR, AV_PIX_FMT_BGRA, \
 AV_PIX_FMT_RGB24,AV_PIX_FMT_BGR24
 
-static enum AVPixelFormat yuv_pix_fmts[] = { YUV_FORMATS, AV_PIX_FMT_NONE };
-static enum AVPixelFormat rgb_pix_fmts[] = { RGB_FORMATS, AV_PIX_FMT_NONE };
-static enum AVPixelFormat all_pix_fmts[] = { RGB_FORMATS, YUV_FORMATS, 
AV_PIX_FMT_NONE };
+static const enum AVPixelFormat yuv_pix_fmts[] = { YUV_FORMATS, 
AV_PIX_FMT_NONE };
+static const enum AVPixelFormat rgb_pix_fmts[] = { RGB_FORMATS, 
AV_PIX_FMT_NONE };
+static const enum AVPixelFormat all_pix_fmts[] = { RGB_FORMATS, YUV_FORMATS, 
AV_PIX_FMT_NONE };
 
 static int query_formats(AVFilterContext *ctx)
 {
 LutContext *s = ctx-priv;
 
-enum AVPixelFormat *pix_fmts = s-is_rgb ? rgb_pix_fmts :
- s-is_yuv ? yuv_pix_fmts : all_pix_fmts;
+const enum AVPixelFormat *pix_fmts = s-is_rgb ? rgb_pix_fmts :
+ s-is_yuv ? yuv_pix_fmts :
+ all_pix_fmts;
 
 ff_set_common_formats(ctx, ff_make_format_list(pix_fmts));
 return 0;
-- 
1.8.3.2

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [RFC] Port aacsbr generated tables to tablegen infrastructure.

2013-08-31 Thread Diego Elio Pettenò 
This allows hardcoded table to generate them, which saves 2.5KB of
copy-on-write data at runtime as soon as the AAC decoder is
initialized.

Signed-off-by: Diego Elio Pettenò flamee...@flameeyes.eu
---
 libavcodec/Makefile   |   4 +-
 libavcodec/aacsbr.c   |  12 +---
 libavcodec/aacsbr_tablegen.c  |  38 +++
 libavcodec/aacsbr_tablegen.h  | 133 ++
 libavcodec/aacsbr_tablegen_decl.h |  32 +
 libavcodec/aacsbrdata.h   |  86 
 6 files changed, 209 insertions(+), 96 deletions(-)
 create mode 100644 libavcodec/aacsbr_tablegen.c
 create mode 100644 libavcodec/aacsbr_tablegen.h
 create mode 100644 libavcodec/aacsbr_tablegen_decl.h

diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index 2eba60f..7b0c8b5 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -700,6 +700,7 @@ TESTOBJS = dctref.o
 
 HOSTPROGS = aac_tablegen\
 aacps_tablegen  \
+aacsbr_tablegen \
 cbrt_tablegen   \
 cos_tablegen\
 dv_tablegen \
@@ -727,7 +728,7 @@ endif
 
 GEN_HEADERS = cbrt_tables.h aacps_tables.h aac_tables.h dv_tables.h \
   sinewin_tables.h mpegaudio_tables.h motionpixels_tables.h \
-  pcm_tables.h qdm2_tables.h
+  pcm_tables.h qdm2_tables.h aacsbr_tables.h
 GEN_HEADERS := $(addprefix $(SUBDIR), $(GEN_HEADERS))
 
 $(GEN_HEADERS): $(SUBDIR)%_tables.h: $(SUBDIR)%_tablegen$(HOSTEXESUF)
@@ -736,6 +737,7 @@ $(GEN_HEADERS): $(SUBDIR)%_tables.h: 
$(SUBDIR)%_tablegen$(HOSTEXESUF)
 ifdef CONFIG_HARDCODED_TABLES
 $(SUBDIR)aacdec.o: $(SUBDIR)cbrt_tables.h
 $(SUBDIR)aacps.o: $(SUBDIR)aacps_tables.h
+$(SUBDIR)aacsbr.o: $(SUBDIR)aacsbr_tables.h
 $(SUBDIR)aactab.o: $(SUBDIR)aac_tables.h
 $(SUBDIR)dv.o: $(SUBDIR)dv_tables.h
 $(SUBDIR)sinewin.o: $(SUBDIR)sinewin_tables.h
diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c
index 650f7aa..a431ed4 100644
--- a/libavcodec/aacsbr.c
+++ b/libavcodec/aacsbr.c
@@ -30,6 +30,7 @@
 #include sbr.h
 #include aacsbr.h
 #include aacsbrdata.h
+#include aacsbr_tablegen.h
 #include fft.h
 #include aacps.h
 #include sbrdsp.h
@@ -87,7 +88,6 @@ static const int8_t vlc_sbr_lav[10] =
 
 av_cold void ff_aac_sbr_init(void)
 {
-int n;
 static const struct {
 const void *sbr_codes, *sbr_bits;
 const unsigned int table_size, elem_size;
@@ -116,15 +116,9 @@ av_cold void ff_aac_sbr_init(void)
 SBR_INIT_VLC_STATIC(8, 592);
 SBR_INIT_VLC_STATIC(9, 512);
 
-for (n = 1; n  320; n++)
-sbr_qmf_window_us[320 + n] = sbr_qmf_window_us[320 - n];
-sbr_qmf_window_us[384] = -sbr_qmf_window_us[384];
-sbr_qmf_window_us[512] = -sbr_qmf_window_us[512];
-
-for (n = 0; n  320; n++)
-sbr_qmf_window_ds[n] = sbr_qmf_window_us[2*n];
-
 ff_ps_init();
+
+ff_aac_sbr_tableinit();
 }
 
 /** Places SBR in pure upsampling mode. */
diff --git a/libavcodec/aacsbr_tablegen.c b/libavcodec/aacsbr_tablegen.c
new file mode 100644
index 000..d701366
--- /dev/null
+++ b/libavcodec/aacsbr_tablegen.c
@@ -0,0 +1,38 @@
+/*
+ * Generate a header file for hardcoded AAC tables
+ *
+ * Copyright (c) 2010 Alex Converse alex.conve...@gmail.com
+ *
+ * This file is part of Libav.
+ *
+ * Libav is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * Libav is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with Libav; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include stdlib.h
+#define CONFIG_HARDCODED_TABLES 0
+#include aacsbr_tablegen.h
+#include tableprint.h
+
+int main(void)
+{
+ff_aac_sbr_tableinit();
+
+write_fileheader();
+
+WRITE_ARRAY(static const, float, sbr_qmf_window_ds);
+WRITE_ARRAY(static const, float, sbr_qmf_window_us);
+
+return 0;
+}
diff --git a/libavcodec/aacsbr_tablegen.h b/libavcodec/aacsbr_tablegen.h
new file mode 100644
index 000..f33680e
--- /dev/null
+++ b/libavcodec/aacsbr_tablegen.h
@@ -0,0 +1,133 @@
+/*
+ * Header file for hardcoded AAC SBR tables
+ *
+ * Copyright (c) 2008-2009 Robert Swain ( rob opendot cl )
+ * Copyright (c) 2009-2010 Alex Converse alex.conve...@gmail.com
+ *
+ * This file is part

[libav-devel] [RFC v2] Port aacsbr generated tables to tablegen infrastructure.

2013-08-31 Thread Diego Elio Pettenò 
This allows hardcoded table to generate them, which saves 2.5KB of
copy-on-write data at runtime as soon as the AAC decoder is
initialized.

It includes a WRITE_ALIGNED_ARRAY so that the generated tables match
the originals 1:1.

Signed-off-by: Diego Elio Pettenò flamee...@flameeyes.eu
---
 libavcodec/Makefile   |   4 +-
 libavcodec/aacsbr.c   |  12 +---
 libavcodec/aacsbr_tablegen.c  |  38 +++
 libavcodec/aacsbr_tablegen.h  | 133 ++
 libavcodec/aacsbr_tablegen_decl.h |  32 +
 libavcodec/aacsbrdata.h   |  86 
 libavcodec/tableprint.h   |  10 +++
 7 files changed, 219 insertions(+), 96 deletions(-)
 create mode 100644 libavcodec/aacsbr_tablegen.c
 create mode 100644 libavcodec/aacsbr_tablegen.h
 create mode 100644 libavcodec/aacsbr_tablegen_decl.h

diff --git a/libavcodec/Makefile b/libavcodec/Makefile
index 2eba60f..7b0c8b5 100644
--- a/libavcodec/Makefile
+++ b/libavcodec/Makefile
@@ -700,6 +700,7 @@ TESTOBJS = dctref.o
 
 HOSTPROGS = aac_tablegen\
 aacps_tablegen  \
+aacsbr_tablegen \
 cbrt_tablegen   \
 cos_tablegen\
 dv_tablegen \
@@ -727,7 +728,7 @@ endif
 
 GEN_HEADERS = cbrt_tables.h aacps_tables.h aac_tables.h dv_tables.h \
   sinewin_tables.h mpegaudio_tables.h motionpixels_tables.h \
-  pcm_tables.h qdm2_tables.h
+  pcm_tables.h qdm2_tables.h aacsbr_tables.h
 GEN_HEADERS := $(addprefix $(SUBDIR), $(GEN_HEADERS))
 
 $(GEN_HEADERS): $(SUBDIR)%_tables.h: $(SUBDIR)%_tablegen$(HOSTEXESUF)
@@ -736,6 +737,7 @@ $(GEN_HEADERS): $(SUBDIR)%_tables.h: 
$(SUBDIR)%_tablegen$(HOSTEXESUF)
 ifdef CONFIG_HARDCODED_TABLES
 $(SUBDIR)aacdec.o: $(SUBDIR)cbrt_tables.h
 $(SUBDIR)aacps.o: $(SUBDIR)aacps_tables.h
+$(SUBDIR)aacsbr.o: $(SUBDIR)aacsbr_tables.h
 $(SUBDIR)aactab.o: $(SUBDIR)aac_tables.h
 $(SUBDIR)dv.o: $(SUBDIR)dv_tables.h
 $(SUBDIR)sinewin.o: $(SUBDIR)sinewin_tables.h
diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c
index 650f7aa..a431ed4 100644
--- a/libavcodec/aacsbr.c
+++ b/libavcodec/aacsbr.c
@@ -30,6 +30,7 @@
 #include sbr.h
 #include aacsbr.h
 #include aacsbrdata.h
+#include aacsbr_tablegen.h
 #include fft.h
 #include aacps.h
 #include sbrdsp.h
@@ -87,7 +88,6 @@ static const int8_t vlc_sbr_lav[10] =
 
 av_cold void ff_aac_sbr_init(void)
 {
-int n;
 static const struct {
 const void *sbr_codes, *sbr_bits;
 const unsigned int table_size, elem_size;
@@ -116,15 +116,9 @@ av_cold void ff_aac_sbr_init(void)
 SBR_INIT_VLC_STATIC(8, 592);
 SBR_INIT_VLC_STATIC(9, 512);
 
-for (n = 1; n  320; n++)
-sbr_qmf_window_us[320 + n] = sbr_qmf_window_us[320 - n];
-sbr_qmf_window_us[384] = -sbr_qmf_window_us[384];
-sbr_qmf_window_us[512] = -sbr_qmf_window_us[512];
-
-for (n = 0; n  320; n++)
-sbr_qmf_window_ds[n] = sbr_qmf_window_us[2*n];
-
 ff_ps_init();
+
+ff_aac_sbr_tableinit();
 }
 
 /** Places SBR in pure upsampling mode. */
diff --git a/libavcodec/aacsbr_tablegen.c b/libavcodec/aacsbr_tablegen.c
new file mode 100644
index 000..86e9347
--- /dev/null
+++ b/libavcodec/aacsbr_tablegen.c
@@ -0,0 +1,38 @@
+/*
+ * Generate a header file for hardcoded AAC tables
+ *
+ * Copyright (c) 2010 Alex Converse alex.conve...@gmail.com
+ *
+ * This file is part of Libav.
+ *
+ * Libav is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ *
+ * Libav is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with Libav; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include stdlib.h
+#define CONFIG_HARDCODED_TABLES 0
+#include aacsbr_tablegen.h
+#include tableprint.h
+
+int main(void)
+{
+ff_aac_sbr_tableinit();
+
+write_fileheader();
+
+WRITE_ALIGNED_ARRAY(static const, 32, float, sbr_qmf_window_ds);
+WRITE_ALIGNED_ARRAY(static const, 32, float, sbr_qmf_window_us);
+
+return 0;
+}
diff --git a/libavcodec/aacsbr_tablegen.h b/libavcodec/aacsbr_tablegen.h
new file mode 100644
index 000..f33680e
--- /dev/null
+++ b/libavcodec/aacsbr_tablegen.h
@@ -0,0 +1,133 @@
+/*
+ * Header file for hardcoded AAC SBR

Re: [libav-devel] [PATCH] pcm-dvd: Fix build on big endian

2013-08-31 Thread Diego Elio Pettenò 
LGTM

Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


On Sat, Aug 31, 2013 at 4:41 PM, Martin Storsjö mar...@martin.st wrote:

 ---
  libavcodec/pcm-dvd.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

 diff --git a/libavcodec/pcm-dvd.c b/libavcodec/pcm-dvd.c
 index 8e88ad4..9fd6d13 100644
 --- a/libavcodec/pcm-dvd.c
 +++ b/libavcodec/pcm-dvd.c
 @@ -160,7 +160,7 @@ static void *pcm_dvd_decode_samples(AVCodecContext
 *avctx, const uint8_t *src,
  case 16:
  #if HAVE_BIGENDIAN
  bytestream2_get_buffer(gb, dst16, blocks * s-block_size);
 -dst16 += blocks * block_size / 2;
 +dst16 += blocks * s-block_size / 2;
  #else
  samples = blocks * avctx-channels;
  do {
 --
 1.7.9.4

 ___
 libav-devel mailing list
 libav-devel@libav.org
 https://lists.libav.org/mailman/listinfo/libav-devel

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] iff: fix out of array accesses by avoiding an integer overflow

2013-03-17 Thread Diego Elio Pettenò 
On 17/03/2013 18:33, Reinhard Tartler wrote:
 I see. So what's the correct solution here? Just drop the assert? Or
 something like:

I would say this is a better solution.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] doc: update the reference for the title

2013-01-26 Thread Diego Elio Pettenò 
On 26/01/2013 04:36, Luca Barbato wrote:
 Ping. Debian stable has it btw.

If Debian stale has it I'm fine with it, as nothing in this millennia is
going to miss it :)

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] doc: support multitable in texi2pod

2013-01-25 Thread Diego Elio Pettenò 
On 23/01/2013 11:45, Luca Barbato wrote:
 I'm pondering of hacking texi2man and use it instead, this thing is
 nasty.

LGTM and +1 on investigating texi2man.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] lavu: Add av_strnstr()

2013-01-23 Thread Diego Elio Pettenò 
On 23/01/2013 16:59, Vladimir Pantelic wrote:
  version 9:
 +- av_strnstr

Shouldn't this be version 10?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Diego Elio Pettenò 
On 22/01/2013 03:02, Ronald S. Bultje wrote:
 
 This is never used.

This has a strange effect on the other avg_pixels8_* functions, me and
Luca have been looking into it today — it's not bad, but if we can
stagger this a moment, we might be able to figure it out properly.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] libcdio: support recent cdio-paranoia

2013-01-17 Thread Diego Elio Pettenò 
Mostly LGTM considering the note you already fixed locally.

How feasible it is to have this work with non-CDIO Paranoia library as well?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] libcdio: support recent cdio-paranoia

2013-01-17 Thread Diego Elio Pettenò 
On 17/01/2013 14:53, Luca Barbato wrote:
 You lose the paranoia option, but the code is much simpler, I could try
 baking something later if you are willing to test it a bit.

You better find somebody else to test it for real as I haven't used an
audio cd on linux for the past ten years or so...

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 5/5] avconv: Increase the SDP buffer size to fit xiph SDPs

2013-01-17 Thread Diego Elio Pettenò 
On 17/01/2013 15:12, Martin Storsjö wrote:
 -char sdp[2048];
 +char sdp[16384];

Hrm, 16KiB on stack? (theoretically)

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 5/5] avconv: Increase the SDP buffer size to fit xiph SDPs

2013-01-17 Thread Diego Elio Pettenò 
On 17/01/2013 15:21, Martin Storsjö wrote:

 
 Yes, it's not all that nice, but not actually too much of an issue for
 the systems where people actually use the avconv front end AFAIK...

Good point — I guess the only place I don't know how would react for
this would be Windows.. if you feel it's safe, it's okay for me.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/4] libvpx: make vp8 and vp9 selectable

2013-01-14 Thread Diego Elio Pettenò 
On 14/01/2013 19:33, Diego Biurrun wrote:
 Changing these names could be considered an API/ABI break.

Aren't ff_* symbols considered internals?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] KLVPacket synchronous encoding

2013-01-04 Thread Diego Elio Pettenò 
On 04/01/2013 15:06, Shawn Donnelly wrote:
 From wikipedia:

Yes we can see wikipedia, the problem is that it lacks context.

Is it used for subtitles? For general timestamped side-data? Simply for
metadata?

H.264 is a video codec, so it's a single stream. If you want to mux it
with a general timestamped data stream, you need a container, at the
very least.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] KLVPacket synchronous encoding

2013-01-04 Thread Diego Elio Pettenò 
On 04/01/2013 15:22, Shawn Donnelly wrote:
 
 What container should I use to MUX in the data stream?

So the description you sent is referring to mpeg2 ts, using PES as a
timestamped side data synchronised with the H264 and/or MPEG2 video
stream through PES.

I'm not sure whether we support this or not as I'm no expert on the topic.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] hlsenc: correctly report target duration

2012-12-21 Thread Diego Elio Pettenò 
On 21/12/2012 12:08, Luca Barbato wrote:
 Today I got a report about it.

LGTM but a line or two of description wouldn't be bad.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] mkv: support vp9 tag

2012-12-15 Thread Diego Elio Pettenò 
On 15/12/2012 23:28, Luca Barbato wrote:
 @@ -238,6 +238,7 @@ enum AVCodecID {
  AV_CODEC_ID_KGV1,
  AV_CODEC_ID_YOP,
  AV_CODEC_ID_VP8,
 +AV_CODEC_ID_VP9,
  AV_CODEC_ID_PICTOR,
  AV_CODEC_ID_ANSI,
  AV_CODEC_ID_A64_MULTI,

As Ronald said, this shouldn't be in that position as it breaks ABI.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] Make LCOAL_ALIGNED syntactically similar on all systems

2012-12-11 Thread Diego Elio Pettenò 
On 11/12/2012 10:25, Luca Barbato wrote:
 let's push it =)

With a fixed summary I suppose?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] Make LCOAL_ALIGNED syntactically similar on all systems

2012-12-11 Thread Diego Elio Pettenò 
On 11/12/2012 10:42, Luca Barbato wrote:
 Mans did already I think.

Sorry missed that.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/4] hls: add start_number option

2012-12-08 Thread Diego Elio Pettenò 
On 08/12/2012 06:17, Luca Barbato wrote:
 +{ start_number, first number in the sequence,
 OFFSET(number),  AV_OPT_TYPE_INT,{.i64 = 0}, 0, INT_MAX, E},
  {hls_time,  segment length in seconds,   
 OFFSET(time),AV_OPT_TYPE_FLOAT,  {.dbl = 2}, 0, FLT_MAX, E},

LGTM but what about alignment?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] ff_*_tab still brittle

2012-11-27 Thread Diego Elio Pettenò 
On 27/11/2012 06:55, Martin Storsjö wrote:
 
 After taking a closer look at the issue, it seems that the actual
 culprit is that suncc doesn't strip out unused static functions if -g is
 specified. So any file that happens to include the header that declares
 the static inline function that references ff_log2_tab (or similar) will
 end up with a reference to that symbol, even if the inline function
 isn't used at all.

Gha I remember that one now :( I hit it a long time ago as well.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] riff: mask the channel layout to 18 bits when writing dwChannelMask

2012-11-26 Thread Diego Elio Pettenò 
On 26/11/2012 20:10, Justin Ruggles wrote:
 Only the low 18 bits are used for channel assignments. The high bit is a
 special-case flag bit used to indicate that any channel layout is
 supported.
LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] pcm: fix decoding of pcm_s16le_planar on big-endian

2012-11-19 Thread Diego Elio Pettenò 
On 19/11/2012 21:59, Justin Ruggles wrote:
 The sample count is decremented by the DECODE() macro and needs to be reset
 in each loop iteration. Also, DECODE() increments the src pointer so that does
 not need to be done separately.

LGTM.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Diego Elio Pettenò 
On 26/10/2012 11:52, Luca Barbato wrote:
 Fine for me, in case we might add some grep to find functions that could
 be dangerous.

If I'm not mistaken there should be a way to inject the warnings at link
time.

Although it's easier to just nm/elfgrep the final targets.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/1] remove #defines to prevent use of discouraged external functions

2012-10-26 Thread Diego Elio Pettenò 
On 26/10/2012 12:07, Måns Rullgård wrote:
 That would be just as wrong.  There are legitimate uses for most of
 these functions.

I'd still prefer that to grepping the sources.

For me it's fine to not keep the warnings around at all.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 05/11] mov: make enum MovChannelLayoutTag definition standards compliant

2012-10-26 Thread Diego Elio Pettenò 
On 26/10/2012 17:50, Mans Rullgard wrote:
 +MOV_CH_LAYOUT_UNKNOWN   = ( -1  16),
  MOV_CH_LAYOUT_USE_DESCRIPTIONS  = (  0  16) | 0,

Uhm, any reason for the others to use | 0 ?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 05/11] mov: make enum MovChannelLayoutTag definition standards compliant

2012-10-26 Thread Diego Elio Pettenò 
On 26/10/2012 18:18, Måns Rullgård wrote:
 Only to follow the pattern.

Should yours do the same then, or should one Diego at random send a
patch to remove the rest?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] avutil: Move memcpy_backptr() to mem.c

2012-10-22 Thread Diego Elio Pettenò 
On 22/10/2012 10:18, Diego Biurrun wrote:
 -#include libavutil/lzo.h // for av_memcpy_backptr
 +#include libavutil/lzo.h
 +#include libavutil/mem.h

Is lzo.h still required here?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Diego Elio Pettenò 
On 06/10/2012 17:01, Ronald S. Bultje wrote:
  It prevents the caller from accessing all the descriptors when he's
  using a newer library than the one he compiled against.
 if (compile_ver  runtime_ver) error(); on app init. Likely, you want
 to do that anyway.
 

Actually Anton is referring to the opposite case (runtime  compile),
which is pretty common for all distributions.

If you were to do that, distributions would likely feel like kicking
libav out for good. Speaking with my distro hat on.

So I'm in favour of Anton's choice, ABI stability _is_ necessary and
very welcome.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 4/9] tools: do not use av_pix_fmt_descriptors directly.

2012-10-06 Thread Diego Elio Pettenò 
On 06/10/2012 22:11, Ronald S. Bultje wrote:
 
  The same way we can never have msvc support?
 Right.
 
 Shall we move on to more practical patches?

flamebait
Sure, are we going to stop reviewing MSVC fixes?
/flamebait

As I said this patch makes the ABI more stable, and distributions love
ABI stability, so please do not discount it simply because your use
cases don't care about it. We already have a V8 with its own ABI problems.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] avconv/avprobe: Add missing 'void' to exit_program() definition

2012-10-03 Thread Diego Elio Pettenò 
On 03/10/2012 07:21, Diego Biurrun wrote:
  avconv.c  |2 +-
  avprobe.c |2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

LGTM, and thanks for catching it.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] pcm-mpeg.c: convert switch() statement for sample rate to array lookup

2012-10-03 Thread Diego Elio Pettenò 
On 03/10/2012 10:05, Luca Barbato wrote:
 looks a bit wasteful and, as you stated on irc, one value won't fit.

Actually that's two values. 96000 won't fit either.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] avconv: remove stray exit() call that wasn't removed with atexit.

2012-10-02 Thread Diego Elio Pettenò 
This was a local chunk that wasn't sent on the other patch.

Signed-off-by: Diego Elio Pettenò flamee...@flameeyes.eu
---
 avconv.c | 1 -
 1 file modificato. 1 rimozione(-)

diff --git a/avconv.c b/avconv.c
index 2e42065..722f817 100644
--- a/avconv.c
+++ b/avconv.c
@@ -216,7 +216,6 @@ static void exit_program()
 if (received_sigterm) {
 av_log(NULL, AV_LOG_INFO, Received signal %d: terminating.\n,
(int) received_sigterm);
-exit (255);
 }
 }
 
-- 
1.7.12

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] Explicit symbol visibility Was: [PATCH] Shared library support for MSVC build.

2012-10-02 Thread Diego Elio Pettenò 
On 02/10/2012 18:40, Luca Barbato wrote:
 
 The patch was rejected since it was _really_ invasive and after lots of
 back and forth we ended up with pattern matching and code w/out any
 explicit marking.

Which is actually done at link time instead than at compile time. Now
going with compile time declaration brings us at least a couple of
things: a) LTO-enabled compilers should be able then to know what is
internal and what is exported; b) tools like my missingstatic can rely
on the hidden flag to know what is supposed to be used or static.

On the other hand it seems Ronald's patch is for the other side, i.e.
the importing of the symbols, not the exporting..

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] libspeex: Add a private option for enabling VAD

2012-10-01 Thread Diego Elio Pettenò 
On 01/10/2012 13:02, Martin Storsjö wrote:
  
 +/* VAD is activated with VBR or can be turned on by itself */
 +if (s-vad)
 + speex_encoder_ctl(s-enc_state, SPEEX_SET_VAD, s-vad);
 +

If you always called this, with s-vad == 0, would it matter?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [RELEASE] planning for 0.9

2012-09-28 Thread Diego Elio Pettenò 
On 28/09/2012 14:19, Sean McGovern wrote:
 OK folks, it's that time again -- we need to start thinking about releasing 
 0.9.

Given that we divide major versions and point versions 0.9 vs 0.9.1,
it would make sense to actually have it as a major version, i.e.,
version 9 instead of 0.9.

Comments?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] Identify anonymous AVIO typedef structs.

2012-09-26 Thread Diego Elio Pettenò 
On 26/09/2012 19:21, dalecur...@chromium.org wrote:
  libavformat/avio.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] ogg: calculate the start position once all the headers are parsed

2012-09-24 Thread Diego Elio Pettenò 
On 23/09/2012 15:56, Luca Barbato wrote:
 The fisbone packets can be muxed in any order as long the last one
 comes before the first data packet.

LGTM if it passes fate (and we have tests for it).

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3] Fix alaw handling in flv demuxer

2012-09-15 Thread Diego Elio Pettenò 
On 15/09/2012 19:09, Benjamin Larsson wrote:
  1 file changed, 1 insertion(+), 1 deletion(-)
LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/3] Use proper value for unsigned variable

2012-09-15 Thread Diego Elio Pettenò 
On 15/09/2012 19:09, Benjamin Larsson wrote:
 ---
  libavformat/dtsdec.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/3] Remove unused variable.

2012-09-15 Thread Diego Elio Pettenò 
On 15/09/2012 19:09, Benjamin Larsson wrote:
  libavformat/xwma.c |2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH v2] aacdec: add support for dual mono in Japanese DTV

2012-09-15 Thread Diego Elio Pettenò 
On 15/09/2012 19:43, atsuk...@users.sourceforge.net wrote:
 +/**

Nit: this is a doxygen comment starter but it's not followed by any
doxygen documentation.

 +if (is_dmono) {
 +if (ac-dmono_mode == 0) {
 +tmp = ac-output_data[1];
 +ac-output_data[1] = ac-output_data[0];
 +} else if (ac-dmono_mode == 1) {
 +tmp = ac-output_data[0];
 +ac-output_data[0] = ac-output_data[1];
 +}
 +}

Wouldn't it be more practical to invert the meaning of dmono_mode and
use that to index output_data? I see this later on as well...

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] Allow use of strncpy()

2012-09-14 Thread Diego Elio Pettenò 
On 14/09/2012 14:07, Måns Rullgård wrote:
 So no objections?

none here

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] vorbisdec: ensure FASTDIV denominator is never 1

2012-09-13 Thread Diego Elio Pettenò 
On 13/09/2012 10:45, Luca Barbato wrote:
 Both in usage of FASTDIV the denominator might be 1.

In both usages of FASTDIV I guess?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] x86: dsputil: Move SSE4 function pointer setting to SSE4 section

2012-09-06 Thread Diego Elio Pettenò 
On 06/09/2012 13:20, Diego Biurrun wrote:
 -if (mm_flags  AV_CPU_FLAG_SSE4) // not really sse4, just slow on Conroe
 -c-add_hfyu_left_prediction = ff_add_hfyu_left_prediction_sse4;

This looks like it might have to be tied to something else — AMD also
has ssse3 don't they?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] avio: make avio_close NULL the freed buffer

2012-09-04 Thread Diego Elio Pettenò 
On 04/09/2012 06:09, Luca Barbato wrote:
  libavformat/aviobuf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] build: disable ranlib on mingw

2012-09-04 Thread Diego Elio Pettenò 
On 04/09/2012 07:59, Mans Rullgard wrote:
 Using ranlib is not required but prevents using the libraries with
 msvc.

LGTM.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] build: utvideoenc: Add missing dependency on Huffman code

2012-09-04 Thread Diego Elio Pettenò 
On 04/09/2012 08:01, Diego Biurrun wrote:
  configure |1 +
  1 files changed, 1 insertions(+), 0 deletions(-)

LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] build: eamad: Add missing dependency on mpegvideo code

2012-09-04 Thread Diego Elio Pettenò 
On 04/09/2012 08:01, Diego Biurrun wrote:
  configure |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

Ok

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] intrax8dsp: Add missing #include to make header standalone

2012-09-03 Thread Diego Elio Pettenò 
On 03/09/2012 02:23, Diego Biurrun wrote:
 ---
  libavcodec/intrax8dsp.h |2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] configure: add support for bdver1 and bdver2 CPU types.

2012-09-03 Thread Diego Elio Pettenò 

Signed-off-by: Diego Elio Pettenò flamee...@flameeyes.eu
---
 configure | 4 ++--
 1 file modificato, 2 inserzioni(+), 2 rimozioni(-)

diff --git a/configure b/configure
index ff051f5..88c5c75 100755
--- a/configure
+++ b/configure
@@ -2122,7 +2122,7 @@ suncc_flags(){
 prescott|nocona)echo -xarch=sse3 -xchip=pentium4 ;;
 *-sse3) echo -xarch=sse3 ;;
 core2)  echo -xarch=ssse3 -xchip=core2   ;;
-amdfam10|barcelona)   echo -xarch=sse4_1 ;;
+amdfam10|barcelona|bdver*) echo -xarch=sse4_1;;
 athlon-4|athlon-[mx]p)echo -xarch=ssea   ;;
 k8|opteron|athlon64|athlon-fx)
   echo -xarch=sse2a  ;;
@@ -2494,7 +2494,7 @@ elif enabled x86; then
 disable cmov
 ;;
 # targets that do support conditional mov (cmov)
-
i686|pentiumpro|pentium[23]|pentium-m|athlon|athlon-tbird|athlon-4|athlon-[mx]p|athlon64*|k8*|opteron*|athlon-fx|core2|amdfam10|barcelona|atom)
+
i686|pentiumpro|pentium[23]|pentium-m|athlon|athlon-tbird|athlon-4|athlon-[mx]p|athlon64*|k8*|opteron*|athlon-fx|core2|amdfam10|barcelona|atom|bdver*)
 cpuflags=-march=$cpu
 enable cmov
 enable fast_cmov
-- 
1.7.12

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] yadif: cosmetics

2012-09-02 Thread Diego Elio Pettenò 
On 02/09/2012 01:11, Luca Barbato wrote:
 AV_PERM_ALL as in READ/WRITE might make sense globally, I'd keep
 PERM_ALL in this specific case.

AV_PERM_RW might be a better name than _ALL.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] pixdesc: cosmetics

2012-09-01 Thread Diego Elio Pettenò 
On 01/09/2012 03:30, Luca Barbato wrote:
 ---
  libavutil/pixdesc.c |   30 ++
  1 files changed, 18 insertions(+), 12 deletions(-)

LGTM, but the other Diego might be a better choice.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] Summary from libav discussion at VDD12

2012-09-01 Thread Diego Elio Pettenò 
Blatantly copying from Diego(#1)'s whiteboard

* AVOptions for Avfilter - Anton/Mashiat
* Audiolength - Alex C.
* TS Muxer
  - Bugzilla - Kieran
  - Wiki - Alex C.
* AVFormat Init
  - Finish Martin's Patchset - Martin
  - Init refactoring - Luca 2
* FFPresets
  - Make available API Public
  - Bugzilla - Derek
* Editlist
  - Alex C. Patch - Mans
  - Preroll-postroll - Bugzilla
Audio Downmix
  - Export mixes/coeffs - Rodeo
  - Kill DTS downmix - Rodeo!
Dirac
  - Review patch - Luca, Diego(#1)
Jpeg 2k
  - (Mentor) Mashiat
3DNow - KILL


-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] yadif: cosmetics

2012-09-01 Thread Diego Elio Pettenò 
On 01/09/2012 07:09, Luca Barbato wrote:
  
 +#define PERM_ALL AV_PERM_WRITE | AV_PERM_PRESERVE | AV_PERM_REUSE
 +

Shouldn't this be defined together with AV_PERM_*?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] yadif: cosmetics

2012-09-01 Thread Diego Elio Pettenò 
On 01/09/2012 08:47, Luca Barbato wrote:
 On 09/01/2012 05:37 PM, Diego Elio Pettenò wrote:
 On 01/09/2012 07:09, Luca Barbato wrote:
  
 +#define PERM_ALL AV_PERM_WRITE | AV_PERM_PRESERVE | AV_PERM_REUSE
 +

 Shouldn't this be defined together with AV_PERM_*?

 
 I'm not sure it is really all, might be useful to replace all the usages
 sooner or later.

#define AV_PERM_READ 0x01   /// can read from the buffer
#define AV_PERM_WRITE0x02   /// can write to the buffer
#define AV_PERM_PRESERVE 0x04   /// nobody else can overwrite the buffer
#define AV_PERM_REUSE0x08   /// can output the buffer multiple
times, with the same contents each time
#define AV_PERM_REUSE2   0x10   /// can output the buffer multiple
times, modified each time
#define AV_PERM_NEG_LINESIZES 0x20  /// the buffer requested can have
negative linesizes

It isn't — the name sounds wrong then.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] sdp: Include profile-level-id for H264

2012-08-28 Thread Diego Elio Pettenò 
On 28/08/2012 04:59, Martin Storsjö wrote:
  const char *pset_string = ; sprop-parameter-sets=;
 +const char *profile_string = ; profile-level-id=;

Any particular reasons why these are not `static const char name[]`?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] sdp: Use static const char arrays instead of pointers to strings

2012-08-28 Thread Diego Elio Pettenò 
On 28/08/2012 09:33, Martin Storsjö wrote:
 ---
  libavformat/sdp.c |4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

LGTM.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] Unused symbols

2012-08-25 Thread Diego Elio Pettenò 
On 25/08/2012 13:10, Måns Rullgård wrote:
  Nice list, how did you generate it?
 nm and some perl.
 

You do know that I wrote a tool for that in ruby-elf yes? :P

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] swscale: x86: fix #endif comments in rgb2rgb template file

2012-08-19 Thread Diego Elio Pettenò 
On 19/08/2012 12:26, Diego Biurrun wrote:
  libswscale/x86/rgb2rgb_template.c |4 ++--
LGTM

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] doc: update emacs config

2012-08-15 Thread Diego Elio Pettenò 
On 15/08/2012 08:58, Jordi Ortiz wrote:
 Emacs config as it is doesn't work, introduces tabs and doesn't show trailing 
 whitespaces.

LGTM.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Diego Elio Pettenò 
On 13/08/2012 03:06, Samuel Pitoiset wrote:
  And last thing, how does this deal with Flash 11 LZMA-compressed swf files?
 This is not supported.

Does it error out? Ignore it silently?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Diego Elio Pettenò 
On 13/08/2012 08:52, Samuel Pitoiset wrote:
 I could, but how to detect that the server deals with LZMA?

I'm just wondering what would happen if the user would pass a swf file
that is not what we handle.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] rtmp: Add support for authentification token

2012-08-13 Thread Diego Elio Pettenò 
On 13/08/2012 14:35, Samuel Pitoiset wrote:
 +@item rtmp_usher_token
 +Authentication token for strict servers like Justin.tv.
 +

Since as Martin says this seems to be strictly a feature for one
service, it doesn't feel right for this to be integrated as it is.

Instead we should have a way to have custom invokes (for libavformat
consumers). This way if one is writing a justin.tv client they can add
this back on their code, and if they are writing a client for another
service they can integrate their own.

Thoughts?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] rtmp: Add support for authentification token

2012-08-13 Thread Diego Elio Pettenò 
On 13/08/2012 15:03, Samuel Pitoiset wrote:
 Ok with you guys.
 Indeed, I think I won't have the time to do this task before the end
 but after the summer it's possible.

Then I'd say that unless you really require Justin.tv support for SoC,
we should put that one to bed for now.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-12 Thread Diego Elio Pettenò 
On 12/08/2012 12:45, Samuel Pitoiset wrote:
 +#include zlib.h
 +

no CONFIG_ZLIB protection?


-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-12 Thread Diego Elio Pettenò 
On 12/08/2012 12:45, Samuel Pitoiset wrote:
 +if ((ret = rtmp_uncompress_swfplayer(in_data + 8, in_size - 8,
 + out_data, out_size))  0)

Also sorry for the two-parter, but what happens if CONFIG_ZLIB is not
set and a swift file is compressed? I guess it should return an error
telling you that it can't proceed, but I don't see how that happens.

And last thing, how does this deal with Flash 11 LZMA-compressed swf files?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] x86: swscale: remove disabled code

2012-08-12 Thread Diego Elio Pettenò 
On 12/08/2012 16:57, Mans Rullgard wrote:
 This code has been disabled since 2003.  Nobody will ever look at
 it again.

LGTM.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] Fwd: RFC: Solaris Studio build failure

2012-08-09 Thread Diego Elio Pettenò 
On 09/08/2012 07:18, Sean McGovern wrote:
 b)deprecate and drop building with asm when using suncc on Solaris.

+1?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] doc: cygwin: Update list of FATE package requirements

2012-08-07 Thread Diego Elio Pettenò 
On 07/08/2012 05:56, Diego Biurrun wrote:
  doc/platform.texi |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

LGTM.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/3] mpegvideo: reduce excessive inlining of mpeg_motion()

2012-08-04 Thread Diego Elio Pettenò 
On 03/08/2012 19:44, Mans Rullgard wrote:
 all calls, create two versions of the fuction for field_based
 ^^^
typo

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] VDD and FOMS 2012

2012-08-04 Thread Diego Elio Pettenò 
On 04/08/2012 10:58, Diego Biurrun wrote:
 So who else is going to attend the VideoLAN Dev Days?  I know that Luca,
 Mans, Kostya and myself will be there.  Register and come to Paris :)

I will be there.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 0/3] Debloat mpegvideo a little

2012-08-03 Thread Diego Elio Pettenò 
On 03/08/2012 19:44, Mans Rullgard wrote:
 These patches reduce the code size by about 73k.

That's compiled results? Feel like doing an rbelf-size --diff?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] h264_ps: declare array of colorspace strings on its own line.

2012-07-28 Thread Diego Elio Pettenò 
Il 28/07/2012 21:45, Ronald S. Bultje ha scritto:
 From: Ronald S. Bultje rsbul...@gmail.com

LGTM.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] h264: Split H.264 decoder off from H.264 common code.

2012-07-27 Thread Diego Elio Pettenò 
Il 10/04/2012 16:00, Diego Biurrun ha scritto:
 So size increases for the default case.  I would suspect that some tables
 are getting duplicated somewhere.  I'll not go to the trouble of
 investigating issue now, so patch dropped.

Please don't use `ls -l` alone to judge binary size, use tools that
actually report size of ELF structures, such as size, eu-size or
rbelf-size (the former and latter you should have around, they're part
respectively of binutils and my Ruby ELF project).

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/4] Improve descriptiveness of a number of codec and container long names

2012-07-25 Thread Diego Elio Pettenò 
Il 25/07/2012 14:07, Diego Biurrun ha scritto:
 Umm, SWF and FLV files are not the same...

I know that (*sighs thinking about the actionscript he's writing*).

I mean that for some formats you have the extended name first then the
acronym in parenthesis; for other formats you have the acronym and then
the extended name in parenthesis.

Pick one style :)

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/4] Improve descriptiveness of a number of codec and container long names

2012-07-24 Thread Diego Elio Pettenò 
Honestly I'm a bit confused, you have

Flash Video (FLV)

and

SWF (ShockWave Flash)

maybe choose between the two?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 3/4] avformat: Drop pointless format from container long names

2012-07-24 Thread Diego Elio Pettenò 
Il 24/07/2012 15:08, Diego Biurrun ha scritto:
 +.long_name  = NULL_IF_CONFIG_SMALL(Apple Core Audio),

Shouldn't this be Apple CAF (Core Audio Format) ?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] round of stray commits

2012-07-23 Thread Diego Elio Pettenò 
Il 23/07/2012 17:03, Diego Biurrun ha scritto:
   I'm not entirely sure if I should have
 expected that or not.

You should. That's why it's best to work on a branch and only add to
master when you intend to push it.

Since your master tracks origin/master both ways, a git push to origin
_will_ push master unless you specifically says it not to (and I
honestly forgot how).

So...

git checkout -b dondiego origin/master
$doyourstuff

when it's time to push something

git checkout master
git am  $file
git push master

There, you're set :P

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] libopenjpeg: rename decoder source file.

2012-07-13 Thread Diego Elio Pettenò 
Il 13/07/2012 10:23, Diego Biurrun ha scritto:
 
   [diff]
 renames = copy

Thanks, I was looking how to enable this by default the other day :)

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] Add support for AAC encoding via the external library fdk-aac

2012-07-11 Thread Diego Elio Pettenò 
Il 11/07/2012 15:23, Jean-Baptiste Kempf ha scritto:
 This looks like freeware, not open source, to me.

It certainly seems to be okay with OSI, afaict, it might or might not be
Free Software...

 It is allowed to resell GPL binaries, and this provision blocks it;
 and it limits the usage of the software.

As Janne points out that wouldn't be copyright fee, although there might
be other issues involved as this is an additional restriction.

Would help to ask FSF for an evaluation I guess.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Try linking against math library without -lm first

2012-07-08 Thread Diego Elio Pettenò 
Il 08/07/2012 17:19, Diego Biurrun ha scritto:
 On some systems -lm is not required to link against libmath.

LGTM.

As a side note, IIRC Haiku has (or had) the same need.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] flvdec: optionally trust the metadata

2012-07-04 Thread Diego Elio Pettenò 
Il 04/07/2012 21:56, Luca Barbato ha scritto:
 In certain conditions video or audio frames might appear way later in the
 stream.

LGTM.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] x86: Add CPU flag for the i686 cmov instruction

2012-06-22 Thread Diego Elio Pettenò 
Il 22/06/2012 11:08, Diego Biurrun ha scritto:
 The canonical mmxext reference I was pointed to on IRC a while ago claims
 that mmxext was introduced by AMD with the Athlon:

Sorry I was on a low of caffeine yesterday it seems, I was thinking
mmx2, different thing altogether.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] x86: Add CPU flag for the i686 cmov instruction

2012-06-21 Thread Diego Elio Pettenò 
Il 21/06/2012 15:07, Diego Biurrun ha scritto:
 +if (std_caps  (1  15))
 +rval |= AV_CPU_FLAG_CMOV;
  if (std_caps  (123))

Maybe send a second patch to fix the coding style of the remaining tests?

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] x86: Add CPU flag for the i686 cmov instruction

2012-06-21 Thread Diego Elio Pettenò 
Il 21/06/2012 17:23, Måns Rullgård ha scritto:
 Yes, but does it have mmxext?

I don't think so (although Wikipedia says it did) — I had an Athlon Slot
A here. It did have 3dnowex though.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 6/7] mpegts: remove unused (incomplete?) seeking code

2012-06-18 Thread Diego Elio Pettenò 
Il 18/06/2012 15:48, Måns Rullgård ha scritto:
 Does anyone know what this code was intended for and why it was disabled?

It does remind me of something that is/was also in xine but I don't know
for sure..

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] mem: add support for _aligned_malloc() as found on Windows

2012-06-18 Thread Diego Elio Pettenò 
Il 18/06/2012 18:28, Måns Rullgård ha scritto:
 So what does this mean in terms of which systems a binary built
 with/without that flag will run on?

As far as I can tell, even version 7 is compatible with 2k and later. I
think it's 2010 that starts killing anything below XP.

-- 
Diego Elio Pettenò — Flameeyes
flamee...@flameeyes.eu — http://blog.flameeyes.eu/


___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

  1   2   >