Re: [libav-devel] [PATCH] Remove stray libavcore and _g binary references.

2011-04-25 Thread Aℓex Converse
On Sun, Apr 24, 2011 at 2:21 AM, Reinhard Tartler  wrote:
> On Sun, Apr 24, 2011 at 10:53:31 (CEST), Diego Biurrun wrote:
>
>> On Sat, Apr 23, 2011 at 11:50:00AM -0700, Alex Converse wrote:
>>> On Sat, Apr 23, 2011 at 5:16 AM, Diego Biurrun  wrote:
>>> >
>>> > --- a/Changelog
>>> > +++ b/Changelog
>>> > @@ -27,7 +27,6 @@ version 0.7_beta1:
>>> >  - ANSI/ASCII art playback system
>>> >  - Lego Mindstorms RSO de/muxer
>>> > -- libavcore added
>>> >  - SubRip subtitle file muxer and demuxer
>>> >  - Chinese AVS encoding via libxavs
>>>
>>> please don't remove this. Libavcore did exist for a time.
>>
>> IMO this can only serve to confuse the reader (that does not follow
>> development closely).  The removal of libavcore was not mentioned in
>> the changelog, so whoever looks at it (a year from now) will be kept
>> wondering what this libavcore thing is and where it went to.
>
> I tend to agree with Diego. The Changelog file serves primarily for
> reference what's different from the latest releases. If libavcore was
> already in the 0.6 series, then its removal should of course be
> mentioned. However like this, it's rather confusing IMO.
>

How about "libavcore added and subsequently removed." It was present
for a non-trivial amount of time.

That way if someone had a snapshot with libavcore and they upgrade
they aren't left wondering what happened.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] Remove stray libavcore and _g binary references.

2011-04-24 Thread Reinhard Tartler
On Sun, Apr 24, 2011 at 10:53:31 (CEST), Diego Biurrun wrote:

> On Sat, Apr 23, 2011 at 11:50:00AM -0700, Alex Converse wrote:
>> On Sat, Apr 23, 2011 at 5:16 AM, Diego Biurrun  wrote:
>> >
>> > --- a/Changelog
>> > +++ b/Changelog
>> > @@ -27,7 +27,6 @@ version 0.7_beta1:
>> >  - ANSI/ASCII art playback system
>> >  - Lego Mindstorms RSO de/muxer
>> > -- libavcore added
>> >  - SubRip subtitle file muxer and demuxer
>> >  - Chinese AVS encoding via libxavs
>> 
>> please don't remove this. Libavcore did exist for a time.
>
> IMO this can only serve to confuse the reader (that does not follow
> development closely).  The removal of libavcore was not mentioned in
> the changelog, so whoever looks at it (a year from now) will be kept
> wondering what this libavcore thing is and where it went to.

I tend to agree with Diego. The Changelog file serves primarily for
reference what's different from the latest releases. If libavcore was
already in the 0.6 series, then its removal should of course be
mentioned. However like this, it's rather confusing IMO.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] Remove stray libavcore and _g binary references.

2011-04-24 Thread Diego Biurrun
On Sat, Apr 23, 2011 at 11:50:00AM -0700, Alex Converse wrote:
> On Sat, Apr 23, 2011 at 5:16 AM, Diego Biurrun  wrote:
> >
> > --- a/Changelog
> > +++ b/Changelog
> > @@ -27,7 +27,6 @@ version 0.7_beta1:
> >  - ANSI/ASCII art playback system
> >  - Lego Mindstorms RSO de/muxer
> > -- libavcore added
> >  - SubRip subtitle file muxer and demuxer
> >  - Chinese AVS encoding via libxavs
> 
> please don't remove this. Libavcore did exist for a time.

IMO this can only serve to confuse the reader (that does not follow
development closely).  The removal of libavcore was not mentioned in
the changelog, so whoever looks at it (a year from now) will be kept
wondering what this libavcore thing is and where it went to.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] Remove stray libavcore and _g binary references.

2011-04-23 Thread Alex Converse
On Sat, Apr 23, 2011 at 5:16 AM, Diego Biurrun  wrote:
> ---
>  .gitignore |    2 --
>  Changelog  |    1 -
>  2 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index eac1758..3d5e38b 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -6,7 +6,6 @@
>  *.ho
>  *-example
>  *-test
> -*_g
>  config.*
>  doc/*.1
>  doc/*.html
> @@ -17,7 +16,6 @@ ffplay
>  ffprobe
>  ffserver
>  libavcodec/libavcodec*
> -libavcore/libavcore*
>  libavdevice/libavdevice*
>  libavfilter/libavfilter*
>  libavformat/libavformat*
> diff --git a/Changelog b/Changelog
> index f38ef9e..00777e4 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -27,7 +27,6 @@ version 0.7_beta1:
>  - RTP depacketization of QDM2
>  - ANSI/ASCII art playback system
>  - Lego Mindstorms RSO de/muxer
> -- libavcore added
>  - SubRip subtitle file muxer and demuxer
>  - Chinese AVS encoding via libxavs
>  - ffprobe -show_packets option added
> --

please don't remove this. Libavcore did exist for a time.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


Re: [libav-devel] [PATCH] Remove stray libavcore and _g binary references.

2011-04-23 Thread Luca Barbato

On 4/23/11 2:16 PM, Diego Biurrun wrote:

---
  .gitignore |2 --
  Changelog  |1 -
  2 files changed, 0 insertions(+), 3 deletions(-)


Ok

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel


[libav-devel] [PATCH] Remove stray libavcore and _g binary references.

2011-04-23 Thread Diego Biurrun
---
 .gitignore |2 --
 Changelog  |1 -
 2 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/.gitignore b/.gitignore
index eac1758..3d5e38b 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,7 +6,6 @@
 *.ho
 *-example
 *-test
-*_g
 config.*
 doc/*.1
 doc/*.html
@@ -17,7 +16,6 @@ ffplay
 ffprobe
 ffserver
 libavcodec/libavcodec*
-libavcore/libavcore*
 libavdevice/libavdevice*
 libavfilter/libavfilter*
 libavformat/libavformat*
diff --git a/Changelog b/Changelog
index f38ef9e..00777e4 100644
--- a/Changelog
+++ b/Changelog
@@ -27,7 +27,6 @@ version 0.7_beta1:
 - RTP depacketization of QDM2
 - ANSI/ASCII art playback system
 - Lego Mindstorms RSO de/muxer
-- libavcore added
 - SubRip subtitle file muxer and demuxer
 - Chinese AVS encoding via libxavs
 - ffprobe -show_packets option added
-- 
1.7.1

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel