Re: [libav-devel] [PATCH] build: support asan and tsan toolchain shortcuts
On 10/15/2012 05:51 PM, Måns Rullgård wrote: > Diego Biurrun writes: > >> On Mon, Oct 15, 2012 at 03:40:33AM +0200, Luca Barbato wrote: >>> --- >>> configure | 10 ++ >>> 1 file changed, 10 insertions(+) >> >> LGTM > > What, you don't want the entries sorted? > Right. updating and pushing this. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: support asan and tsan toolchain shortcuts
Diego Biurrun writes: > On Mon, Oct 15, 2012 at 03:40:33AM +0200, Luca Barbato wrote: >> --- >> configure | 10 ++ >> 1 file changed, 10 insertions(+) > > LGTM What, you don't want the entries sorted? -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: support asan and tsan toolchain shortcuts
On Mon, Oct 15, 2012 at 03:40:33AM +0200, Luca Barbato wrote: > --- > configure | 10 ++ > 1 file changed, 10 insertions(+) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] build: support asan and tsan toolchain shortcuts
--- configure | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configure b/configure index d8a5728..cb29f13 100755 --- a/configure +++ b/configure @@ -2053,6 +2053,16 @@ case "$toolchain" in nm_default="dumpbin -symbols" ar_default="lib" ;; +clang-asan) +cc_default="clang" +add_cflags -faddress-sanitizer +add_ldflags -faddress-sanitizer +;; +clang-tsan) +cc_default="clang" +add_cflags -fthread-sanitizer +add_ldflags -fthread-sanitizer +;; ?*) die "Unknown toolchain $toolchain" ;; -- 1.7.12 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: support asan and tsan toolchain shortcuts
Luca Barbato writes: > --- > configure | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/configure b/configure > index 26cd7ea..b4a1f96 100755 > --- a/configure > +++ b/configure > @@ -2053,6 +2053,16 @@ case "$toolchain" in > nm_default="dumpbin -symbols" > ar_default="lib" > ;; > +asan) > +cc_default="clang" > +add_cflags -faddress-sanitizer > +add_ldflags -faddress-sanitizer > +;; > +tsan) > +cc_default="clang" > +add_cflags -fthread-sanitizer > +add_ldflags -fthread-sanitizer > +;; > ?*) > die "Unknown toolchain $toolchain" > ;; > -- I suggest naming them clang-asan/clang-tsan. Also imagine Diego saying something about vertical alignment. -- Måns Rullgård m...@mansr.com ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH] build: support asan and tsan toolchain shortcuts
On 10/14/2012 07:55 AM, Luca Barbato wrote: > --- > configure | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/configure b/configure > index 26cd7ea..b4a1f96 100755 > --- a/configure > +++ b/configure > @@ -2053,6 +2053,16 @@ case "$toolchain" in > nm_default="dumpbin -symbols" > ar_default="lib" > ;; > +asan) > +cc_default="clang" > +add_cflags -faddress-sanitizer > +add_ldflags -faddress-sanitizer > +;; > +tsan) > +cc_default="clang" > +add_cflags -fthread-sanitizer > +add_ldflags -fthread-sanitizer > +;; > ?*) > die "Unknown toolchain $toolchain" > ;; Ping. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
[libav-devel] [PATCH] build: support asan and tsan toolchain shortcuts
--- configure | 10 ++ 1 file changed, 10 insertions(+) diff --git a/configure b/configure index 26cd7ea..b4a1f96 100755 --- a/configure +++ b/configure @@ -2053,6 +2053,16 @@ case "$toolchain" in nm_default="dumpbin -symbols" ar_default="lib" ;; +asan) +cc_default="clang" +add_cflags -faddress-sanitizer +add_ldflags -faddress-sanitizer +;; +tsan) +cc_default="clang" +add_cflags -fthread-sanitizer +add_ldflags -fthread-sanitizer +;; ?*) die "Unknown toolchain $toolchain" ;; -- 1.7.12 ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel