Re: [libav-devel] [PATCH] configure: Add a generic catch for all -W options with msvc/icl

2013-09-27 Thread Diego Biurrun 
On Wed, Sep 25, 2013 at 07:55:27AM -0400, Alex Smith wrote:
 On Wed, Sep 25, 2013 at 7:00 AM, Diego Biurrun di...@biurrun.de wrote:
  On Tue, Sep 24, 2013 at 11:18:10AM -0400, Alex Smith wrote:
  The latest icl silently ignores certain -W* options.  This is
  effectively a nop on older icl/msvc versions.
  --- a/configure
  +++ b/configure
  @@ -2390,9 +2390,9 @@ msvc_common_flags(){
   # In addition to specifying certain flags under the compiler
   # specific filters, they must be specified here as well or 
  else the
   # generic catch all at the bottom will print the original 
  flag.
  --Wall);;
   -std=c99) ;;
   # Common flags
  +-W*)  ;;
   -fomit-frame-pointer) ;;
   -g)   echo -Z7 ;;
   -fno-math-errno)  ;;
 
  I don't really understand what you are trying to achieve here and
  the log message does not enlighten me.
 
 Instead of issuing a warning (which we then turn into an error) to
 detect unknown command line options, the latest icl just treats them
 as valid but they don't do anything.

So why do you want to filter?

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Add a generic catch for all -W options with msvc/icl

2013-09-25 Thread Diego Biurrun 
On Tue, Sep 24, 2013 at 11:18:10AM -0400, Alex Smith wrote:
 The latest icl silently ignores certain -W* options.  This is
 effectively a nop on older icl/msvc versions.
 --- a/configure
 +++ b/configure
 @@ -2390,9 +2390,9 @@ msvc_common_flags(){
  # In addition to specifying certain flags under the compiler
  # specific filters, they must be specified here as well or else 
 the
  # generic catch all at the bottom will print the original flag.
 --Wall);;
  -std=c99) ;;
  # Common flags
 +-W*)  ;;
  -fomit-frame-pointer) ;;
  -g)   echo -Z7 ;;
  -fno-math-errno)  ;;

I don't really understand what you are trying to achieve here and
the log message does not enlighten me.

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Add a generic catch for all -W options with msvc/icl

2013-09-25 Thread Alex Smith 
On Wed, Sep 25, 2013 at 7:00 AM, Diego Biurrun di...@biurrun.de wrote:
 On Tue, Sep 24, 2013 at 11:18:10AM -0400, Alex Smith wrote:
 The latest icl silently ignores certain -W* options.  This is
 effectively a nop on older icl/msvc versions.
 --- a/configure
 +++ b/configure
 @@ -2390,9 +2390,9 @@ msvc_common_flags(){
  # In addition to specifying certain flags under the compiler
  # specific filters, they must be specified here as well or else 
 the
  # generic catch all at the bottom will print the original flag.
 --Wall);;
  -std=c99) ;;
  # Common flags
 +-W*)  ;;
  -fomit-frame-pointer) ;;
  -g)   echo -Z7 ;;
  -fno-math-errno)  ;;

 I don't really understand what you are trying to achieve here and
 the log message does not enlighten me.

 Diego

Instead of issuing a warning (which we then turn into an error) to
detect unknown command line options, the latest icl just treats them
as valid but they don't do anything.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] configure: Add a generic catch for all -W options with msvc/icl

2013-09-24 Thread Alex Smith 
The latest icl silently ignores certain -W* options.  This is
effectively a nop on older icl/msvc versions.
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 2e2a151..911176a 100755
--- a/configure
+++ b/configure
@@ -2390,9 +2390,9 @@ msvc_common_flags(){
 # In addition to specifying certain flags under the compiler
 # specific filters, they must be specified here as well or else the
 # generic catch all at the bottom will print the original flag.
--Wall);;
 -std=c99) ;;
 # Common flags
+-W*)  ;;
 -fomit-frame-pointer) ;;
 -g)   echo -Z7 ;;
 -fno-math-errno)  ;;
-- 
1.8.4.msysgit.0

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] configure: Add a generic catch for all -W options with msvc/icl

2013-09-24 Thread Luca Barbato 
On 24/09/13 17:18, Alex Smith wrote:
 The latest icl silently ignores certain -W* options.  This is
 effectively a nop on older icl/msvc versions.

Looks fine.

lu

___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel